[Home]

Summary:ASTERISK-15956: [patch] Add a parameter to SendDTMF dialplan application
Reporter:Roberto Casas (rcasas)Labels:
Date Opened:2010-04-14 07:33:09Date Closed:2010-05-24 17:18:48
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/NewFeature
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_senddtmf.c.patch
( 1) app_senddtmf.c.patch_trunk
Description:I have changed the SendDTMF application to allow playing DTMF's to a different channel than the caller one.

I've added a new argument, and when present, will use the related channel to send DTMF's
Comments:By: Paul Belanger (pabelanger) 2010-04-14 08:56:35

Thanks for the patch.

Out of curiously, why would you need to do this?

By: Roberto Casas (rcasas) 2010-04-14 09:30:21

I need to interact with a teleassistance system.

I have a channel opened with the terminal, waiting for an operator to accept the alarm.

When an operator accepts the alarm, I need to send a DTMF sequence to the other channel that force it to open the speaker and the microphone of the terminal.

So, in the extension that the operators phone uses to accepts alarms, I use this modified SendDTMF and then the Bridge to join the two channels.



By: Leif Madsen (lmadsen) 2010-04-14 10:03:55

Since this is a feature this would need to be submitted against trunk. I can't imagine that app_senddtmf.c is much different between 1.6.2.6 and trunk though, but it'd be good to at least do a simple compile and test.

By: Leif Madsen (lmadsen) 2010-04-14 10:04:20

BTW: Thanks for the feature!

By: Roberto Casas (rcasas) 2010-04-14 10:07:27

You're welcome.

Tomorrow I'll obtain the up to date trunk, and send the patch against it.

By: Roberto Casas (rcasas) 2010-04-15 02:13:10

I've submitted the patch against trunk.

By: Leif Madsen (lmadsen) 2010-04-15 12:28:34

Thanks for the submission! Feel free to email the asterisk-users and/or asterisk-dev mailing list to see if you can get some testers.

By: Russell Bryant (russell) 2010-04-28 11:14:50

If the channel is not the one executing the application (chan != dchan), then chan needs to be put in autoservice while the DTMF is being played out to the other channel.  See ast_autoservice_start()/stop().

By: Digium Subversion (svnbot) 2010-05-24 17:18:47

Repository: asterisk
Revision: 265453

U   trunk/apps/app_senddtmf.c

------------------------------------------------------------------------
r265453 | mmichelson | 2010-05-24 17:16:29 -0500 (Mon, 24 May 2010) | 11 lines

Allow SendDTMF to play digits to a specified channel.

Patch supplied by reporter was modified to use autoservice and
prevent a potential channel ref leak but is otherwise as the
reporter uploaded it.

(closes issue ASTERISK-15956)
Reported by: rcasas
Patches:
     app_senddtmf.c.patch_trunk uploaded by rcasas (license 641)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=265453