Summary:	ASTERISK-15940: [patch] ALL VERSIONS ! between two asterisks and peers authenticate as coincidental name invite
Reporter:	german aracil boned (tecnoxarxa)	Labels:
Date Opened:	2010-04-11 09:39:47	Date Closed:	2011-06-07 14:05:08
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_sip/DatabaseSupport
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) chan_sip.c.patch
Description:	If you use the same table for peers and friends, and valid for two asterisk ip with a peer, when one calls another asterisk, should match the ID "name" of a client friend, Asterisk does not allow the call. .. if you look at the role realtime_peer (chan_sip.c) you can see a stupid comment. That comment is not mine I swear! Solution, looking for peer with ip and port first. For comment: delete it. ****** ADDITIONAL INFORMATION ****** ALL VERSIONS !!! EXAMPLE PATCH: Edit: Removed inline patch - pabelanger
Comments:	By: Paul Belanger (pabelanger) 2010-04-11 11:54:46 Please submit a proper patch (see below). --- Please use "diff -u" or "svn diff" on all your patches. Patches which include alternate formatting are almost certainly going to be thrown out or ignored; there are too few hours in the day to wade through difficult-to-follow C code fixes without the help of "diff -u". By: german aracil boned (tecnoxarxa) 2010-04-11 20:29:30 Add patch for 1.6.2.7-rc1 chan_sip.c By: german aracil boned (tecnoxarxa) 2010-04-11 20:37:26 A bug like this to "[Asterisk] Channels / chan_sip / DatabaseSupport" that prevents communication between Asterisk and other SIP server is minor ? By: Paul Belanger (pabelanger) 2010-04-11 20:45:53 Thanks for the patch.  As for the severity, minor only refers to the number of users affected. By: german aracil boned (tecnoxarxa) 2010-04-11 21:41:46 Thank you pabelanger. By: Leif Madsen (lmadsen) 2010-04-12 10:59:21 Confirming this issue until a developer can look at this to determine if this is really a path we want to go down. This appears to be changing the existing functionality to match on IP and port first, which is not the way chan_sip works outside of realtime; it matches on users first, then matches on IP as a failover. If this does go in, we definitely need to make sure CHANGES and UPGRADE.txt are updated as appropriate. By: Leif Madsen (lmadsen) 2010-04-19 15:02:06 Sending a ping to oej about this proposal to change the way SIP peer matching works. By: Olle Johansson (oej) 2010-04-19 15:13:00 No, we can't change this order. It will break compatibility with everything we have out there. Sorry. By: Olle Johansson (oej) 2010-04-19 15:13:59 This is why we have clearly documented that peers should have unique names that doesn't collide with possible extensions or caller ID names - like mac addresses. By: Leif Madsen (lmadsen) 2010-04-19 15:18:16 oej: Thanks for the quick response. This is what I was thinking as well. Closing this issue as we can't change this functionality.