[Home]

Summary:ASTERISK-15920: [patch] Endpoints are not loaded when using Realtime
Reporter:Nahuel Greco (nahuelgreco)Labels:
Date Opened:2010-04-06 15:44:30Date Closed:2010-06-23 13:25:54
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_mgcp
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20100513__issue17144__trunk.diff.txt
( 1) chan_mgcp.c.patch
Description:When using Realtime, endpoints are loaded only if they are defined with a trailing comma. So, if in the "lines" field of the "mgcpgw" table you have "aaln/1,aaln/2", only "aaln/1" is loaded, because the code loads the endpoint only when it encounters a comma, not the end of the string.

The attached patch trivially fixes the issue.
Comments:By: Tilghman Lesher (tilghman) 2010-05-13 18:52:42

I have modified your patch to use the standard parsing, instead.  This greatly improves the readability of the code, as well as adding a comment that indicates how the code works, as well as a realtime table design suggestion.
By: Tilghman Lesher (tilghman) 2010-05-24 13:30:45

nahuelgreco:  your feedback on this new patch would be greatly appreciated.
By: Digium Subversion (svnbot) 2010-06-23 13:25:54

Repository: asterisk
Revision: 272145

U   trunk/channels/chan_mgcp.c

------------------------------------------------------------------------
r272145 | tilghman | 2010-06-23 13:25:53 -0500 (Wed, 23 Jun 2010) | 8 lines

Load all lines from realtime, not just the first one.

(closes issue ASTERISK-15920)
Reported by: nahuelgreco
Patches:
      20100513__issue17144__trunk.diff.txt uploaded by tilghman (license 14)
Tested by: tilghman

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=272145