[Home]

Summary:ASTERISK-15919: hidecalleridname parameter in chan_dahdi.conf
Reporter:Douglas Jensen (djensen99)Labels:
Date Opened:2010-04-06 14:58:16Date Closed:2010-04-27 14:03:07
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_dahdi
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) diff.txt
Description:I located Asterisk Issue ASTERISK-71331 via a Google search when attempting to diagnose Caller ID Name corruption issues between Asterisk and a legacy PBX via DAHDI.  This issue adds a new parameter to chan_dahdi.conf called hidecalleridname, which prevents the caller ID name information from being sent over PRI.  After setting this parameter and rebooting the Asterisk system, no change was seen.  In reviewing notes by qwell at https://issues.asterisk.org/view.php?id=7321#49311 regarding this implementation, the local variable was never instantiated from the configuration file setting.

****** ADDITIONAL INFORMATION ******

Adding the following line to chan_dahdi.c and recompiling makes this feature work as intended.  This fix is mentioned but not implemented in the ticket referenced above.

Edit: Removed inline patch submission. - pabelanger
Comments:By: Paul Belanger (pabelanger) 2010-04-06 15:19:10

Please use "diff -u" or "svn diff" on all your patches. Patches which include alternate formatting are almost certainly going to be thrown out or ignored; there are too few hours in the day to wade through difficult-to-follow C code fixes without the help of "diff -u".
By: Douglas Jensen (djensen99) 2010-04-06 15:39:35

This was a single-line change...

I have attached your diff -u output.
By: Digium Subversion (svnbot) 2010-04-27 13:14:56

Repository: asterisk
Revision: 259270

U   branches/1.4/channels/chan_dahdi.c
U   branches/1.4/configs/chan_dahdi.conf.sample

------------------------------------------------------------------------
r259270 | rmudgett | 2010-04-27 13:14:55 -0500 (Tue, 27 Apr 2010) | 14 lines

hidecalleridname parameter in chan_dahdi.conf

Issue ASTERISK-7133 implements a new chan_dahdi configuration option.  However, a
change mentioned in the issue was never implemented.  This is the change
that will allow the feature to work.

I added a note to chan_dahdi.conf.sample about the feature.

(closes issue ASTERISK-15919)
Reported by: djensen99
Patches:
     diff.txt uploaded by djensen99 (license NA) (One line change)
Tested by: djensen99

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=259270
By: Digium Subversion (svnbot) 2010-04-27 13:29:35

Repository: asterisk
Revision: 259307

_U  trunk/
U   trunk/channels/chan_dahdi.c
U   trunk/configs/chan_dahdi.conf.sample

------------------------------------------------------------------------
r259307 | rmudgett | 2010-04-27 13:29:34 -0500 (Tue, 27 Apr 2010) | 21 lines

Merged revisions 259270 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r259270 | rmudgett | 2010-04-27 13:14:54 -0500 (Tue, 27 Apr 2010) | 14 lines
 
 hidecalleridname parameter in chan_dahdi.conf
 
 Issue ASTERISK-7133 implements a new chan_dahdi configuration option.  However, a
 change mentioned in the issue was never implemented.  This is the change
 that will allow the feature to work.
 
 I added a note to chan_dahdi.conf.sample about the feature.
 
 (closes issue ASTERISK-15919)
 Reported by: djensen99
 Patches:
       diff.txt uploaded by djensen99 (license NA) (One line change)
 Tested by: djensen99
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=259307
By: Digium Subversion (svnbot) 2010-04-27 13:41:39

Repository: asterisk
Revision: 259308

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_dahdi.c
U   branches/1.6.0/configs/chan_dahdi.conf.sample

------------------------------------------------------------------------
r259308 | rmudgett | 2010-04-27 13:41:38 -0500 (Tue, 27 Apr 2010) | 28 lines

Merged revisions 259307 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r259307 | rmudgett | 2010-04-27 13:29:33 -0500 (Tue, 27 Apr 2010) | 21 lines
 
 Merged revisions 259270 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r259270 | rmudgett | 2010-04-27 13:14:54 -0500 (Tue, 27 Apr 2010) | 14 lines
   
   hidecalleridname parameter in chan_dahdi.conf
   
   Issue ASTERISK-7133 implements a new chan_dahdi configuration option.  However, a
   change mentioned in the issue was never implemented.  This is the change
   that will allow the feature to work.
   
   I added a note to chan_dahdi.conf.sample about the feature.
   
   (closes issue ASTERISK-15919)
   Reported by: djensen99
   Patches:
         diff.txt uploaded by djensen99 (license NA) (One line change)
   Tested by: djensen99
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=259308
By: Digium Subversion (svnbot) 2010-04-27 13:53:19

Repository: asterisk
Revision: 259309

_U  branches/1.6.1/
U   branches/1.6.1/channels/chan_dahdi.c
U   branches/1.6.1/configs/chan_dahdi.conf.sample

------------------------------------------------------------------------
r259309 | rmudgett | 2010-04-27 13:53:18 -0500 (Tue, 27 Apr 2010) | 28 lines

Merged revisions 259307 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r259307 | rmudgett | 2010-04-27 13:29:33 -0500 (Tue, 27 Apr 2010) | 21 lines
 
 Merged revisions 259270 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r259270 | rmudgett | 2010-04-27 13:14:54 -0500 (Tue, 27 Apr 2010) | 14 lines
   
   hidecalleridname parameter in chan_dahdi.conf
   
   Issue ASTERISK-7133 implements a new chan_dahdi configuration option.  However, a
   change mentioned in the issue was never implemented.  This is the change
   that will allow the feature to work.
   
   I added a note to chan_dahdi.conf.sample about the feature.
   
   (closes issue ASTERISK-15919)
   Reported by: djensen99
   Patches:
         diff.txt uploaded by djensen99 (license NA) (One line change)
   Tested by: djensen99
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=259309
By: Digium Subversion (svnbot) 2010-04-27 14:03:06

Repository: asterisk
Revision: 259310

_U  branches/1.6.2/
U   branches/1.6.2/channels/chan_dahdi.c
U   branches/1.6.2/configs/chan_dahdi.conf.sample

------------------------------------------------------------------------
r259310 | rmudgett | 2010-04-27 14:03:05 -0500 (Tue, 27 Apr 2010) | 28 lines

Merged revisions 259307 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r259307 | rmudgett | 2010-04-27 13:29:33 -0500 (Tue, 27 Apr 2010) | 21 lines
 
 Merged revisions 259270 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r259270 | rmudgett | 2010-04-27 13:14:54 -0500 (Tue, 27 Apr 2010) | 14 lines
   
   hidecalleridname parameter in chan_dahdi.conf
   
   Issue ASTERISK-7133 implements a new chan_dahdi configuration option.  However, a
   change mentioned in the issue was never implemented.  This is the change
   that will allow the feature to work.
   
   I added a note to chan_dahdi.conf.sample about the feature.
   
   (closes issue ASTERISK-15919)
   Reported by: djensen99
   Patches:
         diff.txt uploaded by djensen99 (license NA) (One line change)
   Tested by: djensen99
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=259310