Summary:ASTERISK-15904: [patch] Wrong encoding of SIP URI
Reporter:Sascha Daniels (sdaniels)Labels:
Date Opened:2010-04-01 16:37:53Date Closed:2011-06-07 14:05:25
Versions:Frequency of
Environment:Attachments:( 0) 20100506__issue17127.diff.txt
( 1) sip_extension_debug.tgz
Description:When callerid(num) of an incoming call has a # in the number the SIP URI is not encoded properly.

Should be encoded as %23

A lot of phones just reject the call.


<--- SIP read from --->
SIP/2.0 100 Trying
To: <sip:833@>
From: "00XXXXXXXXXX" <sip:1#00XXXXXXXXXX@>;tag=as404e0b2a

Should be:
<--- SIP read from --->
SIP/2.0 100 Trying
To: <sip:833@>
From: "00XXXXXXXXXX" <sip:1%2300XXXXXXXXXX@>;tag=as404e0b2a
Comments:By: leff (leff) 2010-04-05 12:12:11


By: Sascha Daniels (sdaniels) 2010-04-05 14:29:47

Yes pedantic=yes.

Just double checked with 1.4.28 installation.
-> Both show the same missing encoding

By: Paul Belanger (pabelanger) 2010-04-05 15:16:51

Thank you for taking the time to report this bug and helping to make Asterisk better. Unfortunately, we cannot work on this bug because your description didn\'t include enough information. You may find it helpful to read \"Asterisk Issue Guidelines\" http://www.asterisk.org/developers/bug-guidelines. [^] We\'d be grateful if you would then provide a more complete description of the problem.

At a minimum, we need:
1. the specific steps or actions you took that caused you to encounter the problem,
2. the behavior you expected, and
3. the behavior you actually encountered (in as much detail as possible).

This likely includes output from the console with debug level logging, a SIP trace (if this is SIP related), and configuration information such as dialplan (e.g. extensions.conf) and channel configuration (e.g. sip.conf).


By: Sascha Daniels (sdaniels) 2010-04-05 16:30:48

sip.conf, extension.conf and sip debug of incoming call uploaded (testserver to make debug more simple).

I am using strings with a # for choosing the outgoing line. On incoming calls I am preparing the number for callback by adding the strings.

It is working without problmes with Snom ore Linksys phones.

Testing Aastra phones I get "400 Bad Request" back from phone on incoming call.

Talking to the support of Aastra I got the answer back, that # must be encoded in sip uri.

Checking outgoing call from Aastra phone with # in the number shows encoded uri.

From: "001707901706" <sip:1%23001707901706@>;tag=as24950318
From: "001707901706" <sip:1ASTERISK-168207901706@>;tag=as24950318

According to http://www.ietf.org/rfc/rfc2396.txt the # must be escaped.

By: Tilghman Lesher (tilghman) 2010-05-06 14:09:56

Patch uploaded.  Please verify whether it fixes the issue for you.

By: Tilghman Lesher (tilghman) 2010-05-11 14:42:55

sdaniels: your feedback on this issue would be appreciated.

By: Tilghman Lesher (tilghman) 2010-05-18 13:44:30

No response from reporter.