Summary:ASTERISK-15874: unportable shell in safe_asterisk
Reporter:Stuart Henderson (stuarth)Labels:
Date Opened:2010-03-25 07:08:56Date Closed:2010-03-25 12:02:19
Versions:Frequency of
Description:"function message() {" is unportable, I think it should be replaced with just "message() {" as was already done for run_asterisk().
Comments:By: Stuart Henderson (stuarth) 2010-03-25 10:56:12

Hmm, this isn't actually addressed by ASTERISK-15293. I just noticed Michiel committed a fix to trunk for this in r135061 but it hasn't been pushed back to 1.6.0, could that be done please? Thanks!

By: Leif Madsen (lmadsen) 2010-03-25 11:21:21

Yes, I found out what I was doing wrong. For some reason other changes to the file have caused it to be pushed back into every branch other than 1.6.0 for some reason.

By: Digium Subversion (svnbot) 2010-03-25 12:02:18

Repository: asterisk
Revision: 254539

_U  branches/1.6.0/
U   branches/1.6.0/contrib/scripts/safe_asterisk

r254539 | lmadsen | 2010-03-25 12:02:17 -0500 (Thu, 25 Mar 2010) | 28 lines

Make safe_asterisk work on dash/sh/bash etc.

Merged from the change to trunk via issue ASTERISK-12412. For some reason
the changes there were only done on trunk, and thus were available
for 1.6.1 and 1.6.2 when they were branched. Because this change is
available on both 1.6.1 and 1.6.2, it makes sense to allow it on the
1.6.0 branch as well.

(closes issue ASTERISK-15874)
Reported by: stuarth

Much thanks to Tilghman and Sean Bright for the help on this merge.

Merged revisions 135061 via svnmerge from

 r135061 | mvanbaak | 2008-08-01 07:17:33 -0500 (Fri, 01 Aug 2008) | 8 lines
 Make safe_asterisk work on dash/sh/bash etc.
 (closes issue ASTERISK-12412)
 Reported by: pabelanger
       2008071901_issue13111_safe_asterisk.diff uploaded by mvanbaak (license 7)
 Tested by: mvanbaak, pabelanger