[Home]

Summary:ASTERISK-15873: [patch] AGI SPEECH SET bugs
Reporter:gpatri (gpatri)Labels:
Date Opened:2010-03-24 12:39:56Date Closed:2010-03-25 10:22:32
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Resources/res_agi
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) res_agi.patch
Description:Agi speech set is: SPEECH SET {KEY} {VALUE}

code check for args!=3 but it's args!=4

****** ADDITIONAL INFORMATION ******

--- res_agi.c.ori       2010-03-24 13:04:46.000000000 -0400
+++ res_agi.c   2010-03-24 13:08:36.000000000 -0400
@@ -2014,7 +2014,7 @@
static int handle_speechset(struct ast_channel *chan, AGI *agi, int argc, char **argv)
{
       /* Check for minimum arguments */
-        if (argc != 3)
+        if (argc != 4)
               return RESULT_SHOWUSAGE;
Comments:By: Paul Belanger (pabelanger) 2010-03-24 21:39:22

You will need to submit this as a patch.

http://www.asterisk.org/developers/bug-guidelines
By: Leif Madsen (lmadsen) 2010-03-25 10:04:15

It's trivial enough that a patch isn't necessary in this case.

gpatri: thanks for the submission!

pabelanger: thanks for the triage!
By: Digium Subversion (svnbot) 2010-03-25 10:21:27

Repository: asterisk
Revision: 254446

U   trunk/res/res_agi.c

------------------------------------------------------------------------
r254446 | lmadsen | 2010-03-25 10:21:26 -0500 (Thu, 25 Mar 2010) | 9 lines

handle_speechset has 4 arguments.

Update code to reflect that handle_speechset has 4 arguments.

(closes issue ASTERISK-15873)
Reported by: gpatri
Patches:
     res_agi.patch uploaded by gpatri (license 1014)
Tested by: pabelanger, mmichelson
------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=254446
By: Digium Subversion (svnbot) 2010-03-25 10:21:51

Repository: asterisk
Revision: 254447

_U  branches/1.6.2/
U   branches/1.6.2/res/res_agi.c

------------------------------------------------------------------------
r254447 | lmadsen | 2010-03-25 10:21:51 -0500 (Thu, 25 Mar 2010) | 17 lines

Merged revisions 254446 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r254446 | lmadsen | 2010-03-25 10:21:26 -0500 (Thu, 25 Mar 2010) | 9 lines
 
 handle_speechset has 4 arguments.
 
 Update code to reflect that handle_speechset has 4 arguments.
 
 (closes issue ASTERISK-15873)
 Reported by: gpatri
 Patches:
       res_agi.patch uploaded by gpatri (license 1014)
 Tested by: pabelanger, mmichelson
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=254447
By: Digium Subversion (svnbot) 2010-03-25 10:22:10

Repository: asterisk
Revision: 254448

_U  branches/1.6.1/
U   branches/1.6.1/res/res_agi.c

------------------------------------------------------------------------
r254448 | lmadsen | 2010-03-25 10:22:10 -0500 (Thu, 25 Mar 2010) | 17 lines

Merged revisions 254446 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r254446 | lmadsen | 2010-03-25 10:21:26 -0500 (Thu, 25 Mar 2010) | 9 lines
 
 handle_speechset has 4 arguments.
 
 Update code to reflect that handle_speechset has 4 arguments.
 
 (closes issue ASTERISK-15873)
 Reported by: gpatri
 Patches:
       res_agi.patch uploaded by gpatri (license 1014)
 Tested by: pabelanger, mmichelson
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=254448
By: Digium Subversion (svnbot) 2010-03-25 10:22:31

Repository: asterisk
Revision: 254449

_U  branches/1.6.0/
U   branches/1.6.0/res/res_agi.c

------------------------------------------------------------------------
r254449 | lmadsen | 2010-03-25 10:22:31 -0500 (Thu, 25 Mar 2010) | 17 lines

Merged revisions 254446 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r254446 | lmadsen | 2010-03-25 10:21:26 -0500 (Thu, 25 Mar 2010) | 9 lines
 
 handle_speechset has 4 arguments.
 
 Update code to reflect that handle_speechset has 4 arguments.
 
 (closes issue ASTERISK-15873)
 Reported by: gpatri
 Patches:
       res_agi.patch uploaded by gpatri (license 1014)
 Tested by: pabelanger, mmichelson
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=254449