[Home]

Summary:ASTERISK-15867: [patch] Segfault in manager event after fax receipt
Reporter:Ben Klang (bklang)Labels:
Date Opened:2010-03-23 14:49:55Date Closed:2010-07-14 13:37:20
Priority:CriticalRegression?No
Status:Closed/CompleteComponents:Core/ManagerInterface
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app-fax-null-sprintf1.diff
( 1) gdb.txt
Description:I have discovered another segfault in Asterisk.  It looks very similar to the segfaults that were fixed recently in res_agi.c that are triggered by a null being passed to sprintf().

gdb output attached.
Comments:By: Leif Madsen (lmadsen) 2010-03-23 15:25:46

Thanks for filing a report with a useful summary and description :)
By: Matthew Nicholson (mnicholson) 2010-05-21 12:21:58

Please try the app-fax-null-sprintf1.diff patch I just uploaded and see if it fixes your issue.
By: Matthew Nicholson (mnicholson) 2010-06-01 08:46:48

Have you been able to test this yet?
By: Ben Klang (bklang) 2010-06-01 11:22:46

I have patched my dev system with this patch and will attempt to reproduce the issue today.
By: Matthew Nicholson (mnicholson) 2010-06-07 09:31:49

Any updates on this?
By: Ben Klang (bklang) 2010-06-07 13:34:35

So far, no crash, but I'm also not 100% sure I'm recreating the exact test conditions.  At least I can say it does not seem to break anything.
By: Matthew Nicholson (mnicholson) 2010-06-07 15:08:21

I am going to commit this.  Reopen the issue if it turns out this change does not actually fix the crash.
By: Digium Subversion (svnbot) 2010-06-08 13:50:45

Repository: asterisk
Revision: 269083

U   trunk/apps/app_fax.c

------------------------------------------------------------------------
r269083 | mnicholson | 2010-06-08 13:50:45 -0500 (Tue, 08 Jun 2010) | 9 lines

Don't pass null to manager_event()

(closes issue ASTERISK-15867)
Reported by: bklang
Patches:
     app-fax-null-sprintf1.diff uploaded by mnicholson (license 96)
Tested by: bklang


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=269083
By: Digium Subversion (svnbot) 2010-06-08 13:51:19

Repository: asterisk
Revision: 269084

_U  branches/1.6.2/
U   branches/1.6.2/apps/app_fax.c

------------------------------------------------------------------------
r269084 | mnicholson | 2010-06-08 13:51:19 -0500 (Tue, 08 Jun 2010) | 15 lines

Merged revisions 269083 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r269083 | mnicholson | 2010-06-08 13:50:45 -0500 (Tue, 08 Jun 2010) | 9 lines
 
 Don't pass null to manager_event()
 
 (closes issue ASTERISK-15867)
 Reported by: bklang
 Patches:
       app-fax-null-sprintf1.diff uploaded by mnicholson (license 96)
 Tested by: bklang
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=269084