| Summary: | ASTERISK-15834: chanspy on channel in MeetMe conference results in a crash | ||
| Reporter: | David Vossel (dvossel) | Labels: | |
| Date Opened: | 2010-03-17 12:54:11 | Date Closed: | 2010-06-03 11:35:27 |
| Priority: | Critical | Regression? | No |
| Status: | Closed/Complete | Components: | General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) bt_full.txt ( 1) bt.txt | |
| Description: | Using ChanSpy on channel in that is in a MeetMe conference results in a crash. This occurs in both sip and iax so I don't believe it has to do with a channel driver. bt and bt full included. I put this in the general category because I really have no idea what is causing the crash. I don't thing it has to do with chanspy, because chanspy works correctly when spying on channels outside of the MeetMe room. Perhaps it has something to do with the channel in the meetme room being bridged to a local channel. I'm not sure. I can reproduce this 100% of the time. Just put two channels in a meetme conference (using ulaw as codec not sure if that matters) and then attempting to use ChanSpy on either of those channels will result in a crash. ****** ADDITIONAL INFORMATION ****** This only currently affects trunk. I tested this against 1.6.2 and the crash did not occur. | ||
| Comments: | By: David Vossel (dvossel) 2010-03-17 12:55:21 I compiled with don't optimize, but some of the values still say optimized out. By: Leif Madsen (lmadsen) 2010-03-17 14:08:04 Can you compile with DONT_OPTIMIZE? It appears you have some values optimized out. Please see the doc/backtrace.txt file in your Asterisk source. Thanks! (I kid :)) By: Digium Subversion (svnbot) 2010-04-29 10:31:02 Repository: asterisk Revision: 260049 U branches/1.4/include/asterisk/audiohook.h U branches/1.4/main/audiohook.c ------------------------------------------------------------------------ r260049 | dvossel | 2010-04-29 10:31:02 -0500 (Thu, 29 Apr 2010) | 14 lines Fixes crash in audiohook_write_list The middle_frame in the audiohook_write_list function was being freed if a audiohook manipulator returned a failure. This is incorrect logic. This patch resolves this and adds detailed descriptions of how this function should work and why manipulator failures must be ignored. (closes issue ASTERISK-15834) Reported by: dvossel Tested by: dvossel Review: https://reviewboard.asterisk.org/r/623/ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=260049 By: Digium Subversion (svnbot) 2010-04-29 10:33:27 Repository: asterisk Revision: 260050 _U trunk/ U trunk/include/asterisk/audiohook.h U trunk/main/audiohook.c ------------------------------------------------------------------------ r260050 | dvossel | 2010-04-29 10:33:27 -0500 (Thu, 29 Apr 2010) | 21 lines Merged revisions 260049 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r260049 | dvossel | 2010-04-29 10:31:02 -0500 (Thu, 29 Apr 2010) | 14 lines Fixes crash in audiohook_write_list The middle_frame in the audiohook_write_list function was being freed if a audiohook manipulator returned a failure. This is incorrect logic. This patch resolves this and adds detailed descriptions of how this function should work and why manipulator failures must be ignored. (closes issue ASTERISK-15834) Reported by: dvossel Tested by: dvossel Review: https://reviewboard.asterisk.org/r/623/ ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=260050 By: Digium Subversion (svnbot) 2010-04-29 10:35:39 Repository: asterisk Revision: 260051 _U branches/1.6.2/ U branches/1.6.2/include/asterisk/audiohook.h U branches/1.6.2/main/audiohook.c ------------------------------------------------------------------------ r260051 | dvossel | 2010-04-29 10:35:38 -0500 (Thu, 29 Apr 2010) | 28 lines Merged revisions 260050 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r260050 | dvossel | 2010-04-29 10:33:27 -0500 (Thu, 29 Apr 2010) | 21 lines Merged revisions 260049 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r260049 | dvossel | 2010-04-29 10:31:02 -0500 (Thu, 29 Apr 2010) | 14 lines Fixes crash in audiohook_write_list The middle_frame in the audiohook_write_list function was being freed if a audiohook manipulator returned a failure. This is incorrect logic. This patch resolves this and adds detailed descriptions of how this function should work and why manipulator failures must be ignored. (closes issue ASTERISK-15834) Reported by: dvossel Tested by: dvossel Review: https://reviewboard.asterisk.org/r/623/ ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=260051 By: Digium Subversion (svnbot) 2010-04-29 10:37:15 Repository: asterisk Revision: 260052 _U branches/1.6.1/ U branches/1.6.1/include/asterisk/audiohook.h U branches/1.6.1/main/audiohook.c ------------------------------------------------------------------------ r260052 | dvossel | 2010-04-29 10:37:15 -0500 (Thu, 29 Apr 2010) | 28 lines Merged revisions 260050 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r260050 | dvossel | 2010-04-29 10:33:27 -0500 (Thu, 29 Apr 2010) | 21 lines Merged revisions 260049 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r260049 | dvossel | 2010-04-29 10:31:02 -0500 (Thu, 29 Apr 2010) | 14 lines Fixes crash in audiohook_write_list The middle_frame in the audiohook_write_list function was being freed if a audiohook manipulator returned a failure. This is incorrect logic. This patch resolves this and adds detailed descriptions of how this function should work and why manipulator failures must be ignored. (closes issue ASTERISK-15834) Reported by: dvossel Tested by: dvossel Review: https://reviewboard.asterisk.org/r/623/ ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=260052 By: Digium Subversion (svnbot) 2010-04-29 10:39:22 Repository: asterisk Revision: 260053 _U branches/1.6.0/ U branches/1.6.0/include/asterisk/audiohook.h U branches/1.6.0/main/audiohook.c ------------------------------------------------------------------------ r260053 | dvossel | 2010-04-29 10:39:22 -0500 (Thu, 29 Apr 2010) | 28 lines Merged revisions 260050 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r260050 | dvossel | 2010-04-29 10:33:27 -0500 (Thu, 29 Apr 2010) | 21 lines Merged revisions 260049 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r260049 | dvossel | 2010-04-29 10:31:02 -0500 (Thu, 29 Apr 2010) | 14 lines Fixes crash in audiohook_write_list The middle_frame in the audiohook_write_list function was being freed if a audiohook manipulator returned a failure. This is incorrect logic. This patch resolves this and adds detailed descriptions of how this function should work and why manipulator failures must be ignored. (closes issue ASTERISK-15834) Reported by: dvossel Tested by: dvossel Review: https://reviewboard.asterisk.org/r/623/ ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=260053 By: Digium Subversion (svnbot) 2010-04-29 10:52:43 Repository: asterisk Revision: 260049 U branches/1.4/include/asterisk/audiohook.h U branches/1.4/main/audiohook.c ------------------------------------------------------------------------ r260049 | dvossel | 2010-04-29 10:31:02 -0500 (Thu, 29 Apr 2010) | 17 lines Fixes crash in audiohook_write_list The middle_frame in the audiohook_write_list function was being freed if a audiohook manipulator returned a failure. This is incorrect logic. This patch resolves this and adds detailed descriptions of how this function should work and why manipulator failures must be ignored. (closes issue ASTERISK-15834) Reported by: dvossel Tested by: dvossel (closes issue ASTERISK-15091) Reported by: atis Review: https://reviewboard.asterisk.org/r/623/ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=260049 By: Digium Subversion (svnbot) 2010-04-29 10:53:21 Repository: asterisk Revision: 260050 _U trunk/ U trunk/include/asterisk/audiohook.h U trunk/main/audiohook.c ------------------------------------------------------------------------ r260050 | dvossel | 2010-04-29 10:33:27 -0500 (Thu, 29 Apr 2010) | 24 lines Merged revisions 260049 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r260049 | dvossel | 2010-04-29 10:31:02 -0500 (Thu, 29 Apr 2010) | 14 lines Fixes crash in audiohook_write_list The middle_frame in the audiohook_write_list function was being freed if a audiohook manipulator returned a failure. This is incorrect logic. This patch resolves this and adds detailed descriptions of how this function should work and why manipulator failures must be ignored. (closes issue ASTERISK-15834) Reported by: dvossel Tested by: dvossel (closes issue ASTERISK-15091) Reported by: atis Review: https://reviewboard.asterisk.org/r/623/ ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=260050 By: Digium Subversion (svnbot) 2010-04-29 10:53:58 Repository: asterisk Revision: 260051 _U branches/1.6.2/ U branches/1.6.2/include/asterisk/audiohook.h U branches/1.6.2/main/audiohook.c ------------------------------------------------------------------------ r260051 | dvossel | 2010-04-29 10:35:38 -0500 (Thu, 29 Apr 2010) | 31 lines Merged revisions 260050 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r260050 | dvossel | 2010-04-29 10:33:27 -0500 (Thu, 29 Apr 2010) | 21 lines Merged revisions 260049 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r260049 | dvossel | 2010-04-29 10:31:02 -0500 (Thu, 29 Apr 2010) | 14 lines Fixes crash in audiohook_write_list The middle_frame in the audiohook_write_list function was being freed if a audiohook manipulator returned a failure. This is incorrect logic. This patch resolves this and adds detailed descriptions of how this function should work and why manipulator failures must be ignored. (closes issue ASTERISK-15834) Reported by: dvossel Tested by: dvossel (closes issue ASTERISK-15091) Reported by: atis Review: https://reviewboard.asterisk.org/r/623/ ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=260051 By: Digium Subversion (svnbot) 2010-04-29 10:54:27 Repository: asterisk Revision: 260052 _U branches/1.6.1/ U branches/1.6.1/include/asterisk/audiohook.h U branches/1.6.1/main/audiohook.c ------------------------------------------------------------------------ r260052 | dvossel | 2010-04-29 10:37:15 -0500 (Thu, 29 Apr 2010) | 31 lines Merged revisions 260050 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r260050 | dvossel | 2010-04-29 10:33:27 -0500 (Thu, 29 Apr 2010) | 21 lines Merged revisions 260049 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r260049 | dvossel | 2010-04-29 10:31:02 -0500 (Thu, 29 Apr 2010) | 14 lines Fixes crash in audiohook_write_list The middle_frame in the audiohook_write_list function was being freed if a audiohook manipulator returned a failure. This is incorrect logic. This patch resolves this and adds detailed descriptions of how this function should work and why manipulator failures must be ignored. (closes issue ASTERISK-15834) Reported by: dvossel Tested by: dvossel (closes issue ASTERISK-15091) Reported by: atis Review: https://reviewboard.asterisk.org/r/623/ ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=260052 By: Digium Subversion (svnbot) 2010-04-29 10:54:59 Repository: asterisk Revision: 260053 _U branches/1.6.0/ U branches/1.6.0/include/asterisk/audiohook.h U branches/1.6.0/main/audiohook.c ------------------------------------------------------------------------ r260053 | dvossel | 2010-04-29 10:39:21 -0500 (Thu, 29 Apr 2010) | 31 lines Merged revisions 260050 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r260050 | dvossel | 2010-04-29 10:33:27 -0500 (Thu, 29 Apr 2010) | 21 lines Merged revisions 260049 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r260049 | dvossel | 2010-04-29 10:31:02 -0500 (Thu, 29 Apr 2010) | 14 lines Fixes crash in audiohook_write_list The middle_frame in the audiohook_write_list function was being freed if a audiohook manipulator returned a failure. This is incorrect logic. This patch resolves this and adds detailed descriptions of how this function should work and why manipulator failures must be ignored. (closes issue ASTERISK-15834) Reported by: dvossel Tested by: dvossel (closes issue ASTERISK-15091) Reported by: atis Review: https://reviewboard.asterisk.org/r/623/ ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=260053 | ||