[Home]

Summary:ASTERISK-15831: [patch] CLI commands via asterisk -rx may not return all output
Reporter:Russell Bryant (russell)Labels:
Date Opened:2010-03-17 10:52:32Date Closed:2010-06-29 11:43:33
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:If a CLI command takes a while to complete, an asterisk -rx process will exit early.  I noticed this when bamboo runs the unit tests.  It is very easy to reproduce.

1) Compile Asterisk with TEST_FRAMEWORK enabled, and all of the test modules.

2) Run the unit tests with asterisk -rx.

The process will exit long before the tests are finished running.

****** ADDITIONAL INFORMATION ******

russell@russell-laptop:~/src/asterisk/trunk$ sudo asterisk -rx "test execute all"
Running all available tests...

START  apps/app_gosub/ - gosub application
END    apps/app_gosub/ - gosub application Time: <1ms Result: PASS
START  apps/app_voicemail/ - test_voicemail_msgcount
[app_voicemail.c:test_voicemail_msgcount:11891]: Unable to clear test directory: unable to fork()
END    apps/app_voicemail/ - test_voicemail_msgcount Time: 64ms Result: PASS
START  apps/app_voicemail/ - vmsayname_exec
[app_voicemail.c:test_voicemail_vmsayname:11691]: Test playing of extension when greeting is not available...
russell@russell-laptop:~/src/asterisk/trunk$
Comments:By: Russell Bryant (russell) 2010-03-17 16:51:37

I guess it makes sense for there to be some sort of reasonable timeout if no data is received from the main asterisk process after some period of time.  However, in this particular case, I would like at least an option to force it to wait until the main process closes the connection after completing the CLI command execution.

By: Digium Subversion (svnbot) 2010-03-18 13:18:44

Repository: asterisk
Revision: 253357

U   trunk/main/asterisk.c

------------------------------------------------------------------------
r253357 | russell | 2010-03-18 13:18:43 -0500 (Thu, 18 Mar 2010) | 8 lines

Increase CLI command output timeout for asterisk -rx to 60 seconds.

(closes issue ASTERISK-15831)
Reported by: russell
Tested by: russell

Review: https://reviewboard.asterisk.org/r/573/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=253357

By: Digium Subversion (svnbot) 2010-06-29 11:43:32

Repository: asterisk
Revision: 272972

_U  branches/1.6.2/
U   branches/1.6.2/main/asterisk.c

------------------------------------------------------------------------
r272972 | russell | 2010-06-29 11:43:32 -0500 (Tue, 29 Jun 2010) | 15 lines

Merged revisions 253357 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r253357 | russell | 2010-03-18 13:18:43 -0500 (Thu, 18 Mar 2010) | 8 lines
 
 Increase CLI command output timeout for asterisk -rx to 60 seconds.
 
 (closes issue ASTERISK-15831)
 Reported by: russell
 Tested by: russell
 
 Review: https://reviewboard.asterisk.org/r/573/
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=272972