Summary:ASTERISK-15821: [patch] allow using system copy of libedit
Reporter:Tzafrir Cohen (tzafrir)Labels:
Date Opened:2010-03-16 12:13:19Date Closed:2011-07-26 14:37:08
Versions:Frequency of
Environment:Attachments:( 0) 0001-allow-using-system-copy-of-libedit.patch
Description:Asterisk includes its own modified copy of editline.

This patch allows using the system copy of this library if both:

* The user asked for it explicitly: --enabled-system-editline
* It was actually discovered to exist

As the usage of it is not tested, it is mostly intended to simplify testing.
Comments:By: Leif Madsen (lmadsen) 2010-03-16 13:10:27

There is also a branch by seanbright which starts to resolve part of the issues associated with the related issue:


By: Tzafrir Cohen (tzafrir) 2010-03-16 13:21:43

This is already done in that branch. I missed it on earlier inspection.

By: Leif Madsen (lmadsen) 2010-03-16 13:27:14

Reopening this issue as the stub/placeholder for the branch that seanbright is working on. This is easier than opening a new issue :)

By: Leif Madsen (lmadsen) 2010-03-23 12:54:52

Sean, just let me know when you're ready to have this marked as Ready for Testing.

By: Leif Madsen (lmadsen) 2010-06-23 12:05:59

Is there much interest in moving this forward?

By: Sean Bright (seanbright) 2010-07-20 07:32:00

Yes.  I'll try to get it in this week.

By: Leif Madsen (lmadsen) 2010-07-20 11:11:13

Yay! :)

By: Leif Madsen (lmadsen) 2010-07-27 13:27:33


By: Digium Subversion (svnbot) 2010-07-27 16:57:09

Repository: asterisk
Revision: 280019

U   branches/1.8/build_tools/menuselect-deps.in
U   branches/1.8/configure
U   branches/1.8/configure.ac
U   branches/1.8/include/asterisk/autoconfig.h.in
U   branches/1.8/include/asterisk/term.h
_U  branches/1.8/main/
U   branches/1.8/main/Makefile
U   branches/1.8/main/asterisk.c
U   branches/1.8/main/cli.c
D   branches/1.8/main/editline/
U   branches/1.8/main/term.c
U   branches/1.8/main/xmldoc.c
U   branches/1.8/makeopts.in

r280019 | seanbright | 2010-07-27 16:57:05 -0500 (Tue, 27 Jul 2010) | 23 lines

Add ability to use system libedit and update bundled libedit.

The version of libedit that is bundled with asterisk is old and has some bugs.
This patch updates the bundled version of libedit within asterisk, and also
updates asterisk to use the system libedit instead if one is available (and
pkg-config is available).  This review integrates several patches from other
users specifically kkm and tzafrir.

(closes issue ASTERISK-14859)
Reported by: kkm
     015929-astcli-editrc-trunk.240324.diff uploaded by kkm (license 888)

(issue ASTERISK-15652)
Reported by: jw-asterisk

(closes issue ASTERISK-15821)
Reported by: tzafrir
     0001-allow-using-system-copy-of-libedit.patch uploaded by tzafrir (license 46)

Review: https://reviewboard.asterisk.org/r/807/