[Home]

Summary:ASTERISK-15816: [patch] Problems with MeetMe and RT schedule dates
Reporter:S├ębastien Couture (sysreq)Labels:
Date Opened:2010-03-15 13:19:15Date Closed:2011-05-06 16:49:48
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_meetme
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) asterisk-issue-17034.patch
Description:1. Current time is not displayed in the debug message given when Asterisk tries to find the MeetMe room in RealTime;

Example:

app_meetme.c:2961 find_conf_realtime: Looking for conference 1234 that starts after

Fixed by replacing 'eatime' by 'currenttime' in the following line (2961) in app_meetme.c:

ast_debug(1, "Looking for conference %s that starts after %s\n", confno, eatime);


2. Variables 'currenttime' and 'eatime' are apparently not big enough to hold the full date, whose format is given by DATE_FORMAT ("%Y-%m-%d %H:%M:%S");

Example:

res_config_odbc.c:73 custom_prepare: Skip: 0; SQL: SELECT * FROM meetme WHERE confno = ? AND starttime <=  ? AND endtime >=  ?
res_config_odbc.c:88 custom_prepare: Parameter 1 ('confno') = '1234'
res_config_odbc.c:88 custom_prepare: Parameter 2 ('starttime <= ') = '2010-03-15 11:36:'
res_config_odbc.c:88 custom_prepare: Parameter 3 ('endtime >= ') = '2010-03-15 11:36:'

Fixed by setting the variables' size to 21 instead of 19 in the following lines (2948/2949) in app_meetme.c:

char currenttime[19] = "";
char eatime[19] = "";
Comments:By: Leif Madsen (lmadsen) 2010-03-15 15:00:40

Confirming this issue. Thanks for the patch!

By: Digium Subversion (svnbot) 2011-05-06 16:49:02

Repository: asterisk
Revision: 317969

U   branches/1.8/apps/app_meetme.c

------------------------------------------------------------------------
r317969 | russell | 2011-05-06 16:49:01 -0500 (Fri, 06 May 2011) | 10 lines

Use the right variable to print the time in a debug message.

The original patch also increased some buffer sizes, but that was already
done in this version.

(closes issue ASTERISK-15816)
Reported by: sysreq
Patches:
     asterisk-issue-17034.patch uploaded by sysreq (license 1009)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=317969

By: Digium Subversion (svnbot) 2011-05-06 16:49:48

Repository: asterisk
Revision: 317970

_U  trunk/
U   trunk/apps/app_meetme.c

------------------------------------------------------------------------
r317970 | russell | 2011-05-06 16:49:48 -0500 (Fri, 06 May 2011) | 17 lines

Merged revisions 317969 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
 r317969 | russell | 2011-05-06 16:49:01 -0500 (Fri, 06 May 2011) | 10 lines
 
 Use the right variable to print the time in a debug message.
 
 The original patch also increased some buffer sizes, but that was already
 done in this version.
 
 (closes issue ASTERISK-15816)
 Reported by: sysreq
 Patches:
       asterisk-issue-17034.patch uploaded by sysreq (license 1009)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=317970