[Home]

Summary:ASTERISK-15813: [patch] Makefile: remove ASTBINDIR variable
Reporter:Paul Belanger (pabelanger)Labels:
Date Opened:2010-03-15 11:04:22Date Closed:2010-06-10 15:35:06
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/BuildSystem
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) Makefile.ASTBINDIR.patch
( 1) Makefile.ASTBINDIR.v2.patch
Description:ASTBINDIR is no longer used within the Makefile; this patch removes it.

****** ADDITIONAL INFORMATION ******

<pabelanger> Is ASTBINDIR actually used in the Makefile?  I've been looking to see why we actually have it defined, since nothing is installed into the directory.
<Qwell> Once Upon A Time, I suspect
<Corydon76-lap> In a Galaxy Far, Far Away?
<pabelanger> so, no issue if I create a patch to nuke it?
<Corydon76-lap> I don't see any particular issue with the concept, though implementation may be an issue
Comments:By: Jason Parker (jparker) 2010-03-15 11:51:53

Should probably remove it from makeopts.in and elsewhere as well (though I'm not aware of any other places).

By: Paul Belanger (pabelanger) 2010-03-15 14:43:09

Version 2: As per qwell's request.

The only other location I can see is within the configure script, but I am not sure the process we use to generate it.  Going to ask on #asterisk-dev

By: Digium Subversion (svnbot) 2010-06-10 15:30:44

Repository: asterisk
Revision: 269889

U   trunk/Makefile
U   trunk/makeopts.in

------------------------------------------------------------------------
r269889 | pabelanger | 2010-06-10 15:30:44 -0500 (Thu, 10 Jun 2010) | 8 lines

Remove ASTBINDIR variable

(closes issue ASTERISK-15813)
Reported by: pabelanger
Patches:
     Makefile.ASTBINDIR.v2.patch uploaded by pabelanger (license 224)
Tested by: pabelanger, tilghman

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=269889

By: Digium Subversion (svnbot) 2010-06-10 15:35:05

Repository: asterisk
Revision: 269894

_U  branches/1.6.2/
U   branches/1.6.2/Makefile
U   branches/1.6.2/makeopts.in

------------------------------------------------------------------------
r269894 | pabelanger | 2010-06-10 15:35:05 -0500 (Thu, 10 Jun 2010) | 15 lines

Merged revisions 269889 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r269889 | pabelanger | 2010-06-10 16:30:44 -0400 (Thu, 10 Jun 2010) | 8 lines
 
 Remove ASTBINDIR variable
 
 (closes issue ASTERISK-15813)
 Reported by: pabelanger
 Patches:
       Makefile.ASTBINDIR.v2.patch uploaded by pabelanger (license 224)
 Tested by: pabelanger, tilghman
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=269894