| Summary: | ASTERISK-15810: [patch] make clean: /bin/sh: /usr/bin/sw_vers: not found | ||
| Reporter: | Paul Belanger (pabelanger) | Labels: | |
| Date Opened: | 2010-03-14 20:46:38 | Date Closed: | 2010-05-15 18:41:20 |
| Priority: | Trivial | Regression? | No |
| Status: | Closed/Complete | Components: | Core/BuildSystem |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) 20100315__issue17028.diff.txt ( 1) issue17028_20100315.patch | |
| Description: | Trivial issue Makefile calls /usr/bin/sw_vers, but does not exist on Ubuntu. ****** ADDITIONAL INFORMATION ****** ./configure make make clean | ||
| Comments: | By: Tilghman Lesher (tilghman) 2010-03-14 22:45:00 I'm guessing that the string "darwin" somehow showed up as your target OS, because that's the only way that that shell should be evaluated. If that's the case, it's something that is certainly an issue that you cannot cross compile a Darwin binary on Ubuntu, but that's not an issue that we're going to be able to devote any resources towards. You are welcome to fix it and contribute that fix back, however. By: Tilghman Lesher (tilghman) 2010-03-14 23:18:34 I'll additionally note that I cannot reproduce this on Ubuntu Hardy Heron. By: Paul Belanger (pabelanger) 2010-03-15 09:57:20 @tilghman: I am not doing any cross compiling, just building on Ubuntu 9.10. It looks like revision 251475 created the issue. The problem is in the codecs/gsm/Makefile By: Sean Bright (seanbright) 2010-03-15 10:35:00 Please test the attached patch. By: Paul Belanger (pabelanger) 2010-03-15 10:42:10 +1: The patch removed the issue. By: Tilghman Lesher (tilghman) 2010-03-15 10:50:05 I went with a slightly different patch, as I discovered that the Makefile logic there was completely broken. So here's a fix. By: Digium Subversion (svnbot) 2010-03-15 11:27:09 Repository: asterisk Revision: 252488 U trunk/codecs/gsm/Makefile ------------------------------------------------------------------------ r252488 | tilghman | 2010-03-15 11:27:09 -0500 (Mon, 15 Mar 2010) | 9 lines Make the Makefile logic more explicit and move the Snow Leopard logic down to where it's not executed on non-Darwin systems. (closes issue ASTERISK-15810) Reported by: pabelanger Patches: issue17028_20100315.patch uploaded by seanbright (license 71) 20100315__issue17028.diff.txt uploaded by tilghman (license 14) Tested by: tilghman, pabelanger ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=252488 By: Digium Subversion (svnbot) 2010-05-15 18:41:19 Repository: asterisk Revision: 263202 _U branches/1.6.2/ U branches/1.6.2/codecs/gsm/Makefile ------------------------------------------------------------------------ r263202 | pabelanger | 2010-05-15 18:41:19 -0500 (Sat, 15 May 2010) | 16 lines Merged revisions 252488 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r252488 | tilghman | 2010-03-15 12:27:08 -0400 (Mon, 15 Mar 2010) | 9 lines Make the Makefile logic more explicit and move the Snow Leopard logic down to where it's not executed on non-Darwin systems. (closes issue ASTERISK-15810) Reported by: pabelanger Patches: issue17028_20100315.patch uploaded by seanbright (license 71) 20100315__issue17028.diff.txt uploaded by tilghman (license 14) Tested by: tilghman, pabelanger ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=263202 | ||