[Home]

Summary:ASTERISK-15799: [patch] [regression] videosupport=always acts like videosupport=no
Reporter:Terry Wilson (twilson)Labels:
Date Opened:2010-03-12 15:31:39.000-0600Date Closed:2010-05-26 10:52:56
Priority:MinorRegression?Yes
Status:Closed/CompleteComponents:Channels/chan_sip/Video
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 17016_162.patch
( 1) 17016.patch
Description:Ever since r186078 (moving over to rtp engine), the videosupport=always option acts like videosupport=no. The SIP_PAGE2_VIDEOSUPPORT_ALWAYS flag gets set, but never checked anywhere after that commit, and SIP_PAGE2_VIDEOSUPPORT is never set in that case either.

****** STEPS TO REPRODUCE ******

sip.conf
-------
[general]
...
videosupport=always
...

[videophone]
...
disallow=all
allow=ulaw,h263
...

Make a call with Eyebeam and notice that the 200 OK from Asterisk comes back without any video codecs listed.
Comments:By: Claudio Villalobos (devmod) 2010-05-25 13:39:00

I have observed the same problem on 1.6.2.6 and 1.6.2.7.
By: Mark Michelson (mmichelson) 2010-05-25 16:36:54

I've uploaded a fairly simple patch for trunk which I believe will fix the issue. Please let me know if the fix works. I think 1.6.2 might need a slightly different patch. If so, I'll upload a patch for it as well.
By: Mark Michelson (mmichelson) 2010-05-25 16:40:16

As I suspected, 1.6.2 needed a different patch, which I have uploaded as 17016_162.patch.
By: Claudio Villalobos (devmod) 2010-05-25 19:26:52

Patch works for 1.6.2 and trunk. Thanks.
By: Digium Subversion (svnbot) 2010-05-26 09:41:56

Repository: asterisk
Revision: 265842

U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r265842 | mmichelson | 2010-05-26 09:41:55 -0500 (Wed, 26 May 2010) | 9 lines

Re-enable "always" option for videosupport option in sip.conf.

(closes issue ASTERISK-15799)
Reported by: twilson
Patches:
     17016.patch uploaded by mmichelson (license 60)
 Tested by: devmod


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=265842
By: Digium Subversion (svnbot) 2010-05-26 10:52:56

Repository: asterisk
Revision: 265890

_U  branches/1.6.2/
U   branches/1.6.2/channels/chan_sip.c

------------------------------------------------------------------------
r265890 | mmichelson | 2010-05-26 10:52:55 -0500 (Wed, 26 May 2010) | 15 lines

Recorded merge of revisions 265842 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r265842 | mmichelson | 2010-05-26 09:41:55 -0500 (Wed, 26 May 2010) | 9 lines
 
 Re-enable "always" option for videosupport option in sip.conf.
 
 (closes issue ASTERISK-15799)
 Reported by: twilson
 Patches:
       17016.patch uploaded by mmichelson (license 60)
   Tested by: devmod
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=265890