[Home]

Summary:ASTERISK-15791: [patch] Autopause only pauses member on queue where timeout took place.
Reporter:jlpedrosa (jlpedrosa)Labels:
Date Opened:2010-03-11 10:49:15.000-0600Date Closed:2010-05-04 17:46:44
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_queue
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) queues.autopause.diff
Description:Hi all

When a call to a queue memeber reach timeout and autopause is set, that member paused but ONLY for the queue where timeout took place:


this is the line:
in app_queue.c

if (!set_member_paused(qe->parent->name, interface, "Auto-Pause", 1)) {


I don't think it's how it should be, at least should be configurable at config file?

I can patch it by my own if you think it proceeds.


Thanks

Comments:By: Leif Madsen (lmadsen) 2010-03-15 09:55:45

Any patches or information you can provide are certainly welcome.
By: Leif Madsen (lmadsen) 2010-03-18 14:52:20

Setting to feedback while we await a patch from the reporter.
By: John Todd (jtodd) 2010-03-18 14:52:31

We would very much like to see a patch for this - it sounds like quite a reasonable feature.
By: jlpedrosa (jlpedrosa) 2010-03-22 06:19:12

Hi all,

I've attached the diff generated from trunk (with svn diff),  from revision  (revision 253708)


finally, i've made it file configurable, 'yes' 'no', respects the old behavior, added value "all" which makes memeber paused in all interfaces.

let me know what you think

Cheers,
By: Leif Madsen (lmadsen) 2010-03-24 09:54:07

Thanks for the patch! Hopefully we can get this reviewed shortly. I'd suggest posting this to the reviewboard.
By: jlpedrosa (jlpedrosa) 2010-03-24 10:45:38

Hi

this is the post on review board
https://reviewboard.asterisk.org/r/581/


By: Leif Madsen (lmadsen) 2010-03-24 13:40:34

Thanks for getting that onto reviewboard!
By: Digium Subversion (svnbot) 2010-05-04 17:46:42

Repository: asterisk
Revision: 261051

U   trunk/CHANGES
U   trunk/apps/app_queue.c
U   trunk/configs/queues.conf.sample

------------------------------------------------------------------------
r261051 | mmichelson | 2010-05-04 17:46:42 -0500 (Tue, 04 May 2010) | 12 lines

Add new possible value to autopause option to allow members to be autopaused in all queues.

See the CHANGES file and queues.conf.sample for more details.

(closes issue ASTERISK-15791)
Reported by: jlpedrosa
Patches:
     queues.autopause_en_review.diff uploaded by jlpedrosa (license 1002)

Review: https://reviewboard.asterisk.org/r/581/


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=261051