[Home]

Summary:ASTERISK-15768: [patch] small error in T.140 RTP port verbose
Reporter:frawd (frawd)Labels:
Date Opened:2010-03-08 10:44:39.000-0600Date Closed:2010-04-26 11:00:37
Priority:CriticalRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) chan_sip_sdp_verbose_fix.diff
Description:I saw this while browsing in chan_sip.c, was verbosing the video port instead of the T.140 port.

****** ADDITIONAL INFORMATION ******

see attached patch.
Comments:By: Leif Madsen (lmadsen) 2010-03-08 11:49:01.000-0600

Thanks for the submission!
By: frawd (frawd) 2010-03-08 11:52:12.000-0600

You're welcome. Thinking of it, it might also have caused a segfault.
By: Leif Madsen (lmadsen) 2010-03-08 11:54:48.000-0600

Upgraded to crash in case this really could cause a segfault.
By: frawd (frawd) 2010-04-05 06:12:38

Should I post this in the review board?

I haven't tested yet, but this patch is trivial enough to not need testing I think.
By: Leif Madsen (lmadsen) 2010-04-15 10:32:36

No need to put this on reviewboard. It'll get looked at as soon as a developer has time. Thanks!
By: Russell Bryant (russell) 2010-04-26 10:57:39

ship it
By: Digium Subversion (svnbot) 2010-04-26 10:59:35

Repository: asterisk
Revision: 258934

U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r258934 | lmadsen | 2010-04-26 10:59:35 -0500 (Mon, 26 Apr 2010) | 7 lines

Small error in the T.140 RTP port verbose log.

(closes issue ASTERISK-15768)
Reported by: frawd
Patches:
     chan_sip_sdp_verbose_fix.diff uploaded by frawd (license 610)
Tested by: russell
------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=258934
By: Digium Subversion (svnbot) 2010-04-26 11:00:36

Repository: asterisk
Revision: 258935

_U  branches/1.6.2/
U   branches/1.6.2/channels/chan_sip.c

------------------------------------------------------------------------
r258935 | lmadsen | 2010-04-26 11:00:35 -0500 (Mon, 26 Apr 2010) | 15 lines

Merged revisions 258934 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r258934 | lmadsen | 2010-04-26 10:59:34 -0500 (Mon, 26 Apr 2010) | 7 lines
 
 Small error in the T.140 RTP port verbose log.
 
 (closes issue ASTERISK-15768)
 Reported by: frawd
 Patches:
       chan_sip_sdp_verbose_fix.diff uploaded by frawd (license 610)
 Tested by: russell
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=258935