[Home]

Summary:ASTERISK-15758: [patch] OOH323 connection to Avaya IPOffice 403 drops i n 394 seconds
Reporter:Vladimir Mikhelson (vmikhelson)Labels:
Date Opened:2010-03-06 01:17:43.000-0600Date Closed:2010-03-14 09:43:01
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Addons/chan_ooh323
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) full.txt
( 1) h323_log_2010-02-23.txt
( 2) rtdr-1.6.0.patch
( 3) rtdr-1.6.0-2.patch
Description:In case Asterisk establishes an outgoing or incoming OOH323 connection with Avaya IPOffice 403 the connection hangs up in about 394 seconds. Avaya IPOffice 403 is unaware of the connection drop and does not send a busy signal or otherwise indicate the conversation termination to a user.


****** ADDITIONAL INFORMATION ******


[Jan 22 19:17:27] VERBOSE[19618] logger.c: -- Called 352@172.17.135.2:1720
[Jan 22 19:17:27] VERBOSE[19618] logger.c: -- OOH323/172.17.135.2:1720-10ec is ringing
[Jan 22 19:17:30] VERBOSE[19618] logger.c: -- OOH323/172.17.135.2:1720-10ec answered SIP/435-00000001
[Jan 22 19:17:30] WARNING[19618] chan_ooh323.c: Don't know how to indicate condition 20 on ooh323c_o_3
[Jan 22 19:24:04] VERBOSE[19618] logger.c: -- Executing [h@macro-dialout-trunk:1] Macro("SIP/435-00000001", "hangupcall,") in new stack
[Jan 22 19:24:04] VERBOSE[19618] logger.c: -- Executing [s@macro-hangupcall:1] GotoIf("SIP/435-00000001", "1?skiprg") in new stack
[Jan 22 19:24:04] VERBOSE[19618] logger.c: -- Goto (macro-hangupcall,s,4)



[Jan 22 19:24:22] VERBOSE[19639] logger.c: -- Called 352@172.17.135.2:1720
[Jan 22 19:24:23] VERBOSE[19639] logger.c: -- OOH323/172.17.135.2:1720-ee44 is ringing
[Jan 22 19:24:27] VERBOSE[19639] logger.c: -- OOH323/172.17.135.2:1720-ee44 answered SIP/435-00000002
[Jan 22 19:24:27] WARNING[19639] chan_ooh323.c: Don't know how to indicate condition 20 on ooh323c_o_4
[Jan 22 19:31:01] VERBOSE[19639] logger.c: -- Executing [h@macro-dialout-trunk:1] Macro("SIP/435-00000002", "hangupcall,") in new stack
[Jan 22 19:31:01] VERBOSE[19639] logger.c: -- Executing [s@macro-hangupcall:1] GotoIf("SIP/435-00000002", "1?skiprg") in new stack
[Jan 22 19:31:01] VERBOSE[19639] logger.c: -- Goto (macro-hangupcall,s,4)
Comments:By: Vladimir Mikhelson (vmikhelson) 2010-03-06 01:21:38.000-0600

Here come the logs collected when ooh323 outbound calls were dropped:
1. Started Feb 23 10:48:36, dropped Feb 23 10:55:08 -- 392 seconds
2. Started Feb 23 10:55:25, dropped Feb 23 11:01:58 -- 392 seconds
3. Started Feb 23 11:02:12, ended normally Feb 23 11:04:34

Attached:
full.txt
h323_log_2010-02-23.txt
By: Alexander Anikin (may213) 2010-03-06 18:04:08.000-0600

OOH323 doesn't reply to roundtripdelay request which send some h.323 endpoints.
Avaya reset connection some time not receive roundtripdelay reply.
By: Alexander Anikin (may213) 2010-03-06 18:08:24.000-0600

Vladimir,

pls try attached patch, it add roundtripdelay request generate on request received.
By: Vladimir Mikhelson (vmikhelson) 2010-03-07 01:10:02.000-0600

May213,

It was very exciting to see the patch so quickly.

Unfortunately ran into a problem with "make"

I tried to install in the same copy of addons which I patched to fix DTMF problems.


patching file channels/ooh323c/src/ootypes.h
patching file channels/ooh323c/src/ooh245.c
patching file channels/ooh323c/src/ooh245.h
patching file channels/ooh323c/src/ooSocket.c
patching file channels/ooh323c/src/ooq931.c
[root@pbx asterisk-addons-1.6.0.4-curr]# make
make[1]: Entering directory `/usr/src/asterisk-addons-1.6.0.4-curr/channels'
  [CC] chan_ooh323.c -> chan_ooh323.o
  [CC] ooh323c/src/ooCmdChannel.c -> ooh323c/src/ooCmdChannel.o
  [CC] ooh323c/src/ooLogChan.c -> ooh323c/src/ooLogChan.o
  [CC] ooh323c/src/ooUtils.c -> ooh323c/src/ooUtils.o
  [CC] ooh323c/src/ooGkClient.c -> ooh323c/src/ooGkClient.o
  [CC] ooh323c/src/ootrace.c -> ooh323c/src/ootrace.o
  [CC] ooh323c/src/oochannels.c -> ooh323c/src/oochannels.o
  [CC] ooh323c/src/ooh245.c -> ooh323c/src/ooh245.o
ooh323c/src/ooh245.c: In function 'ooOnReceivedRoundTripDelayRequest':
ooh323c/src/ooh245.c:1982: warning: passing argument 1 of 'ooCreateH245Message' from incompatible pointer type
ooh323c/src/ooh245.c:1982: warning: passing argument 2 of 'ooCreateH245Message' makes integer from pointer without a cast
ooh323c/src/ooh245.c:1982: error: too many arguments to function 'ooCreateH245Message'
ooh323c/src/ooh245.c:1990: error: 'OOH323CallData' has no member named 'msgctxt'
make[1]: *** [ooh323c/src/ooh245.o] Error 1
make[1]: Leaving directory `/usr/src/asterisk-addons-1.6.0.4-curr/channels'
make: *** [channels] Error 2

Thank you,
Vladimir
By: Alexander Anikin (may213) 2010-03-07 04:38:43.000-0600

Vladimir,

sorry, i forgot that some interfaces changed between older and reworked version.
i attached new patch which compiled success with addons-1.6.0, pls try it.
By: Vladimir Mikhelson (vmikhelson) 2010-03-07 18:57:37.000-0600

May213,

Applied the new patch, tested on both incoming and outgoing connections.

It did not drop a single call so far. I will continue testing and will update the case in couple days.

Thank you,
Vladimir
By: Vladimir Mikhelson (vmikhelson) 2010-03-07 21:46:53.000-0600

May213,

While reviewing the logs discovered the new warning on the incoming call I did not see before:

WARNING[1834] chan_ooh323.c: Don't know how to indicate condition 18 on ooh323c_1

The other one with condition 20 is generated on every outgoing call and almost on every incoming.

Thank you,
Vladimir
By: Alexander Anikin (may213) 2010-03-08 16:23:51.000-0600

Vladimir,
you can ignore this warning, i think this control frame generated by chan_sip based on signalling from originating side of call.

grep 18 include/asterisk/frame.h | grep AST_CONTROL
       AST_CONTROL_VIDUPDATE = 18,     /*!< Indicate video frame update */
By: Vladimir Mikhelson (vmikhelson) 2010-03-13 01:47:48.000-0600

May213,

Everything works perfect. No complaints.

Thank you for your work.

-Vladimir
By: Alexander Anikin (may213) 2010-03-14 08:51:26

Vladimir,

Thank you for testing. I'll close this issue.
By: Digium Subversion (svnbot) 2010-03-14 09:06:28

Repository: asterisk-addons
Revision: 1095

U   branches/1.6.0/channels/ooh323c/src/ooSocket.c
U   branches/1.6.0/channels/ooh323c/src/ooh245.c
U   branches/1.6.0/channels/ooh323c/src/ooh245.h
U   branches/1.6.0/channels/ooh323c/src/ooq931.c
U   branches/1.6.0/channels/ooh323c/src/ootypes.h

------------------------------------------------------------------------
r1095 | may | 2010-03-14 09:06:27 -0500 (Sun, 14 Mar 2010) | 13 lines

added generating response on round trip delay requests

Some h.323 endpoints send round trip delay requests and require
replies from another side. One of them is Avaya IPOffice in default
config.

(issue ASTERISK-15758)
Reported by: vmikhelson
Patches:
     rtdr-1.6.0-2.patch uploaded by may213 (license 454)
Tested by: vmikhelson, may213


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk-addons?view=rev&revision=1095
By: Digium Subversion (svnbot) 2010-03-14 09:07:25

Repository: asterisk-addons
Revision: 1096

U   branches/1.6.2/channels/ooh323c/src/ooSocket.c
U   branches/1.6.2/channels/ooh323c/src/ooh245.c
U   branches/1.6.2/channels/ooh323c/src/ooh245.h
U   branches/1.6.2/channels/ooh323c/src/ooq931.c
U   branches/1.6.2/channels/ooh323c/src/ootypes.h

------------------------------------------------------------------------
r1096 | may | 2010-03-14 09:07:24 -0500 (Sun, 14 Mar 2010) | 13 lines

added generating response on round trip delay requests

Some h.323 endpoints send round trip delay requests and require
replies from another side. One of them is Avaya IPOffice in default
config.

(issue ASTERISK-15758)
Reported by: vmikhelson
Patches:
     rtdr-1.6.0-2.patch uploaded by may213 (license 454)
Tested by: vmikhelson, may213


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk-addons?view=rev&revision=1096
By: Digium Subversion (svnbot) 2010-03-14 09:07:48

Repository: asterisk-addons
Revision: 1097

U   branches/1.6.1/channels/ooh323c/src/ooSocket.c
U   branches/1.6.1/channels/ooh323c/src/ooh245.c
U   branches/1.6.1/channels/ooh323c/src/ooh245.h
U   branches/1.6.1/channels/ooh323c/src/ooq931.c
U   branches/1.6.1/channels/ooh323c/src/ootypes.h

------------------------------------------------------------------------
r1097 | may | 2010-03-14 09:07:47 -0500 (Sun, 14 Mar 2010) | 13 lines

added generating response on round trip delay requests

Some h.323 endpoints send round trip delay requests and require
replies from another side. One of them is Avaya IPOffice in default
config.

(issue ASTERISK-15758)
Reported by: vmikhelson
Patches:
     rtdr-1.6.0-2.patch uploaded by may213 (license 454)
Tested by: vmikhelson, may213


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk-addons?view=rev&revision=1097
By: Digium Subversion (svnbot) 2010-03-14 09:43:00

Repository: asterisk
Revision: 252277

U   trunk/addons/chan_ooh323.c
U   trunk/addons/ooh323c/src/ooCalls.h
U   trunk/addons/ooh323c/src/ooSocket.c
U   trunk/addons/ooh323c/src/ooh245.c
U   trunk/addons/ooh323c/src/ooh245.h
U   trunk/addons/ooh323c/src/ooh323.c
U   trunk/addons/ooh323c/src/ooq931.c
U   trunk/addons/ooh323c/src/ootypes.h
U   trunk/configs/chan_ooh323.conf.sample

------------------------------------------------------------------------
r252277 | may | 2010-03-14 09:42:59 -0500 (Sun, 14 Mar 2010) | 14 lines

generate roundtrip delay requests and responses

added response to roundtrip delay requests from opposite side
added roundtrip delay request sending to opposite side after answer,
added options for sending request (interval between request and
count of unreplied requests before forced call hangup)

(closes issue ASTERISK-15758)
Reported by: vmikhelson
Patches:
     rtdr-1.6.0-2.patch uploaded by may213 (license 454)
Tested by: vmikhelson, may213


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=252277