Summary:	ASTERISK-15730: [patch] fix getting callerid name in imap_retrieve_file() (broken callerid number announcement/reply/...)
Reporter:	Michael Neuhauser (mneuhauser)	Labels:
Date Opened:	2010-03-02 12:24:40.000-0600	Date Closed:	2010-06-23 13:41:18
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_voicemail/IMAP
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) asterisk-1.4-r249845-voicemail-imap-cidnum.patch
Description:	The function imap_retrieve_file() uses get_header_by_tag() to retrieve various headers from the mail in the IMAP storage and creates a temporary file from these values. The get_header_by_tag() function uses a global buffer to return its result but for the callerid, imap_retrieve_file() calls this function twice, retrieving the number AND the name and only then creates combined callerid, but at this point, both the name and the number point into the global buffer which holds the last result, i.e., both are the same string (the name, since this was retrieved last). The fix just saves the number with ast_strdupa() before calling get_header_by_tag() to retrieve the name.
Comments:	By: Leif Madsen (lmadsen) 2010-03-03 09:08:34.000-0600 Thanks for the description and patch! A developer will look at this as time and resources allow. In the meantime you could request additional testing via the asterisk-users or asterisk-dev mailing lists. Thanks! By: Digium Subversion (svnbot) 2010-06-23 13:40:28 Repository: asterisk Revision: 272147 U   branches/1.4/apps/app_voicemail.c ------------------------------------------------------------------------ r272147 | tilghman | 2010-06-23 13:40:27 -0500 (Wed, 23 Jun 2010) | 5 lines Backport part of revision 136715 to fix callerid in voicemail text files (IMAP only). (closes issue ASTERISK-15730) Reported by: mneuhauser ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=272147 By: Digium Subversion (svnbot) 2010-06-23 13:41:17 Repository: asterisk Revision: 272148 _U  trunk/ ------------------------------------------------------------------------ r272148 | tilghman | 2010-06-23 13:41:17 -0500 (Wed, 23 Jun 2010) | 12 lines Recorded merge of revisions 272147 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........  r272147 | tilghman | 2010-06-23 13:40:28 -0500 (Wed, 23 Jun 2010) | 5 lines    Backport part of revision 136715 to fix callerid in voicemail text files (IMAP only).    (closes issue ASTERISK-15730)   Reported by: mneuhauser ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=272148