Summary:	ASTERISK-15723: [patch] Cleanup transmit_callstate handling
Reporter:	Damien Wedhorn (wedhorn)	Labels:
Date Opened:	2010-03-01 15:08:47.000-0600	Date Closed:	2010-03-07 08:46:32.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_skinny
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) skinny-clean04.diff
Description:	Broke the various functions included in transmit_callstate to their own functions. Transmit_callstate now just transmits callstate. Generally left the functionality as it was, which highlight some minor code issues (eg multiple transmit_callstate's). I did however revise the hint code usage of the old transmit_callstate as it it not appropriate to put a device on hook based on the change of a hinted device. ****** ADDITIONAL INFORMATION ****** Will need testing on new devices as callstate only applies to them.
Comments:	By: Michiel van Baak (mvanbaak) 2010-03-07 08:44:28.000-0600 Works with 7960 and 7905 By: Digium Subversion (svnbot) 2010-03-07 08:46:31.000-0600 Repository: asterisk Revision: 251221 U   trunk/channels/chan_skinny.c ------------------------------------------------------------------------ r251221 | mvanbaak | 2010-03-07 08:46:30 -0600 (Sun, 07 Mar 2010) | 13 lines Cleanup transmit_callstate handling Broke the various functions included in transmit_callstate to their own functions. Transmit_callstate now just transmits callstate. Generally left the functionality as it was, which highlight some minor code issues (eg multiple transmit_callstate's). I did however revise the hint code usage of the old transmit_callstate as it it not appropriate to put a device on hook based on the change of a hinted device. (closes issue ASTERISK-15723) Reported by: wedhorn Patches:      skinny-clean04.diff uploaded by wedhorn (license 30) Tested by: mvanbaak,wedhorn ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=251221