| Summary: | ASTERISK-15715: [patch] [regression] app_followme playing wrong sound files | ||
| Reporter: | ianc (ianc) | Labels: | |
| Date Opened: | 2010-02-28 18:54:36.000-0600 | Date Closed: | 2010-03-11 10:03:34.000-0600 |
| Priority: | Major | Regression? | Yes |
| Status: | Closed/Complete | Components: | Applications/app_followme |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) fix_reload_followme.diff | |
| Description: | reload_followme is broken in 1.6.2.5, loads the wrong sound files. | ||
| Comments: | By: ianc (ianc) 2010-02-28 20:26:47.000-0600 Uh, whoops. This IS a regression. By: ianc (ianc) 2010-03-02 11:36:24.000-0600 This could probably have used a better report... the code to load sound files in reload_followme is wrong, it's using the wrong variable names. It looks like a block of code was cut/pasted during refactoring and not edited. I think it's been broken since 1.6.2.0 but I didn't really dig into that. By: Leif Madsen (lmadsen) 2010-03-03 09:25:25.000-0600 Thanks for the feedback. I will mark this appropriately. By: Digium Subversion (svnbot) 2010-03-05 13:10:48.000-0600 Repository: asterisk Revision: 250979 U trunk/apps/app_followme.c ------------------------------------------------------------------------ r250979 | jpeeler | 2010-03-05 13:10:47 -0600 (Fri, 05 Mar 2010) | 9 lines Fix app_followme playing wrong sound files. Fixes regression introduced in 140167 that uses the wrong variable names. (closes issue ASTERISK-15715) Reported by: ianc Patches: fix_reload_followme.diff uploaded by ianc (license 998) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=250979 By: Digium Subversion (svnbot) 2010-03-05 13:11:26.000-0600 Repository: asterisk Revision: 250980 _U branches/1.6.2/ U branches/1.6.2/apps/app_followme.c ------------------------------------------------------------------------ r250980 | jpeeler | 2010-03-05 13:11:26 -0600 (Fri, 05 Mar 2010) | 16 lines Merged revisions 250979 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r250979 | jpeeler | 2010-03-05 13:10:47 -0600 (Fri, 05 Mar 2010) | 9 lines Fix app_followme playing wrong sound files. Fixes regression introduced in 140167 that uses the wrong variable names. (closes issue ASTERISK-15715) Reported by: ianc Patches: fix_reload_followme.diff uploaded by ianc (license 998) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=250980 | ||