Summary:	ASTERISK-15712: [patch] Segfault branches, and trunk, when DAHDI FXS port goes off hook
Reporter:	Alec Davis (alecdavis)	Labels:
Date Opened:	2010-02-28 01:24:40.000-0600	Date Closed:	2010-02-28 15:50:50.000-0600
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_voicemail
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) app_voicemail_test.diff.txt ( 1) bug16927.diff.txt ( 2) gdb.1_6_1.txt ( 3) gdb.1_6_2.txt ( 4) gdb.txt
Description:	Could be wider than just FXS ports. regresssion since 249187 ****** ADDITIONAL INFORMATION ****** backtrace attached
Comments:	By: Alec Davis (alecdavis) 2010-02-28 02:49:37.000-0600 uploaded gdb.1_6_1.txt Asterisk SVN-branch-1.6.1-r249406M asterisk 1.6.1 will start to load, but segfaults immediately. By: Alec Davis (alecdavis) 2010-02-28 03:18:08.000-0600 uploaded gdb.1_6_2.txt Asterisk SVN-branch-1.6.2-r249407 By: Alec Davis (alecdavis) 2010-02-28 03:26:51.000-0600 uploaded bug16927.diff.txt defaults folder to 'INBOX' where has_voicemail is invoked through other paths, other than messagecount. By: Alec Davis (alecdavis) 2010-02-28 05:14:39.000-0600 app_voicemail unit test for has_voicemail. modified to catch NULL 'folder', which normally default to 'INBOX'. By: Digium Subversion (svnbot) 2010-02-28 10:36:48.000-0600 Repository: asterisk Revision: 249449 U   trunk/apps/app_voicemail.c ------------------------------------------------------------------------ r249449 | alecdavis | 2010-02-28 10:36:47 -0600 (Sun, 28 Feb 2010) | 11 lines make unit test check for NULL folder, which then defaults to INBOX previous test, gave false level of assurance that code was healthy. (issue ASTERISK-15712) Reported by: alecdavis Patches:      based on app_voicemail_test.diff.txt uploaded by alecdavis (license 585) Tested by: alecdavis ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=249449 By: Digium Subversion (svnbot) 2010-02-28 14:50:02.000-0600 Repository: asterisk Revision: 249491 U   trunk/apps/app_voicemail.c ------------------------------------------------------------------------ r249491 | tilghman | 2010-02-28 14:50:01 -0600 (Sun, 28 Feb 2010) | 5 lines Fix unit test that Alec Davis broke. (closes issue ASTERISK-15712) Reported by: alecdavis ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=249491 By: Digium Subversion (svnbot) 2010-02-28 14:51:02.000-0600 Repository: asterisk Revision: 249492 _U  branches/1.6.1/ U   branches/1.6.1/apps/app_voicemail.c ------------------------------------------------------------------------ r249492 | tilghman | 2010-02-28 14:51:02 -0600 (Sun, 28 Feb 2010) | 12 lines Merged revisions 249491 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........  r249491 | tilghman | 2010-02-28 14:50:01 -0600 (Sun, 28 Feb 2010) | 5 lines    Fix unit test that Alec Davis broke.    (closes issue ASTERISK-15712)   Reported by: alecdavis ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=249492 By: Digium Subversion (svnbot) 2010-02-28 14:51:11.000-0600 Repository: asterisk Revision: 249493 _U  branches/1.6.2/ U   branches/1.6.2/apps/app_voicemail.c ------------------------------------------------------------------------ r249493 | tilghman | 2010-02-28 14:51:11 -0600 (Sun, 28 Feb 2010) | 12 lines Merged revisions 249491 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........  r249491 | tilghman | 2010-02-28 14:50:01 -0600 (Sun, 28 Feb 2010) | 5 lines    Fix unit test that Alec Davis broke.    (closes issue ASTERISK-15712)   Reported by: alecdavis ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=249493 By: Alec Davis (alecdavis) 2010-02-28 15:50:50.000-0600 Unit test change implemented in 249449 would segfault for a developer using the TEST_FRAMEWORK, highlighting an underlying issue fixed since 249491. 249491 has now fixed the reported issue with trunk and branches, where going off hook with an FXS connected phone would cause a segfault. The unit test could be improved if it encounters a segfault, as Tilghman advised, by trapping SIGSEGV with sigaction.