[Home]

Summary:ASTERISK-15703: jblog=yes does not create jblog like expected
Reporter:Artem Makhutov (artem)Labels:
Date Opened:2010-02-26 12:10:54.000-0600Date Closed:2010-03-11 10:02:38.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/Jitterbuffer
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:Hello,

when enabling jitterbuffer and setting

jblog=yes

then the logfile is not created like expected. Insted this error message is logged:

[Feb 26 19:06:29] WARNING[27123]: abstract_jb.c:469 create_jb: Failed to put first frame in the jitterbuffer on channel 'SCCP/5555-00000001'
[Feb 26 19:06:29] ERROR[27123]: abstract_jb.c:507 create_jb: Failed to create frame log file with pathname '/tmp/ast_adaptive_jb_SIP#xxxxx-00000005--SCCPASTERISK-5407-00000001.log': Success

It has nothing to do with SCCP. This problem can also be reproduced with other channel drivers supporting jitterbuffer.

It has also nothing to do with permissions as this can also be reproduced when running asterisk as root.
Comments:By: Digium Subversion (svnbot) 2010-03-10 12:25:20.000-0600

Repository: asterisk
Revision: 251631

U   trunk/main/abstract_jb.c

------------------------------------------------------------------------
r251631 | jpeeler | 2010-03-10 12:25:18 -0600 (Wed, 10 Mar 2010) | 14 lines

Fix jitterbuffer logging not creating logfiles.

Three changes made here:
1) Do not fail if a previous log does not exist (in fact, this is probably
expected).
2) Ensure that the file descriptor to write to gets assigned properly. I am at
a loss as to why assigning safe_fd outside the if fixes this, but it makes
the if statement slightly less complicated anyway.
3) Move up the failure message so that the errno of the failure is not
overwritten by fclose.

(closes issue ASTERISK-15703)
Reported by: Artem

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=251631
By: Digium Subversion (svnbot) 2010-03-10 12:26:36.000-0600

Repository: asterisk
Revision: 251632

_U  branches/1.6.2/
U   branches/1.6.2/main/abstract_jb.c

------------------------------------------------------------------------
r251632 | jpeeler | 2010-03-10 12:26:35 -0600 (Wed, 10 Mar 2010) | 21 lines

Merged revisions 251631 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r251631 | jpeeler | 2010-03-10 12:25:18 -0600 (Wed, 10 Mar 2010) | 14 lines
 
 Fix jitterbuffer logging not creating logfiles.
 
 Three changes made here:
 1) Do not fail if a previous log does not exist (in fact, this is probably
 expected).
 2) Ensure that the file descriptor to write to gets assigned properly. I am at
 a loss as to why assigning safe_fd outside the if fixes this, but it makes
 the if statement slightly less complicated anyway.
 3) Move up the failure message so that the errno of the failure is not
 overwritten by fclose.
 
 (closes issue ASTERISK-15703)
 Reported by: Artem
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=251632