[Home]

Summary:ASTERISK-15672: [patch] unable to exit echo application with '#'
Reporter:Alec Davis (alecdavis)Labels:
Date Opened:2010-02-22 03:43:56.000-0600Date Closed:2011-07-26 14:36:57
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_echo
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) echo_exit_1-6-1.diff.txt
( 1) echo_exit.diff.txt
Description:When dialling in through ISDN into the echo application for testing purposes
the # isn't recognised.

Seems as though 'NULL' frametype cause issues.
Comments:By: Alec Davis (alecdavis) 2010-02-22 04:54:56.000-0600

uploaded:
1.6.1 svn branch version exit_echo.1.6.1.diff.txt
trunk svn version exit_echo.trunk.diff.txt

After patching 2 boxes exited echo application with '#' key on both on a 1.6.1 production server and a 'trunk' test box.
Both euroisdn E1 connected.
By: Digium Subversion (svnbot) 2010-03-02 01:38:57.000-0600

Repository: asterisk
Revision: 249801

U   trunk/apps/app_echo.c

------------------------------------------------------------------------
r249801 | alecdavis | 2010-03-02 01:38:57 -0600 (Tue, 02 Mar 2010) | 12 lines

fixes ability to exit echo app

when called from a ISDN channel, null frames prevent '#' exit.
Now only echo back VOICE and DTMF frames

(issue ASTERISK-15672)
Reported by: alecdavis
Patches:
     echo_exit.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=249801
By: Digium Subversion (svnbot) 2010-03-02 03:05:25.000-0600

Repository: asterisk
Revision: 249843

U   branches/1.6.1/apps/app_echo.c

------------------------------------------------------------------------
r249843 | alecdavis | 2010-03-02 03:05:24 -0600 (Tue, 02 Mar 2010) | 12 lines

fixes ability to exit echo app

when called from a ISDN channel, null frames prevent '#' exit.
Now only echo back VOICE and DTMF frames

(issue ASTERISK-15672)
Reported by: alecdavis
Patches:
     echo_exit_1-6-1.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=249843
By: Digium Subversion (svnbot) 2010-03-02 03:05:44.000-0600

Repository: asterisk
Revision: 249844

U   branches/1.6.2/apps/app_echo.c

------------------------------------------------------------------------
r249844 | alecdavis | 2010-03-02 03:05:43 -0600 (Tue, 02 Mar 2010) | 12 lines

fixes ability to exit echo app

when called from a ISDN channel, null frames prevent '#' exit.
Now only echo back VOICE and DTMF frames

(issue ASTERISK-15672)
Reported by: alecdavis
Patches:
     echo_exit_1-6-1.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=249844
By: Digium Subversion (svnbot) 2010-03-02 03:11:56.000-0600

Repository: asterisk
Revision: 249845

U   branches/1.4/apps/app_echo.c

------------------------------------------------------------------------
r249845 | alecdavis | 2010-03-02 03:11:56 -0600 (Tue, 02 Mar 2010) | 12 lines

fixes ability to exit echo app

when called from a ISDN channel, null frames prevent '#' exit.
Now only echo back VOICE and DTMF frames

(issue ASTERISK-15672)
Reported by: alecdavis
Patches:
     based on echo_exit_1-6-1.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=249845
By: Digium Subversion (svnbot) 2010-03-02 03:16:03.000-0600

Repository: asterisk
Revision: 249846

U   branches/1.6.0/apps/app_echo.c

------------------------------------------------------------------------
r249846 | alecdavis | 2010-03-02 03:16:02 -0600 (Tue, 02 Mar 2010) | 12 lines

fixes ability to exit echo app

when called from a ISDN channel, null frames prevent '#' exit.
Now only echo back VOICE and DTMF frames

(closes issue ASTERISK-15672)
Reported by: alecdavis
Patches:
     based on echo_exit_1-6-1.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=249846
By: Digium Subversion (svnbot) 2010-03-02 13:36:21.000-0600

Repository: asterisk
Revision: 249946

U   branches/1.4/apps/app_echo.c

------------------------------------------------------------------------
r249946 | alecdavis | 2010-03-02 13:36:20 -0600 (Tue, 02 Mar 2010) | 8 lines

revert ability to exit echo app

caused a regression, as only supported VOICE, not VIDEO etc.
Left in small formatting change.

(issue ASTERISK-15672)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=249946
By: Digium Subversion (svnbot) 2010-03-02 13:39:59.000-0600

Repository: asterisk
Revision: 249947

U   trunk/apps/app_echo.c

------------------------------------------------------------------------
r249947 | alecdavis | 2010-03-02 13:39:59 -0600 (Tue, 02 Mar 2010) | 7 lines

revert ability to exit echo app

caused a regression, as only supported VOICE, not VIDEO etc.

(issue ASTERISK-15672)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=249947
By: Digium Subversion (svnbot) 2010-03-02 13:45:27.000-0600

Repository: asterisk
Revision: 249948

U   branches/1.6.0/apps/app_echo.c

------------------------------------------------------------------------
r249948 | alecdavis | 2010-03-02 13:45:27 -0600 (Tue, 02 Mar 2010) | 7 lines

revert ability to exit echo app

caused a regression, as only supported VOICE, not VIDEO etc.

(issue ASTERISK-15672)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=249948
By: Digium Subversion (svnbot) 2010-03-02 13:47:22.000-0600

Repository: asterisk
Revision: 249949

_U  branches/1.6.1/UPGRADE.txt
U   branches/1.6.1/apps/app_echo.c
_U  branches/1.6.1/main/editline/makelist.in

------------------------------------------------------------------------
r249949 | alecdavis | 2010-03-02 13:47:22 -0600 (Tue, 02 Mar 2010) | 7 lines

revert ability to exit echo app

caused a regression, as only supported VOICE, not VIDEO etc.

(issue ASTERISK-15672)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=249949
By: Digium Subversion (svnbot) 2010-03-02 13:50:33.000-0600

Repository: asterisk
Revision: 249952

_U  branches/1.6.2/UPGRADE-1.6.txt
_U  branches/1.6.2/UPGRADE.txt
U   branches/1.6.2/apps/app_echo.c
_U  branches/1.6.2/main/editline/makelist.in

------------------------------------------------------------------------
r249952 | alecdavis | 2010-03-02 13:50:33 -0600 (Tue, 02 Mar 2010) | 7 lines

revert ability to exit echo app

caused a regression, as only supported VOICE, not VIDEO etc.

(issue ASTERISK-15672)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=249952