Summary:	ASTERISK-15670: [patch] Cleanup transmit_displaymessage
Reporter:	Damien Wedhorn (wedhorn)	Labels:
Date Opened:	2010-02-21 14:05:38.000-0600	Date Closed:	2010-03-01 13:33:28.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_skinny
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) skinny-clean02.diff ( 1) skinny-clean03.diff
Description:	This patch splits transmit_displaymessage into transmit_clear_display_message and transmit_display_message which better aligns with the skinny protocol. The new transmit_display_message is not used in the current code, but will be and so it is commented. Moved handle_datetime from this function to onhook and offhook functions (display now properly cleared at the end of a call on 30VIP). Removed skinny debug messages from inline code as there's an ast_verb in transmit_clear_display_message. Also, removed commentary that it was a clear display as it is now apparent from the function name.
Comments:	By: Damien Wedhorn (wedhorn) 2010-02-25 14:15:33.000-0600 Another patch (skinny-clean03.diff). This is a short one that splits transmit_displaypromptmessage into display and clear. By: Digium Subversion (svnbot) 2010-03-01 13:33:27.000-0600 Repository: asterisk Revision: 249670 U   trunk/channels/chan_skinny.c ------------------------------------------------------------------------ r249670 | mvanbaak | 2010-03-01 13:33:26 -0600 (Mon, 01 Mar 2010) | 17 lines Cleanup display_*message functions. This patch splits transmit_displaymessage into transmit_clear_display_message and transmit_display_message which better aligns with the skinny protocol. The new transmit_display_message is not used in the current code, but will be and so it is commented. Moved handle_datetime from this function to onhook and offhook functions (display now properly cleared at the end of a call on 30VIP). Removed skinny debug messages from inline code as there's an ast_verb in transmit_clear_display_message. Also, removed commentary that it was a clear display as it is now apparent from the function name. Split transmit_displaypromptmessage into display and clear. (closes issue ASTERISK-15670) Reported by: wedhorn Patches: skinny-clean02.diff uploaded by wedhorn (license 30) skinny-clean03.diff uploaded by wedhorn (license 30) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=249670