| Summary: | ASTERISK-15667: [patch][regression] Cannot specify http:// URL in music-on-hold class directory statement | ||
| Reporter: | raarts (raarts) | Labels: | |
| Date Opened: | 2010-02-21 07:15:21.000-0600 | Date Closed: | 2010-03-11 10:10:28.000-0600 |
| Priority: | Minor | Regression? | Yes |
| Status: | Closed/Complete | Components: | Resources/res_musiconhold |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) moh-http.patch | |
| Description: | In older versions you could specify directory=http://anything/ in a moh class definition. Part of the code still checks for that. But before spawning mpg123 the code tries to chdir into that directory, and if that fails, refuses to spawn. This patch fixes that. | ||
| Comments: | By: Leif Madsen (lmadsen) 2010-02-22 11:18:27.000-0600 Thanks for the contribution! A developer will get to this as soon as time and resources allow. By: Digium Subversion (svnbot) 2010-03-04 19:03:00.000-0600 Repository: asterisk Revision: 250786 U branches/1.4/res/res_musiconhold.c ------------------------------------------------------------------------ r250786 | jpeeler | 2010-03-04 19:02:59 -0600 (Thu, 04 Mar 2010) | 9 lines Fix not being able to specify a URL in MOH class directory. Don't attempt to chdir on a URL! (closes issue ASTERISK-15667) Reported by: raarts Patches: moh-http.patch uploaded by raarts (license 937) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=250786 By: Digium Subversion (svnbot) 2010-03-04 19:05:47.000-0600 Repository: asterisk Revision: 250787 _U trunk/ U trunk/res/res_musiconhold.c ------------------------------------------------------------------------ r250787 | jpeeler | 2010-03-04 19:05:47 -0600 (Thu, 04 Mar 2010) | 16 lines Merged revisions 250786 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r250786 | jpeeler | 2010-03-04 19:02:58 -0600 (Thu, 04 Mar 2010) | 9 lines Fix not being able to specify a URL in MOH class directory. Don't attempt to chdir on a URL! (closes issue ASTERISK-15667) Reported by: raarts Patches: moh-http.patch uploaded by raarts (license 937) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=250787 By: Digium Subversion (svnbot) 2010-03-04 19:07:47.000-0600 Repository: asterisk Revision: 250788 _U branches/1.6.0/ U branches/1.6.0/res/res_musiconhold.c ------------------------------------------------------------------------ r250788 | jpeeler | 2010-03-04 19:07:46 -0600 (Thu, 04 Mar 2010) | 23 lines Merged revisions 250787 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r250787 | jpeeler | 2010-03-04 19:05:46 -0600 (Thu, 04 Mar 2010) | 16 lines Merged revisions 250786 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r250786 | jpeeler | 2010-03-04 19:02:58 -0600 (Thu, 04 Mar 2010) | 9 lines Fix not being able to specify a URL in MOH class directory. Don't attempt to chdir on a URL! (closes issue ASTERISK-15667) Reported by: raarts Patches: moh-http.patch uploaded by raarts (license 937) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=250788 By: Digium Subversion (svnbot) 2010-03-04 19:08:37.000-0600 Repository: asterisk Revision: 250789 _U branches/1.6.1/ U branches/1.6.1/res/res_musiconhold.c ------------------------------------------------------------------------ r250789 | jpeeler | 2010-03-04 19:08:37 -0600 (Thu, 04 Mar 2010) | 23 lines Merged revisions 250787 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r250787 | jpeeler | 2010-03-04 19:05:46 -0600 (Thu, 04 Mar 2010) | 16 lines Merged revisions 250786 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r250786 | jpeeler | 2010-03-04 19:02:58 -0600 (Thu, 04 Mar 2010) | 9 lines Fix not being able to specify a URL in MOH class directory. Don't attempt to chdir on a URL! (closes issue ASTERISK-15667) Reported by: raarts Patches: moh-http.patch uploaded by raarts (license 937) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=250789 By: Digium Subversion (svnbot) 2010-03-04 19:09:16.000-0600 Repository: asterisk Revision: 250790 _U branches/1.6.2/ U branches/1.6.2/res/res_musiconhold.c ------------------------------------------------------------------------ r250790 | jpeeler | 2010-03-04 19:09:15 -0600 (Thu, 04 Mar 2010) | 23 lines Merged revisions 250787 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r250787 | jpeeler | 2010-03-04 19:05:46 -0600 (Thu, 04 Mar 2010) | 16 lines Merged revisions 250786 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r250786 | jpeeler | 2010-03-04 19:02:58 -0600 (Thu, 04 Mar 2010) | 9 lines Fix not being able to specify a URL in MOH class directory. Don't attempt to chdir on a URL! (closes issue ASTERISK-15667) Reported by: raarts Patches: moh-http.patch uploaded by raarts (license 937) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=250790 | ||