Summary:	ASTERISK-15656: [patch] PickupChan is not working
Reporter:	Bastian Schern (schern)	Labels:
Date Opened:	2010-02-18 11:18:41.000-0600	Date Closed:	2010-05-10 14:06:55
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_directed_pickup
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) app_directed_pickup.c.patch ( 1) for_trunk.diff
Description:	The application PickupChan() is not working. If you try to pickup a channel you will always get an error like the following: app_directed_pickup.c:283 pickupchan_exec: No target channel found for SIP/260. ****** STEPS TO REPRODUCE ****** Dialplan: exten => _XXX,1,PickupChan(SIP/${EXTEN}) ****** ADDITIONAL INFORMATION ****** I have a look into the code. IMHO there is a +-1 error with the length of the strings which are compared. I attached a very simple patch that fixes the problem.
Comments:	By: Antonio Graber (graber) 2010-03-28 13:55:29 Thanks! Tested with Asterisk 1.6.2.6: PickupChan works fine By: Christian Jacobsen (cjacobsen) 2010-04-26 09:08:44 This patch works in branch but not in trunk. By: Andrew Latham (lathama) 2010-04-29 11:25:24 Trunk diff works. 1.6.2 diff works. By: Richard Wilkinson (rickead2000) 2010-05-06 06:54:26 Patch works against 1.6.2.6 By: Digium Subversion (svnbot) 2010-05-10 14:06:09 Repository: asterisk Revision: 262240 U   trunk/apps/app_directed_pickup.c ------------------------------------------------------------------------ r262240 | dvossel | 2010-05-10 14:06:08 -0500 (Mon, 10 May 2010) | 9 lines fixes PickupChan application (closes issue ASTERISK-15656) Reported by: schern Patches:      app_directed_pickup.c.patch uploaded by schern (license 995)      for_trunk.diff uploaded by cjacobsen (license 1029) Tested by: Graber, cjacobsen, lathama, rickead2000, dvossel ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=262240 By: Digium Subversion (svnbot) 2010-05-10 14:06:54 Repository: asterisk Revision: 262241 _U  branches/1.6.2/ U   branches/1.6.2/apps/app_directed_pickup.c ------------------------------------------------------------------------ r262241 | dvossel | 2010-05-10 14:06:54 -0500 (Mon, 10 May 2010) | 16 lines Merged revisions 262240 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........  r262240 | dvossel | 2010-05-10 14:06:08 -0500 (Mon, 10 May 2010) | 9 lines    fixes PickupChan application    (closes issue ASTERISK-15656)  Reported by: schern  Patches:        app_directed_pickup.c.patch uploaded by schern (license 995)        for_trunk.diff uploaded by cjacobsen (license 1029)  Tested by: Graber, cjacobsen, lathama, rickead2000, dvossel ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=262241