[Home]

Summary:ASTERISK-15646: [patch] Some issues with New SDP handling code and T.38
Reporter:Christophe Sollet (cfc)Labels:
Date Opened:2010-02-17 08:36:16.000-0600Date Closed:2010-08-20 13:21:11
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/T.38
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) fix-t38-process_sdp.patch
Description:- Connection information defined at media level are not read. If SDP don't define a (c=) at session level, process_sdp() fail with "Insufficient information in SDP (c=)...". The patch add processing of (c=) defined at media level for image too.

- As process_sdp() now use a dedicated "isin" sockaddr_in, sin.sin_addr.s_addr stay null in case of T38 re-invite. This force to hold the channel. If MusicOnHold is present, generator is setup on the channel. This result in dropping all udptl frames... The patch add a check on isin to avoid unwanted Hold state.
Comments:By: Digium Subversion (svnbot) 2010-07-19 15:56:06

Repository: asterisk
Revision: 277944

U   branches/1.4/channels/chan_sip.c

------------------------------------------------------------------------
r277944 | pabelanger | 2010-07-19 15:56:05 -0500 (Mon, 19 Jul 2010) | 16 lines

Regression with T.38 negotiation

Prior to 1.4.26.3 T.38 negotiation worked properly, in the case
of the reporter.  

(issue ASTERISK-15646)
Reported by: cfc

(closes issue ASTERISK-15520)
Reported by: mpiazzatnetbug
Patches:
     issue16705_2.diff uploaded by ebroad (license 878)
Tested by: vrban, ebroad, c0rnoTa, samdell3

Review: https://reviewboard.asterisk.org/r/754/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=277944
By: Digium Subversion (svnbot) 2010-08-19 14:43:58

Repository: asterisk
Revision: 282859

U   branches/1.6.2/channels/chan_sip.c

------------------------------------------------------------------------
r282859 | mnicholson | 2010-08-19 14:43:58 -0500 (Thu, 19 Aug 2010) | 23 lines

Merged revisions 277944 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r277944 | pabelanger | 2010-07-19 15:56:07 -0500 (Mon, 19 Jul 2010) | 16 lines
 
 Regression with T.38 negotiation
 
 Prior to 1.4.26.3 T.38 negotiation worked properly, in the case
 of the reporter.  
 
 (issue ASTERISK-15646)
 Reported by: cfc
 
 (closes issue ASTERISK-15520)
 Reported by: mpiazzatnetbug
 Patches:
       issue16705_2.diff uploaded by ebroad (license 878)
 Tested by: vrban, ebroad, c0rnoTa, samdell3
 
 Review: https://reviewboard.asterisk.org/r/754/
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=282859
By: Digium Subversion (svnbot) 2010-08-19 15:01:10

Repository: asterisk
Revision: 282860

_U  branches/1.8/
U   branches/1.8/channels/chan_sip.c

------------------------------------------------------------------------
r282860 | mnicholson | 2010-08-19 15:01:09 -0500 (Thu, 19 Aug 2010) | 30 lines

Merged revisions 282859 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
 r282859 | mnicholson | 2010-08-19 14:44:00 -0500 (Thu, 19 Aug 2010) | 23 lines
 
 Merged revisions 277944 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r277944 | pabelanger | 2010-07-19 15:56:07 -0500 (Mon, 19 Jul 2010) | 16 lines
   
   Regression with T.38 negotiation
   
   Prior to 1.4.26.3 T.38 negotiation worked properly, in the case
   of the reporter.  
   
   (issue ASTERISK-15646)
   Reported by: cfc
   
   (closes issue ASTERISK-15520)
   Reported by: mpiazzatnetbug
   Patches:
         issue16705_2.diff uploaded by ebroad (license 878)
   Tested by: vrban, ebroad, c0rnoTa, samdell3
   
   Review: https://reviewboard.asterisk.org/r/754/
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=282860
By: Digium Subversion (svnbot) 2010-08-19 15:02:51

Repository: asterisk
Revision: 282861

_U  trunk/
U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r282861 | mnicholson | 2010-08-19 15:02:51 -0500 (Thu, 19 Aug 2010) | 37 lines

Merged revisions 282860 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
 r282860 | mnicholson | 2010-08-19 15:01:11 -0500 (Thu, 19 Aug 2010) | 30 lines
 
 Merged revisions 282859 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.6.2
 
 ................
   r282859 | mnicholson | 2010-08-19 14:44:00 -0500 (Thu, 19 Aug 2010) | 23 lines
   
   Merged revisions 277944 via svnmerge from
   https://origsvn.digium.com/svn/asterisk/branches/1.4
   
   ........
     r277944 | pabelanger | 2010-07-19 15:56:07 -0500 (Mon, 19 Jul 2010) | 16 lines
     
     Regression with T.38 negotiation
     
     Prior to 1.4.26.3 T.38 negotiation worked properly, in the case
     of the reporter.  
     
     (issue ASTERISK-15646)
     Reported by: cfc
     
     (closes issue ASTERISK-15520)
     Reported by: mpiazzatnetbug
     Patches:
           issue16705_2.diff uploaded by ebroad (license 878)
     Tested by: vrban, ebroad, c0rnoTa, samdell3
     
     Review: https://reviewboard.asterisk.org/r/754/
   ........
 ................
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=282861