[Home]

Summary:ASTERISK-15628: [patch] Build fails on smsq.c with syntax error
Reporter:Ben Klang (bklang)Labels:
Date Opened:2010-02-15 14:08:07.000-0600Date Closed:2011-06-07 14:07:50
Priority:MinorRegression?Yes
Status:Closed/CompleteComponents:Core/BuildSystem
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20100216__issue16830.diff.txt
( 1) autoconfig.h
Description:Some time between revision 242974 and rev 246199 the ability to build on OpenSolaris broke.

This is the error message I get:

Generating embedded module rules ...
  [CC] smsq.c -> smsq.o
In file included from /export/home/admin/asterisk-1.6.2.svn/include/asterisk.h:27,
                from smsq.c:20:
/export/home/admin/asterisk-1.6.2.svn/include/asterisk/compat.h:105: error: syntax error before "strtoq"
/export/home/admin/asterisk-1.6.2.svn/include/asterisk/compat.h:105: warning: type defaults to `int' in declaration of `strtoq'
/export/home/admin/asterisk-1.6.2.svn/include/asterisk/compat.h:105: warning: data definition has no type or storage class
smsq.c: In function `txqcheck':
smsq.c:131: warning: implicit declaration of function `getpid'
smsq.c:180: warning: implicit declaration of function `link'
smsq.c:182: warning: implicit declaration of function `unlink'
smsq.c: In function `rxqcheck':
smsq.c:269: warning: implicit declaration of function `atoi'
smsq.c:402: warning: implicit declaration of function `system'
smsq.c: In function `main':
smsq.c:636: warning: implicit declaration of function `read'
smsq.c:643: warning: implicit declaration of function `close'
smsq.c:671: warning: implicit declaration of function `chdir'
smsq.c:763: warning: implicit declaration of function `sleep'
gmake[1]: *** [smsq.o] Error 1
gmake: *** [utils] Error 2

Checking the svn log for include/asterisk/compat.h shows no changes since well before r242974.  I tried diffing configure but can't easily because that file is marked as binary in svn.  I tried manually diffing between revisions but nothing jumped out at me.

I also noted this output from the end of ./configure, right before the ascii-art logo is displayed:

Label too long: :defs/$/ /
Label too long: :defs,^\([       #]*\)[^         ]*\([   ]*_FILE_OFFSET_BITS\)[  (].*,\1define\2 64 ,
Label too long: :defs,^\([       #]*\)[^         ]*\([   ]*HAVE_PUTENV\)[        (].*,\1define\2 1 ,
Label too long: :defs,^\([       #]*\)[^         ]*\([   ]*HAVE_SIN\)[   (].*,\1define\2 1 ,
Label too long: :defs,^\([       #]*\)[^         ]*\([   ]*HAVE_BKTR_VERSION\)[  (].*,\1define\2  ,
Comments:By: Tilghman Lesher (tilghman) 2010-02-16 12:37:01.000-0600

Please apply this patch, run ./bootstrap.sh, then ./configure, and upload your resulting include/asterisk/autoconfig.h.
By: Ben Klang (bklang) 2010-02-16 12:43:37.000-0600

That patch actually fixes the issue for me. I am attaching autoconfig.h.

For the record, I am still manually modifying autoconfig.h to fix the definition of SPANDSP_EXPOSE_H (see ticket ASTERISK-15232).
By: Tilghman Lesher (tilghman) 2010-02-16 13:28:13.000-0600

That patch doesn't fix any issue whatsoever.  If anything was fixed, then it was the fact that you regenerated the configure files.
By: Ben Klang (bklang) 2010-02-16 14:38:23.000-0600

Then the issue must also exist in the configure that is in SVN.  I ran into this issue with fresh checkouts from svn at the revision numbers originally noted, without having run bootstrap.sh.  I also just verified that the issue exists in a fresh checkout of the 1.6.2 branch.
By: Leif Madsen (lmadsen) 2010-03-23 12:34:04

Where is this issue at?
By: Ben Klang (bklang) 2010-03-23 12:58:27

"configure", at least in the 1.6.2 branch, has since been regenerated.  On a fresh checkout I can configure and make without errors.

I think this can be closed, thanks.
By: Leif Madsen (lmadsen) 2010-03-24 13:22:16

OK thanks. For future reference you may be able to do 'make distclean' to resolve the issue if that was really the case.

Thanks!