Summary:	ASTERISK-15617: [patch] Manager event AgentComplete should alway be sent
Reporter:	Gabriel Ortiz Lour (elbriga)	Labels:
Date Opened:	2010-02-12 14:34:12.000-0600	Date Closed:	2010-06-23 17:37:25
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_queue
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) app_queue.diff
Description:	The manager event AgentComplete dont get sent when an attended transfer occour. In the source code there is an comment that explain the why of the IF, but it dont take into account that the AgentComplete event is inside that IF and should get send anyway. ****** ADDITIONAL INFORMATION ****** The patch is for the 1.6.2.2 version, but the bug is on all (1.4.2X+ at least) asterisk versions.
Comments:	By: Matthew Nicholson (mnicholson) 2010-06-22 10:16:57 I am not sure if this change should be treated as a new feature or a bug fix.  Adding AgentComplete events where there were none before, might break some billing systems.  In other words, I am not sure if this should be added in all branches, or if it should only go into trunk. By: Digium Subversion (svnbot) 2010-06-23 17:33:51 Repository: asterisk Revision: 272367 U   branches/1.4/apps/app_queue.c ------------------------------------------------------------------------ r272367 | mnicholson | 2010-06-23 17:33:51 -0500 (Wed, 23 Jun 2010) | 8 lines Send AgentComplete manager events in the event of blind and attended transfers. (closes issue ASTERISK-15617) Reported by: elbriga Patches:      app_queue.diff uploaded by elbriga (license 482) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=272367 By: Digium Subversion (svnbot) 2010-06-23 17:36:49 Repository: asterisk Revision: 272368 _U  trunk/ U   trunk/apps/app_queue.c ------------------------------------------------------------------------ r272368 | mnicholson | 2010-06-23 17:36:48 -0500 (Wed, 23 Jun 2010) | 16 lines Merged revisions 272367 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 This version of the patch only adds AgentComplete for attended transfers.  It was already present for blind transfers. ........  r272367 | mnicholson | 2010-06-23 17:33:51 -0500 (Wed, 23 Jun 2010) | 8 lines    Send AgentComplete manager events in the event of blind and attended transfers.    (closes issue ASTERISK-15617)  Reported by: elbriga  Patches:        app_queue.diff uploaded by elbriga (license 482) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=272368 By: Digium Subversion (svnbot) 2010-06-23 17:37:24 Repository: asterisk Revision: 272369 _U  branches/1.6.2/ U   branches/1.6.2/apps/app_queue.c ------------------------------------------------------------------------ r272369 | mnicholson | 2010-06-23 17:37:24 -0500 (Wed, 23 Jun 2010) | 23 lines Merged revisions 272368 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................  r272368 | mnicholson | 2010-06-23 17:36:49 -0500 (Wed, 23 Jun 2010) | 16 lines    Merged revisions 272367 via svnmerge from  https://origsvn.digium.com/svn/asterisk/branches/1.4    This version of the patch only adds AgentComplete for attended transfers.  It was already present for blind transfers.    ........    r272367 | mnicholson | 2010-06-23 17:33:51 -0500 (Wed, 23 Jun 2010) | 8 lines        Send AgentComplete manager events in the event of blind and attended transfers.        (closes issue ASTERISK-15617)    Reported by: elbriga    Patches:          app_queue.diff uploaded by elbriga (license 482)  ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=272369