[Home]

Summary:ASTERISK-15563: [patch] Clean transmit_* for start/stop media transmission
Reporter:Damien Wedhorn (wedhorn)Labels:
Date Opened:2010-03-03 14:34:47.000-0600Date Closed:2010-03-07 08:53:08.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_skinny
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) skinny-clean05.diff
( 1) skinny-clean05a.diff
( 2) skinny-clean05b.diff
Description:Small patch changing skinny_set_rtp_peer to use transmit_stopmediatransmission and to use new transmit_startmediatransmission. Basic testing on 30VIP's.

****** ADDITIONAL INFORMATION ******

There is a slight change in this patch as ast_rtp_instance_get_local_address(rtp,).sin_addr.s_addr is used instead of d->ourip.s_addr. I assume they are equivalent.
Comments:By: Damien Wedhorn (wedhorn) 2010-03-04 12:59:23.000-0600

Patch 5a removes so extraneous code.
By: Damien Wedhorn (wedhorn) 2010-03-05 17:03:39.000-0600

And another one (5b). I missed a startmedia in hande_open_receive_channel_ack. Now refers to transmit_startmedia. There was also an issue with asterisk's IP which is fixed.

Tested on 30VIP and works fine for initial RTP stuff. Did not test set_rtp_peer which is called from elsewhere, although the code is effectively the same as initial handling.
By: Digium Subversion (svnbot) 2010-03-07 08:53:07.000-0600

Repository: asterisk
Revision: 251222

U   trunk/channels/chan_skinny.c

------------------------------------------------------------------------
r251222 | mvanbaak | 2010-03-07 08:53:06 -0600 (Sun, 07 Mar 2010) | 12 lines

Clean transmit_* for start/stop media transmission

Small patch changing skinny_set_rtp_peer to use transmit_stopmediatransmission and to use new transmit_startmediatransmission.
Basic testing on 30VIP's by wedhorn
Basic testing on 7960 by me

(closes issue ASTERISK-15563)
Reported by: wedhorn
Patches:
     skinny-clean05b.diff uploaded by wedhorn (license 30)
Tested by: wedhorn,mvanbaak

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=251222