| Summary: | ASTERISK-15527: [patch] CHANNEL function cannot set OSP token for outbound IAX calls. | ||
| Reporter: | Di-Shi Sun (homesick) | Labels: | |
| Date Opened: | 2010-01-27 01:34:32.000-0600 | Date Closed: | 2010-01-27 11:41:58.000-0600 |
| Priority: | Major | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_iax2 |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) iax-svn.diff | |
| Description: | In the call scenarios where the inbound channel is not IAX, CHANNEL function cannot set OSP token for the outbound IAX channel. The reason is the CHANNEL function for the inbound channel does not support "osptoken" parameter. The idea to fix this bug is to set an inherited channel variable, _IAX2OSPTOKEN. The outbound IAX channel will use it to set OSP token. It is similar to SIPADDHEADER for SIP channel. The patch removes acf_channel_write function and adds getting OSP token from IAX2OSPTOKEN variable. | ||
| Comments: | By: Digium Subversion (svnbot) 2010-01-27 11:32:08.000-0600 Repository: asterisk Revision: 243482 U trunk/channels/chan_iax2.c U trunk/funcs/func_channel.c ------------------------------------------------------------------------ r243482 | russell | 2010-01-27 11:32:07 -0600 (Wed, 27 Jan 2010) | 13 lines Fix the ability to specify an OSP token for an outbound IAX2 call. When this patch was originally submitted, the code allowed for the token to be set via a channel variable. I decided that a cleaner approach would be to integrate it into the CHANNEL() function. Unfortunately, that is not a suitable approach. It's not possible to get the value set on the channel soon enough using that method. So, go back to the simple channel variable method. (closes issue ASTERISK-15527) Reported by: homesick Patches: iax-svn.diff uploaded by homesick (license 91) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=243482 By: Digium Subversion (svnbot) 2010-01-27 11:35:37.000-0600 Repository: asterisk Revision: 243483 _U branches/1.6.0/ U branches/1.6.0/channels/chan_iax2.c U branches/1.6.0/funcs/func_channel.c ------------------------------------------------------------------------ r243483 | russell | 2010-01-27 11:35:37 -0600 (Wed, 27 Jan 2010) | 20 lines Merged revisions 243482 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r243482 | russell | 2010-01-27 11:32:07 -0600 (Wed, 27 Jan 2010) | 13 lines Fix the ability to specify an OSP token for an outbound IAX2 call. When this patch was originally submitted, the code allowed for the token to be set via a channel variable. I decided that a cleaner approach would be to integrate it into the CHANNEL() function. Unfortunately, that is not a suitable approach. It's not possible to get the value set on the channel soon enough using that method. So, go back to the simple channel variable method. (closes issue ASTERISK-15527) Reported by: homesick Patches: iax-svn.diff uploaded by homesick (license 91) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=243483 By: Digium Subversion (svnbot) 2010-01-27 11:39:17.000-0600 Repository: asterisk Revision: 243484 _U branches/1.6.1/ U branches/1.6.1/channels/chan_iax2.c U branches/1.6.1/funcs/func_channel.c ------------------------------------------------------------------------ r243484 | russell | 2010-01-27 11:39:16 -0600 (Wed, 27 Jan 2010) | 20 lines Merged revisions 243482 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r243482 | russell | 2010-01-27 11:32:07 -0600 (Wed, 27 Jan 2010) | 13 lines Fix the ability to specify an OSP token for an outbound IAX2 call. When this patch was originally submitted, the code allowed for the token to be set via a channel variable. I decided that a cleaner approach would be to integrate it into the CHANNEL() function. Unfortunately, that is not a suitable approach. It's not possible to get the value set on the channel soon enough using that method. So, go back to the simple channel variable method. (closes issue ASTERISK-15527) Reported by: homesick Patches: iax-svn.diff uploaded by homesick (license 91) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=243484 By: Digium Subversion (svnbot) 2010-01-27 11:41:58.000-0600 Repository: asterisk Revision: 243485 _U branches/1.6.2/ U branches/1.6.2/channels/chan_iax2.c U branches/1.6.2/funcs/func_channel.c ------------------------------------------------------------------------ r243485 | russell | 2010-01-27 11:41:58 -0600 (Wed, 27 Jan 2010) | 20 lines Merged revisions 243482 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r243482 | russell | 2010-01-27 11:32:07 -0600 (Wed, 27 Jan 2010) | 13 lines Fix the ability to specify an OSP token for an outbound IAX2 call. When this patch was originally submitted, the code allowed for the token to be set via a channel variable. I decided that a cleaner approach would be to integrate it into the CHANNEL() function. Unfortunately, that is not a suitable approach. It's not possible to get the value set on the channel soon enough using that method. So, go back to the simple channel variable method. (closes issue ASTERISK-15527) Reported by: homesick Patches: iax-svn.diff uploaded by homesick (license 91) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=243485 | ||