Summary: | ASTERISK-15508: [patch] Missing fallback to audio fax feature when T.38 re-INVITE failed for 1.4 | ||
Reporter: | Kristijan Vrban (vrban) | Labels: | |
Date Opened: | 2010-01-25 07:21:20.000-0600 | Date Closed: | 2010-06-01 09:54:11 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Channels/chan_sip/T.38 |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) t38_fallback_to_audio_v2_unlcean_and_experimental.patch ( 1) t38_fallback_to_audio_v3.patch ( 2) t38_fallback_to_audio.patch | |
Description: | When a T.38 re-INVITE failed with an 488 or 606 answer, we should fallback to audio fax by send a re-re-INVITE without T.38. The function is backported from 1.6 asterisk. Some people say this is a feature, other say that it is a bug that 1.4 does not fallback to audio. Here is the patch. | ||
Comments: | By: Leif Madsen (lmadsen) 2010-01-29 15:30:05.000-0600 Russell has agreed this is a bug, so I'm moving this up to Ready for Testing By: Kristijan Vrban (vrban) 2010-02-09 10:05:10.000-0600 Relationship: https://issues.asterisk.org/view.php?id=8677 By: Kristijan Vrban (vrban) 2010-02-11 03:42:30.000-0600 this issue is in relationship with: https://issues.asterisk.org/view.php?id=16795 Without ASTERISK-15597 this patch is only half done By: Kristijan Vrban (vrban) 2010-02-11 06:14:35.000-0600 hello, the new (high grade experimental) patch is working in my lab, and 1.4 chan_sip procures a fallback to audio fax between a T.38 re-INVITE B-side (a asterisk-1.6 with app_fax) and the A-side that dont talk T.38 By: haggard (haggard) 2010-02-16 05:04:51.000-0600 Hello, I can confirm that fallback to audio fax after receiving cause 606 is now working with 1.4.29 and this patch. By: Digium Subversion (svnbot) 2010-06-01 09:54:07 Repository: asterisk Revision: 266579 U branches/1.4/channels/chan_sip.c ------------------------------------------------------------------------ r266579 | pabelanger | 2010-06-01 09:54:05 -0500 (Tue, 01 Jun 2010) | 18 lines Missing fallback to audio fax feature when T.38 re-INVITE failed When a T.38 re-INVITE failed with an 488 or 606 answer, we should fallback to audio fax by send a re-re-INVITE without T.38. The function is backported from 1.6 asterisk. (closes issue ASTERISK-15597) Reported by: vrban (closes issue ASTERISK-15508) Reported by: vrban Patches: t38_fallback_to_audio_v3.patch uploaded by vrban (license 756) Tested by: lmadsen, vrban, haggard https://reviewboard.asterisk.org/r/514/ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=266579 |