[Home]

Summary:ASTERISK-15502: [patch] app_dial does not respect GOSUB_RESULT
Reporter:Ben Klang (bklang)Labels:
Date Opened:2010-01-24 23:26:37.000-0600Date Closed:2010-02-02 14:35:45.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_dial
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_dial-respect-gosub_result.patch
Description:When using the U() option with app_dial, the GOSUB_RESULT flag as set in the called context is not respected by app_dial.  This leads to calls not being hung up as they should per the documentation.

The problem is that the variable GOSUB_RESULT is checked, but the flag intending to hang up the called channel (peer) is never consulted after the Gosub handling is complete.  This patch fixes the behavior so the channel is properly hung up.
Comments:By: Digium Subversion (svnbot) 2010-02-02 14:32:31.000-0600

Repository: asterisk
Revision: 244393

U   trunk/CHANGES
U   trunk/apps/app_dial.c

------------------------------------------------------------------------
r244393 | tilghman | 2010-02-02 14:32:30 -0600 (Tue, 02 Feb 2010) | 18 lines

Properly respect GOSUB_RESULT as to what to do with the master channel.

Previously, we would parse GOSUB_RESULT, but not actually do anything with it.
Also, allow GOSUB_RETVAL to be inherited back across a peer/master channel.

(closes issue ASTERISK-15503)
Reported by: bklang
Patches:
      app_dial-preserve-gosub_retval.patch uploaded by bklang (license 919)
      (with modifications)

(closes issue ASTERISK-15502)
Reported by: bklang
Patches:
      app_dial-respect-gosub_result.patch uploaded by bklang (license 919)
      (with modifications)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=244393
By: Digium Subversion (svnbot) 2010-02-02 14:35:37.000-0600

Repository: asterisk
Revision: 244394

_U  branches/1.6.1/
U   branches/1.6.1/apps/app_dial.c

------------------------------------------------------------------------
r244394 | tilghman | 2010-02-02 14:35:36 -0600 (Tue, 02 Feb 2010) | 17 lines

Merged revisions 244393 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r244393 | tilghman | 2010-02-02 14:32:29 -0600 (Tue, 02 Feb 2010) | 18 lines
 
 Properly respect GOSUB_RESULT as to what to do with the master channel.
 
 Previously, we would parse GOSUB_RESULT, but not actually do anything with it.
 
 (closes issue ASTERISK-15502)
  Reported by: bklang
  Patches:
        app_dial-respect-gosub_result.patch uploaded by bklang (license 919)
        (with modifications)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=244394
By: Digium Subversion (svnbot) 2010-02-02 14:35:45.000-0600

Repository: asterisk
Revision: 244395

_U  branches/1.6.2/
U   branches/1.6.2/apps/app_dial.c

------------------------------------------------------------------------
r244395 | tilghman | 2010-02-02 14:35:44 -0600 (Tue, 02 Feb 2010) | 17 lines

Merged revisions 244393 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r244393 | tilghman | 2010-02-02 14:32:29 -0600 (Tue, 02 Feb 2010) | 18 lines
 
 Properly respect GOSUB_RESULT as to what to do with the master channel.
 
 Previously, we would parse GOSUB_RESULT, but not actually do anything with it.
 
 (closes issue ASTERISK-15502)
  Reported by: bklang
  Patches:
        app_dial-respect-gosub_result.patch uploaded by bklang (license 919)
        (with modifications)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=244395