[Home]

Summary:ASTERISK-15468: [patch] Its not possible to pass more than one agrument in custom features.
Reporter:pinga-fogo (pinga-fogo)Labels:
Date Opened:2010-01-19 04:46:24.000-0600Date Closed:2010-10-18 00:06:49
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Resources/res_features
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20100414__issue16646.diff.txt
Description:Is not possible to pass mor than one argument in a custon features, if i use the pipe | to separate the arguments, this downt work in dialplan, and if i use "," to separate the arguments the feature accept the first argument only,
example:
testfeature => *25,peer/callee,goto,tstfax|s|1
(in execution the dialplan not recognise the pipe separator (deprecated))

testfeature => *25,peer/callee,goto,tstfax,s,1
(the parameters are parsed incorrect, MOH_Class = s)

Comments:By: Tilghman Lesher (tilghman) 2010-02-08 12:02:35.000-0600

I note the following in features.conf:

; IMPORTANT NOTE: The applicationmap is not intended to be used for all Asterisk
;   applications. When applications are used in extensions.conf, they are executed
;   by the PBX core. In this case, these applications are executed outside of the
;   PBX core, so it does *not* make sense to use any application which has any
;   concept of dialplan flow. Examples of this would be things like Macro, Goto,
;   Background, WaitExten, and many more.

By: Tilghman Lesher (tilghman) 2010-02-08 14:44:59.000-0600

However, even if your example is pooched, I recognize the importance of being able to pass multiple arguments to a dialplan application.  Patch uploaded.
By: Tilghman Lesher (tilghman) 2010-02-16 13:23:06.000-0600

pinga-fogo:  I need your feedback here.  Does this change work for your needs?
By: Digium Subversion (svnbot) 2010-04-14 17:57:37

Repository: asterisk
Revision: 257262

U   trunk/configs/features.conf.sample
U   trunk/main/features.c

------------------------------------------------------------------------
r257262 | tilghman | 2010-04-14 17:57:36 -0500 (Wed, 14 Apr 2010) | 15 lines

Yet another issue where the conversion of the application delimiter to comma caused an issue.

Application arguments within the feature map could possibly contain a comma,
which conflicts with the syntax of the features.conf configuration file.  This
patch allows the argument to be wrapped in parentheses or quoted, to allow the
application arguments to be interpreted as a single configuration parameter.

(closes issue ASTERISK-15468)
Reported by: pinga-fogo
Patches:
      20100414__issue16646.diff.txt uploaded by tilghman (license 14)
Tested by: tilghman

Review: https://reviewboard.asterisk.org/r/547/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=257262
By: Digium Subversion (svnbot) 2010-04-14 18:00:00

Repository: asterisk
Revision: 257263

_U  branches/1.6.0/
U   branches/1.6.0/configs/features.conf.sample
U   branches/1.6.0/main/features.c

------------------------------------------------------------------------
r257263 | tilghman | 2010-04-14 17:59:59 -0500 (Wed, 14 Apr 2010) | 22 lines

Merged revisions 257262 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r257262 | tilghman | 2010-04-14 17:57:35 -0500 (Wed, 14 Apr 2010) | 15 lines
 
 Yet another issue where the conversion of the application delimiter to comma caused an issue.
 
 Application arguments within the feature map could possibly contain a comma,
 which conflicts with the syntax of the features.conf configuration file.  This
 patch allows the argument to be wrapped in parentheses or quoted, to allow the
 application arguments to be interpreted as a single configuration parameter.
 
 (closes issue ASTERISK-15468)
  Reported by: pinga-fogo
  Patches:
        20100414__issue16646.diff.txt uploaded by tilghman (license 14)
  Tested by: tilghman
 
 Review: https://reviewboard.asterisk.org/r/547/
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=257263
By: Digium Subversion (svnbot) 2010-04-14 18:00:08

Repository: asterisk
Revision: 257264

_U  branches/1.6.1/
U   branches/1.6.1/configs/features.conf.sample
U   branches/1.6.1/main/features.c

------------------------------------------------------------------------
r257264 | tilghman | 2010-04-14 18:00:08 -0500 (Wed, 14 Apr 2010) | 22 lines

Merged revisions 257262 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r257262 | tilghman | 2010-04-14 17:57:35 -0500 (Wed, 14 Apr 2010) | 15 lines
 
 Yet another issue where the conversion of the application delimiter to comma caused an issue.
 
 Application arguments within the feature map could possibly contain a comma,
 which conflicts with the syntax of the features.conf configuration file.  This
 patch allows the argument to be wrapped in parentheses or quoted, to allow the
 application arguments to be interpreted as a single configuration parameter.
 
 (closes issue ASTERISK-15468)
  Reported by: pinga-fogo
  Patches:
        20100414__issue16646.diff.txt uploaded by tilghman (license 14)
  Tested by: tilghman
 
 Review: https://reviewboard.asterisk.org/r/547/
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=257264
By: Digium Subversion (svnbot) 2010-04-14 18:00:23

Repository: asterisk
Revision: 257265

_U  branches/1.6.2/
U   branches/1.6.2/configs/features.conf.sample
U   branches/1.6.2/main/features.c

------------------------------------------------------------------------
r257265 | tilghman | 2010-04-14 18:00:22 -0500 (Wed, 14 Apr 2010) | 22 lines

Merged revisions 257262 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r257262 | tilghman | 2010-04-14 17:57:35 -0500 (Wed, 14 Apr 2010) | 15 lines
 
 Yet another issue where the conversion of the application delimiter to comma caused an issue.
 
 Application arguments within the feature map could possibly contain a comma,
 which conflicts with the syntax of the features.conf configuration file.  This
 patch allows the argument to be wrapped in parentheses or quoted, to allow the
 application arguments to be interpreted as a single configuration parameter.
 
 (closes issue ASTERISK-15468)
  Reported by: pinga-fogo
  Patches:
        20100414__issue16646.diff.txt uploaded by tilghman (license 14)
  Tested by: tilghman
 
 Review: https://reviewboard.asterisk.org/r/547/
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=257265