[Home]

Summary:ASTERISK-15461: [patch] Update CDR variables that are available, before pbx starts
Reporter:Alec Davis (alecdavis)Labels:
Date Opened:2010-01-18 15:50:18.000-0600Date Closed:2010-06-14 19:16:03
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_dahdi
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) cdr_update.diff3.txt
Description:In asterisk 1.6.1 this was done on-hangup, so new fields that were added in cdr.c:set_one_cid were not seen until after hangup.

Trunk during the hangup, doesn't execute ast_cdr_update anymore, so unless dialplan code that sets a cdr variable was executed, the variable would not saved.

First noticed after 'dnid' addition to cdr records. https://reviewboard.asterisk.org/r/455/
Comments:By: Digium Subversion (svnbot) 2010-01-18 16:00:25.000-0600

Repository: asterisk
Revision: 241097

U   trunk/channels/sig_pri.c

------------------------------------------------------------------------
r241097 | alecdavis | 2010-01-18 16:00:24 -0600 (Mon, 18 Jan 2010) | 10 lines

Update CDR variables before pbx starts

Allows CDR variables added in cdr.c:set_one_cid to become visable during the call.

(closes issue ASTERISK-15461)
Reported by: alecdavis
Patches:
     cdr_update.diff.txt uploaded by alecdavis (license 585)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=241097
By: Alec Davis (alecdavis) 2010-01-18 18:20:58.000-0600

uploaded cdr_update.diff2.txt
Fixes overlap dial senario.
By: Digium Subversion (svnbot) 2010-01-18 18:24:35.000-0600

Repository: asterisk
Revision: 241187

U   trunk/channels/sig_pri.c

------------------------------------------------------------------------
r241187 | alecdavis | 2010-01-18 18:24:35 -0600 (Mon, 18 Jan 2010) | 11 lines

Update CDR variables before pbx starts (overlap dial)

Allows CDR variables added in cdr.c:set_one_cid to become visable during the call.

(issue ASTERISK-15461)
Reported by: alecdavis
Patches:
     cdr_update.diff2.txt uploaded by alecdavis (license 585)
Tested by: alecdavis


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=241187
By: Digium Subversion (svnbot) 2010-01-20 02:18:48.000-0600

Repository: asterisk
Revision: 241416

U   trunk/channels/sig_pri.c
U   trunk/main/pbx.c

------------------------------------------------------------------------
r241416 | alecdavis | 2010-01-20 02:18:47 -0600 (Wed, 20 Jan 2010) | 13 lines

Update CDR variables before pbx starts

Allows CDR variables added in cdr.c:set_one_cid to become visable during the call,
by executing ast_cdr_update() early in __ast_pbx run.
Reverts sig_pri changes in trunk that are specific to isdn technology only.

(issue ASTERISK-15461)
Reported by: alecdavis
Patches:
     cdr_update.diff3.txt uploaded by alecdavis (license 585)
Tested by: alecdavis


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=241416
By: Digium Subversion (svnbot) 2010-01-20 03:37:26.000-0600

Repository: asterisk
Revision: 241455

U   branches/1.6.2/main/pbx.c

------------------------------------------------------------------------
r241455 | alecdavis | 2010-01-20 03:37:25 -0600 (Wed, 20 Jan 2010) | 14 lines

Update CDR variables as pbx starts

Allows CDR variables added in cdr.c:set_one_cid to become visable during the call,
by executing ast_cdr_update() early in __ast_pbx_run.

Based on cdr_update.diff3.txt

(issue ASTERISK-15461)
Reported by: alecdavis
Patches:
     cdr_update.diff3.txt uploaded by alecdavis (license 585)
Tested by: alecdavis


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=241455
By: Digium Subversion (svnbot) 2010-01-20 03:37:41.000-0600

Repository: asterisk
Revision: 241456

U   branches/1.6.1/main/pbx.c

------------------------------------------------------------------------
r241456 | alecdavis | 2010-01-20 03:37:40 -0600 (Wed, 20 Jan 2010) | 14 lines

Update CDR variables as pbx starts

Allows CDR variables added in cdr.c:set_one_cid to become visable during the call,
by executing ast_cdr_update() early in __ast_pbx_run.

Based on cdr_update.diff3.txt

(issue ASTERISK-15461)
Reported by: alecdavis
Patches:
     cdr_update.diff3.txt uploaded by alecdavis (license 585)
Tested by: alecdavis


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=241456
By: Digium Subversion (svnbot) 2010-01-20 03:37:55.000-0600

Repository: asterisk
Revision: 241457

U   branches/1.6.0/main/pbx.c

------------------------------------------------------------------------
r241457 | alecdavis | 2010-01-20 03:37:55 -0600 (Wed, 20 Jan 2010) | 14 lines

Update CDR variables as pbx starts

Allows CDR variables added in cdr.c:set_one_cid to become visable during the call,
by executing ast_cdr_update() early in __ast_pbx_run.

Based on cdr_update.diff3.txt

(issue ASTERISK-15461)
Reported by: alecdavis
Patches:
     cdr_update.diff3.txt uploaded by alecdavis (license 585)
Tested by: alecdavis


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=241457
By: Digium Subversion (svnbot) 2010-01-20 03:38:09.000-0600

Repository: asterisk
Revision: 241458

U   branches/1.4/main/pbx.c

------------------------------------------------------------------------
r241458 | alecdavis | 2010-01-20 03:38:09 -0600 (Wed, 20 Jan 2010) | 14 lines

Update CDR variables as pbx starts

Allows CDR variables added in cdr.c:set_one_cid to become visable during the call,
by executing ast_cdr_update() early in __ast_pbx_run.

Based on cdr_update.diff3.txt

(issue ASTERISK-15461)
Reported by: alecdavis
Patches:
     cdr_update.diff3.txt uploaded by alecdavis (license 585)
Tested by: alecdavis


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=241458
By: Alec Davis (alecdavis) 2010-01-20 03:56:55.000-0600

Now during a call, any new cdr variables added in cdr.c:set_one_cid are filled in, example being the new 'dnid' cdr variable.

test*CLI> core show channel DAHDI/i1/45551234:1234-1
-- General --
          Name: DAHDI/i1/45551234:1234-1
          Type: DAHDI
      UniqueID: 1263980756.0
      LinkedID: 1263980756.0
     Caller ID: 45551234
Caller ID Name: (N/A)
   DNID Digits: 8699
      Language: en
         State: Up (6)
         Rings: 1
 NativeFormats: 0x8 (alaw)
   WriteFormat: 0x8 (alaw)
    ReadFormat: 0x8 (alaw)
WriteTranscode: No
 ReadTranscode: No
1st File Descriptor: 20
     Frames in: 2142
    Frames out: 332
Time to Hangup: 0
  Elapsed Time: 0h0m43s
 Direct Bridge: <none>
Indirect Bridge: <none>
--   PBX   --
       Context: incoming
     Extension: 8699
      Priority: 3
    Call Group: 0
  Pickup Group: 0
   Application: VoiceMailMain
          Data: (Empty)
   Blocking in: ast_waitfor_nandfds
     Variables:
CALLEDTON=1
PRIREDIRECTREASON=UNKNOWN
ANI2=0
CALLEDSUBADDR=8690
CALLINGSUBADDR=1234

 CDR Variables:
level 1: dnid=8699
level 1: clid=45551234
level 1: src=45551234
level 1: dst=8699
level 1: dcontext=incoming
level 1: channel=DAHDI/i1/45551234:1234-1
level 1: lastapp=VoiceMailMain
level 1: start=2010-01-20 22:45:56
level 1: answer=2010-01-20 22:45:56
level 1: duration=42
level 1: billsec=42
level 1: disposition=ANSWERED
level 1: amaflags=DOCUMENTATION
level 1: uniqueid=1263980756.0
level 1: linkedid=1263980756.0
level 1: sequence=0
By: Digium Subversion (svnbot) 2010-01-20 13:27:42.000-0600

Repository: asterisk
Revision: 241416

U   trunk/channels/sig_pri.c
U   trunk/main/pbx.c

------------------------------------------------------------------------
r241416 | alecdavis | 2010-01-20 02:18:45 -0600 (Wed, 20 Jan 2010) | 13 lines

Update CDR variables as pbx starts

Allows CDR variables added in cdr.c:set_one_cid to become visable during the call,
by executing ast_cdr_update() early in __ast_pbx run.
Reverts sig_pri changes in trunk that are specific to isdn technology only.

(closes issue ASTERISK-15461)
Reported by: alecdavis
Patches:
     cdr_update.diff3.txt uploaded by alecdavis (license 585)
Tested by: alecdavis


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=241416