Summary:	ASTERISK-15438: [patch] option p added to PickupChan to enable pickup a ringing phone by specifying the peer name
Reporter:	Nico Kooijman (syspert)	Labels:
Date Opened:	2010-01-15 09:58:53.000-0600	Date Closed:	2010-03-02 15:58:40.000-0600
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_directed_pickup
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) pickipbycallid.patch ( 1) pickupbycallerid_v2.patch
Description:	PickupChan requires the full correct name of a channel with the generated part like SIP/nameofphone-0000f. By specifying option "p" enables call pick up on the  phone ringing on the specified peer.
Comments:	By: Leif Madsen (lmadsen) 2010-01-15 13:15:23.000-0600 You can't do this with the Bridge() application already can you? By: Leif Madsen (lmadsen) 2010-01-15 14:20:19.000-0600 I misunderstood how this works, so ignore my comment :) By: David Vossel (dvossel) 2010-03-02 15:53:30.000-0600 Great patch! I reviewed the code and uploaded a patch that resolves a few issues I found. By: Digium Subversion (svnbot) 2010-03-02 15:58:04.000-0600 Repository: asterisk Revision: 250141 U   trunk/CHANGES U   trunk/apps/app_directed_pickup.c ------------------------------------------------------------------------ r250141 | dvossel | 2010-03-02 15:58:03 -0600 (Tue, 02 Mar 2010) | 15 lines adds 'p' option to PickupChan The 'p' option allows the PickupChan app to pickup a ringing phone by looking for the first match to a partial channel name rather than requiring a full match. (closes issue ASTERISK-15438) Reported by: syspert Patches:      pickipbycallid.patch uploaded by syspert (license 938)      pickupbycallerid_v2.patch uploaded by dvossel (license 671) Tested by: dvossel, syspert ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=250141 By: Digium Subversion (svnbot) 2010-03-02 15:58:39.000-0600 Repository: asterisk Revision: 250142 _U  branches/1.6.2/ ------------------------------------------------------------------------ r250142 | dvossel | 2010-03-02 15:58:39 -0600 (Tue, 02 Mar 2010) | 19 lines Blocked revisions 250141 via svnmerge ........  r250141 | dvossel | 2010-03-02 15:58:03 -0600 (Tue, 02 Mar 2010) | 15 lines    adds 'p' option to PickupChan    The 'p' option allows the PickupChan app to pickup  a ringing phone by looking for the first match to a  partial channel name rather than requiring a full match.    (closes issue ASTERISK-15438)  Reported by: syspert  Patches:        pickipbycallid.patch uploaded by syspert (license 938)        pickupbycallerid_v2.patch uploaded by dvossel (license 671)  Tested by: dvossel, syspert ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=250142