[Home]

Summary:ASTERISK-15427: [patch] astcanary does not exit when asterisk 1.6.2 dies => reopen of #14538
Reporter:frawd (frawd)Labels:
Date Opened:2010-01-14 05:24:17.000-0600Date Closed:2010-01-15 15:44:50.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Utilities/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20100114__issue16602.diff.txt
( 1) astcanary.patch
Description:bug ASTERISK-13637 was not corrected in trunk and 1.6.2.X
Comments:By: Leif Madsen (lmadsen) 2010-01-14 06:49:39.000-0600

Marking as Ready for Review -- not sure why it didn't make it into 1.6.2 as I see it was merged into trunk in the previous version, and presume 1.6.2 was branched after that.
By: Tilghman Lesher (tilghman) 2010-01-14 10:39:57.000-0600

The issue was that kpfleming objected to the way that this patch worked -- that it depended upon behavior that was not strictly POSIX (children inheriting PID 1 as their parent).

http://www.opengroup.org/onlinepubs/009695399/basedefs/xbd_chap03.html#tag_03_265


By: frawd (frawd) 2010-01-14 11:10:59.000-0600

Agreed on the objection. I unfortunately have no useful feedback as it was not even my patch and I'm no POSIX expert to propose cleaner solutions. :-)

I don't really like that new astcanary anyway. It leaves dozens of useless processes when using safe_asterisk (because of strange segfaults), or whenever we want to stop/restart. It could also hide important bugs on a pretty unstable version of Asterisk (1.6) which should be the first ones to be found and resolved.

Is there currently a way to run * in realtime without this process? Could the solution of this bug be the removal of this program?
By: Tilghman Lesher (tilghman) 2010-01-14 12:37:43.000-0600

I've uploaded an alternate patch which should overcome kpfleming's objections to the previous patch.
By: frawd (frawd) 2010-01-15 03:29:41.000-0600

thanks, seems like it works ok
By: Digium Subversion (svnbot) 2010-01-15 15:40:15.000-0600

Repository: asterisk
Revision: 240499

U   trunk/main/asterisk.c
U   trunk/utils/astcanary.c

------------------------------------------------------------------------
r240499 | tilghman | 2010-01-15 15:40:14 -0600 (Fri, 15 Jan 2010) | 9 lines

The previous attempt at using a pipe to guarantee astcanary shutdown did not work.
We're revisiting the previous patch, albeit with a method that overcomes the
prior criticism that it was not POSIX-compliant.
(closes issue ASTERISK-15427)
Reported by: frawd
Patches:
      20100114__issue16602.diff.txt uploaded by tilghman (license 14)
Tested by: frawd

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=240499
By: Digium Subversion (svnbot) 2010-01-15 15:44:30.000-0600

Repository: asterisk
Revision: 240501

_U  branches/1.6.0/
U   branches/1.6.0/main/asterisk.c
U   branches/1.6.0/utils/astcanary.c

------------------------------------------------------------------------
r240501 | tilghman | 2010-01-15 15:44:30 -0600 (Fri, 15 Jan 2010) | 20 lines

Merged revisions 240499-240500 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r240499 | tilghman | 2010-01-15 15:40:14 -0600 (Fri, 15 Jan 2010) | 9 lines
 
 The previous attempt at using a pipe to guarantee astcanary shutdown did not work.
 We're revisiting the previous patch, albeit with a method that overcomes the
 prior criticism that it was not POSIX-compliant.
 (closes issue ASTERISK-15427)
  Reported by: frawd
  Patches:
        20100114__issue16602.diff.txt uploaded by tilghman (license 14)
  Tested by: frawd
........
 r240500 | tilghman | 2010-01-15 15:42:36 -0600 (Fri, 15 Jan 2010) | 2 lines
 
 Oops, missed an include
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=240501
By: Digium Subversion (svnbot) 2010-01-15 15:44:41.000-0600

Repository: asterisk
Revision: 240502

_U  branches/1.6.1/
U   branches/1.6.1/main/asterisk.c
U   branches/1.6.1/utils/astcanary.c

------------------------------------------------------------------------
r240502 | tilghman | 2010-01-15 15:44:41 -0600 (Fri, 15 Jan 2010) | 20 lines

Merged revisions 240499-240500 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r240499 | tilghman | 2010-01-15 15:40:14 -0600 (Fri, 15 Jan 2010) | 9 lines
 
 The previous attempt at using a pipe to guarantee astcanary shutdown did not work.
 We're revisiting the previous patch, albeit with a method that overcomes the
 prior criticism that it was not POSIX-compliant.
 (closes issue ASTERISK-15427)
  Reported by: frawd
  Patches:
        20100114__issue16602.diff.txt uploaded by tilghman (license 14)
  Tested by: frawd
........
 r240500 | tilghman | 2010-01-15 15:42:36 -0600 (Fri, 15 Jan 2010) | 2 lines
 
 Oops, missed an include
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=240502
By: Digium Subversion (svnbot) 2010-01-15 15:44:49.000-0600

Repository: asterisk
Revision: 240503

_U  branches/1.6.2/
U   branches/1.6.2/main/asterisk.c
U   branches/1.6.2/utils/astcanary.c

------------------------------------------------------------------------
r240503 | tilghman | 2010-01-15 15:44:49 -0600 (Fri, 15 Jan 2010) | 20 lines

Merged revisions 240499-240500 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r240499 | tilghman | 2010-01-15 15:40:14 -0600 (Fri, 15 Jan 2010) | 9 lines
 
 The previous attempt at using a pipe to guarantee astcanary shutdown did not work.
 We're revisiting the previous patch, albeit with a method that overcomes the
 prior criticism that it was not POSIX-compliant.
 (closes issue ASTERISK-15427)
  Reported by: frawd
  Patches:
        20100114__issue16602.diff.txt uploaded by tilghman (license 14)
  Tested by: frawd
........
 r240500 | tilghman | 2010-01-15 15:42:36 -0600 (Fri, 15 Jan 2010) | 2 lines
 
 Oops, missed an include
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=240503