Summary: | ASTERISK-15377: When hanging up a channel running chanspy, chanspy does not exit | ||
Reporter: | Mark Murawski (kobaz) | Labels: | |
Date Opened: | 2009-12-29 13:23:30.000-0600 | Date Closed: | 2010-01-13 10:55:37.000-0600 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Applications/app_chanspy |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ||
Description: | extend context services { 1 => { ChanSpy(SIP/3007,Wq); } } -- Executing [1@_cos_internal+local+ld+intl:1] ChanSpy("SIP/3030-00000006", "SIP/3007,Wq") in new stack == Spying on channel SIP/3007-00000005 [Dec 29 14:21:36] NOTICE[1827]: app_chanspy.c:245 start_spying: Attaching SIP/3030-00000006 to SIP/3007-00000005 [Dec 29 14:21:36] NOTICE[1827]: app_chanspy.c:245 start_spying: Attaching SIP/3030-00000006 to SIP/3007-00000005 SIP/3030 dials 1@services chanspy launches 3030 hangs up. channel never goes away pa01*CLI> pa01*CLI> nothing happens to the channel that was spying. pa01*CLI> core show channels Channel Location State Application(Data) SIP/3030-00000006 1@_cos_internal+loca Up ChanSpy(SIP/3007,Wq) SIP/3007-00000005 s@macro-callee-picku Up Wait(1000) | ||
Comments: | By: David Vossel (dvossel) 2010-01-08 11:12:38.000-0600 The issue here is that the ChanSpy channel will not hangup when there is no audio being passed while the other channel is in wait. This issue is directly related to issue ASTERISK-15378. By: Digium Subversion (svnbot) 2010-01-13 10:31:17.000-0600 Repository: asterisk Revision: 239712 U trunk/Makefile U trunk/apps/app_waitforring.c U trunk/apps/app_waitforsilence.c U trunk/main/channel.c ------------------------------------------------------------------------ r239712 | dvossel | 2010-01-13 10:31:15 -0600 (Wed, 13 Jan 2010) | 24 lines add silence gen to wait apps asterisk.conf's 'transmit_silence' option existed before this patch, but was limited to only generating silence while recording and sending DTMF. Now enabling the transmit_silence option generates silence during wait times as well. To achieve this, ast_safe_sleep has been modified to generate silence anytime no other generators are present and transmit_silence is enabled. Wait apps not using ast_safe_sleep now generate silence when transmit_silence is enabled as well. (closes issue ASTERISK-15378) Reported by: kobaz (closes issue ASTERISK-15377) Reported by: kobaz Tested by: dvossel Review: https://reviewboard.asterisk.org/r/456/ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=239712 By: Digium Subversion (svnbot) 2010-01-13 10:37:08.000-0600 Repository: asterisk Revision: 239713 _U branches/1.6.2/ U branches/1.6.2/Makefile U branches/1.6.2/apps/app_waitforring.c U branches/1.6.2/apps/app_waitforsilence.c U branches/1.6.2/main/channel.c ------------------------------------------------------------------------ r239713 | dvossel | 2010-01-13 10:37:07 -0600 (Wed, 13 Jan 2010) | 30 lines Merged revisions 239712 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r239712 | dvossel | 2010-01-13 10:31:14 -0600 (Wed, 13 Jan 2010) | 24 lines add silence gen to wait apps asterisk.conf's 'transmit_silence' option existed before this patch, but was limited to only generating silence while recording and sending DTMF. Now enabling the transmit_silence option generates silence during wait times as well. To achieve this, ast_safe_sleep has been modified to generate silence anytime no other generators are present and transmit_silence is enabled. Wait apps not using ast_safe_sleep now generate silence when transmit_silence is enabled as well. (closes issue ASTERISK-15378) Reported by: kobaz (closes issue ASTERISK-15377) Reported by: kobaz Tested by: dvossel Review: https://reviewboard.asterisk.org/r/456/ ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=239713 By: Digium Subversion (svnbot) 2010-01-13 10:38:33.000-0600 Repository: asterisk Revision: 239714 _U branches/1.6.1/ U branches/1.6.1/Makefile U branches/1.6.1/apps/app_waitforring.c U branches/1.6.1/apps/app_waitforsilence.c U branches/1.6.1/main/channel.c ------------------------------------------------------------------------ r239714 | dvossel | 2010-01-13 10:38:32 -0600 (Wed, 13 Jan 2010) | 30 lines Merged revisions 239712 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r239712 | dvossel | 2010-01-13 10:31:14 -0600 (Wed, 13 Jan 2010) | 24 lines add silence gen to wait apps asterisk.conf's 'transmit_silence' option existed before this patch, but was limited to only generating silence while recording and sending DTMF. Now enabling the transmit_silence option generates silence during wait times as well. To achieve this, ast_safe_sleep has been modified to generate silence anytime no other generators are present and transmit_silence is enabled. Wait apps not using ast_safe_sleep now generate silence when transmit_silence is enabled as well. (closes issue ASTERISK-15378) Reported by: kobaz (closes issue ASTERISK-15377) Reported by: kobaz Tested by: dvossel Review: https://reviewboard.asterisk.org/r/456/ ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=239714 By: Digium Subversion (svnbot) 2010-01-13 10:55:37.000-0600 Repository: asterisk Revision: 239716 _U branches/1.6.0/ U branches/1.6.0/Makefile U branches/1.6.0/apps/app_waitforring.c U branches/1.6.0/apps/app_waitforsilence.c U branches/1.6.0/main/channel.c ------------------------------------------------------------------------ r239716 | dvossel | 2010-01-13 10:55:35 -0600 (Wed, 13 Jan 2010) | 30 lines Merged revisions 239712 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r239712 | dvossel | 2010-01-13 10:31:14 -0600 (Wed, 13 Jan 2010) | 24 lines add silence gen to wait apps asterisk.conf's 'transmit_silence' option existed before this patch, but was limited to only generating silence while recording and sending DTMF. Now enabling the transmit_silence option generates silence during wait times as well. To achieve this, ast_safe_sleep has been modified to generate silence anytime no other generators are present and transmit_silence is enabled. Wait apps not using ast_safe_sleep now generate silence when transmit_silence is enabled as well. (closes issue ASTERISK-15378) Reported by: kobaz (closes issue ASTERISK-15377) Reported by: kobaz Tested by: dvossel Review: https://reviewboard.asterisk.org/r/456/ ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=239716 |