| Summary: | ASTERISK-15362: [patch] meetme can support only 6341 rooms | ||
| Reporter: | Kashif Raza (kashif raza) | Labels: | |
| Date Opened: | 2009-12-23 06:17:04.000-0600 | Date Closed: | 2009-12-29 16:53:59.000-0600 |
| Priority: | Critical | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/app_meetme |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) 1.6.2.0-bt ( 1) 20091223_16509.patch ( 2) app_meetme.c.rej ( 3) dump.txt | |
| Description: | in meetme.conf we can create maximum 6341 rooms, the movement you create room number 6342 and try to access any room, asterisk gives Segmentation fault, one solution is to use real time meetme, in that case i have tested with 1 million rooms. | ||
| Comments: | By: Kristijan Vrban (vrban) 2009-12-23 09:03:24.000-0600 Hello Kashif, in your asterisk source ckeck doc/backtrace.txt to read how to find the place where the Segmentation fault happened. You use 1 million meetme rooms with one asterisk??? awesome! By: Kashif Raza (kashif raza) 2009-12-23 09:42:09.000-0600 at a given point of time i am testing only one rooms, dont confuse that i am trying to run all rooms simultaneously. if i make room more then 6341 then asterisk is not allowing to use any single room. By: Sean Bright (seanbright) 2009-12-23 10:09:39.000-0600 From the backtrace: "/usr/src/asterisk-1.4.5/" So either you are running a *very* old version of Asterisk, or you need to rebuild/reinstall asterisk with debugging symbols enabled (see doc/backtrace.txt). By: Sean Bright (seanbright) 2009-12-23 13:18:44.000-0600 I've uploaded a patch which should resolve this problem (the patch is made against the latest 1.4 SVN). Please test and report your results. By: Kashif Raza (kashif raza) 2009-12-24 06:38:25.000-0600 this problem also exist in 1.6.2.0 but in different manner, 1.6.2.0 allows max 6781 rooms, if you create room number 6782 and try to access it, asterisk crashes, 1.4.x dont allow you to access any room if total number of rooms are more then 6341, in 1.6.2.0 you can create any number of rooms but if you try to access any room after 6781 asterisk crashes, pfa bt for 1.6.2.0 By: Sean Bright (seanbright) 2009-12-24 08:09:53.000-0600 Did you test the patch I uploaded to this bug against 1.4? By: Sean Bright (seanbright) 2009-12-24 10:22:35.000-0600 What is app_meetme.c.rej? What version of asterisk are you trying to patch? What is the output of: core show version from the Asterisk CLI. By: Digium Subversion (svnbot) 2009-12-28 06:43:38.000-0600 Repository: asterisk Revision: 236509 U branches/1.4/apps/app_meetme.c ------------------------------------------------------------------------ r236509 | seanbright | 2009-12-28 06:43:37 -0600 (Mon, 28 Dec 2009) | 12 lines Avoid a crash with large numbers of MeetMe conferences. Similar to changes made to Queue(), when we have large numbers of conferences in meetme.conf (1000s) and we use alloca()/strdupa(), we can blow out the stack and crash, so instead just use a single fixed buffer. (closes issue ASTERISK-15362) Reported by: Kashif Raza Patches: 20091223_16509.patch uploaded by seanbright (license 71) Tested by: seanbright ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=236509 By: Digium Subversion (svnbot) 2009-12-28 06:44:59.000-0600 Repository: asterisk Revision: 236510 _U trunk/ U trunk/apps/app_meetme.c ------------------------------------------------------------------------ r236510 | seanbright | 2009-12-28 06:44:59 -0600 (Mon, 28 Dec 2009) | 19 lines Merged revisions 236509 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r236509 | seanbright | 2009-12-28 07:43:36 -0500 (Mon, 28 Dec 2009) | 12 lines Avoid a crash with large numbers of MeetMe conferences. Similar to changes made to Queue(), when we have large numbers of conferences in meetme.conf (1000s) and we use alloca()/strdupa(), we can blow out the stack and crash, so instead just use a single fixed buffer. (closes issue ASTERISK-15362) Reported by: Kashif Raza Patches: 20091223_16509.patch uploaded by seanbright (license 71) Tested by: seanbright ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=236510 By: Digium Subversion (svnbot) 2009-12-28 07:15:27.000-0600 Repository: asterisk Revision: 236511 _U branches/1.6.0/ U branches/1.6.0/apps/app_meetme.c ------------------------------------------------------------------------ r236511 | seanbright | 2009-12-28 07:15:26 -0600 (Mon, 28 Dec 2009) | 26 lines Merged revisions 236510 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r236510 | seanbright | 2009-12-28 07:44:58 -0500 (Mon, 28 Dec 2009) | 19 lines Merged revisions 236509 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r236509 | seanbright | 2009-12-28 07:43:36 -0500 (Mon, 28 Dec 2009) | 12 lines Avoid a crash with large numbers of MeetMe conferences. Similar to changes made to Queue(), when we have large numbers of conferences in meetme.conf (1000s) and we use alloca()/strdupa(), we can blow out the stack and crash, so instead just use a single fixed buffer. (closes issue ASTERISK-15362) Reported by: Kashif Raza Patches: 20091223_16509.patch uploaded by seanbright (license 71) Tested by: seanbright ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=236511 By: Digium Subversion (svnbot) 2009-12-28 07:15:29.000-0600 Repository: asterisk Revision: 236512 _U branches/1.6.1/ U branches/1.6.1/apps/app_meetme.c ------------------------------------------------------------------------ r236512 | seanbright | 2009-12-28 07:15:29 -0600 (Mon, 28 Dec 2009) | 26 lines Merged revisions 236510 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r236510 | seanbright | 2009-12-28 07:44:58 -0500 (Mon, 28 Dec 2009) | 19 lines Merged revisions 236509 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r236509 | seanbright | 2009-12-28 07:43:36 -0500 (Mon, 28 Dec 2009) | 12 lines Avoid a crash with large numbers of MeetMe conferences. Similar to changes made to Queue(), when we have large numbers of conferences in meetme.conf (1000s) and we use alloca()/strdupa(), we can blow out the stack and crash, so instead just use a single fixed buffer. (closes issue ASTERISK-15362) Reported by: Kashif Raza Patches: 20091223_16509.patch uploaded by seanbright (license 71) Tested by: seanbright ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=236512 By: Digium Subversion (svnbot) 2009-12-28 07:15:31.000-0600 Repository: asterisk Revision: 236513 _U branches/1.6.2/ U branches/1.6.2/apps/app_meetme.c ------------------------------------------------------------------------ r236513 | seanbright | 2009-12-28 07:15:30 -0600 (Mon, 28 Dec 2009) | 26 lines Merged revisions 236510 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r236510 | seanbright | 2009-12-28 07:44:58 -0500 (Mon, 28 Dec 2009) | 19 lines Merged revisions 236509 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r236509 | seanbright | 2009-12-28 07:43:36 -0500 (Mon, 28 Dec 2009) | 12 lines Avoid a crash with large numbers of MeetMe conferences. Similar to changes made to Queue(), when we have large numbers of conferences in meetme.conf (1000s) and we use alloca()/strdupa(), we can blow out the stack and crash, so instead just use a single fixed buffer. (closes issue ASTERISK-15362) Reported by: Kashif Raza Patches: 20091223_16509.patch uploaded by seanbright (license 71) Tested by: seanbright ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=236513 | ||