Summary:	ASTERISK-15357: Segfault in res_agi with no second paramter to EXEC
Reporter:	Ben Klang (bklang)	Labels:
Date Opened:	2009-12-22 18:48:44.000-0600	Date Closed:	2010-07-14 13:37:11
Priority:	Critical	Regression?	No
Status:	Closed/Complete	Components:	Resources/res_agi
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) agi-crash-gdb.txt
Description:	This crash occurs reliably, usually on the second invocation of the AGI script.  The AGI script is called via FastAGI to a network socket on localhost. This has been tested with the AGI EXEC command to reliably crash Asterisk.  The problem occurs when a command is passed to EXEC with no arguments.  In my case, the command was "EXEC NoCDR " (including the trailing space) If I supply any string for the command argument the segfault does not occur. For example: "EXEC NoCDR x" gdb log output attached (bt;bt full; thread apply all bt full)
Comments:	By: Digium Subversion (svnbot) 2009-12-22 20:55:25.000-0600 Repository: asterisk Revision: 236184 U   branches/1.4/res/res_agi.c ------------------------------------------------------------------------ r236184 | tilghman | 2009-12-22 20:55:24 -0600 (Tue, 22 Dec 2009) | 4 lines If EXEC only gets a single argument, don't crash when the second is used. (closes issue ASTERISK-15357) Reported by: bklang ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=236184 By: Digium Subversion (svnbot) 2009-12-22 21:07:49.000-0600 Repository: asterisk Revision: 236186 _U  trunk/ U   trunk/res/res_agi.c ------------------------------------------------------------------------ r236186 | tilghman | 2009-12-22 21:07:49 -0600 (Tue, 22 Dec 2009) | 11 lines Merged revisions 236184 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........  r236184 | tilghman | 2009-12-22 20:55:24 -0600 (Tue, 22 Dec 2009) | 4 lines    If EXEC only gets a single argument, don't crash when the second is used.  (closes issue ASTERISK-15357)   Reported by: bklang ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=236186 By: Digium Subversion (svnbot) 2009-12-22 21:10:10.000-0600 Repository: asterisk Revision: 236187 _U  branches/1.6.0/ U   branches/1.6.0/res/res_agi.c ------------------------------------------------------------------------ r236187 | tilghman | 2009-12-22 21:10:10 -0600 (Tue, 22 Dec 2009) | 18 lines Merged revisions 236186 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................  r236186 | tilghman | 2009-12-22 21:07:48 -0600 (Tue, 22 Dec 2009) | 11 lines    Merged revisions 236184 via svnmerge from  https://origsvn.digium.com/svn/asterisk/branches/1.4    ........    r236184 | tilghman | 2009-12-22 20:55:24 -0600 (Tue, 22 Dec 2009) | 4 lines        If EXEC only gets a single argument, don't crash when the second is used.    (closes issue ASTERISK-15357)     Reported by: bklang  ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=236187 By: Digium Subversion (svnbot) 2009-12-22 21:10:22.000-0600 Repository: asterisk Revision: 236188 _U  branches/1.6.1/ U   branches/1.6.1/res/res_agi.c ------------------------------------------------------------------------ r236188 | tilghman | 2009-12-22 21:10:22 -0600 (Tue, 22 Dec 2009) | 18 lines Merged revisions 236186 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................  r236186 | tilghman | 2009-12-22 21:07:48 -0600 (Tue, 22 Dec 2009) | 11 lines    Merged revisions 236184 via svnmerge from  https://origsvn.digium.com/svn/asterisk/branches/1.4    ........    r236184 | tilghman | 2009-12-22 20:55:24 -0600 (Tue, 22 Dec 2009) | 4 lines        If EXEC only gets a single argument, don't crash when the second is used.    (closes issue ASTERISK-15357)     Reported by: bklang  ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=236188 By: Digium Subversion (svnbot) 2009-12-22 21:10:31.000-0600 Repository: asterisk Revision: 236189 _U  branches/1.6.2/ U   branches/1.6.2/res/res_agi.c ------------------------------------------------------------------------ r236189 | tilghman | 2009-12-22 21:10:31 -0600 (Tue, 22 Dec 2009) | 18 lines Merged revisions 236186 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................  r236186 | tilghman | 2009-12-22 21:07:48 -0600 (Tue, 22 Dec 2009) | 11 lines    Merged revisions 236184 via svnmerge from  https://origsvn.digium.com/svn/asterisk/branches/1.4    ........    r236184 | tilghman | 2009-12-22 20:55:24 -0600 (Tue, 22 Dec 2009) | 4 lines        If EXEC only gets a single argument, don't crash when the second is used.    (closes issue ASTERISK-15357)     Reported by: bklang  ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=236189