|Summary:||ASTERISK-15350: [patch] utils/extconf.c growing apart from main/pbx.c|
|Reporter:||Walter Doekes (wdoekes)||Labels:||patch|
|Date Opened:||2009-12-21 15:52:29.000-0600||Date Closed:|
|Environment:||Attachments:||( 0) ast-add-missing-comment-slash.diff|
( 1) growing_apart_126.96.36.199.txt
( 2) growing_apart_188.8.131.52.txt
|Description:||I don't know if this is a bug or not, but I'll file it for references sake:|
In asterisk 184.108.40.206 main/pbx.c and utils/extconf.c ext_cmp() and ext_cmp1() are pretty similar -- I suspect they were the same once. After asterisk 220.127.116.11 they differ more (due to ASTERISK-14398). And possibly, after a fix to ASTERISK-15340, they'll be even further apart.
Is this intentional, or should the changes to main/pbx.c have been merged into utils/extconf.c?
P.S. Category is probably wrong, but only ael_main.c and conf2ael.c seem to use extconf.c.
P.P.S. If you're going to poke in the extconf files, please add the missing beginning-of-comment slash on line 144 in extconf.h (which goes unnoticed as the block is #ifdef'd out).