[Home]

Summary:ASTERISK-15346: [patch] When setting a soundfile for announce with a length longer then 80 chars a storage overlay happens
Reporter:Nico Kooijman (syspert)Labels:
Date Opened:2009-12-21 07:53:26.000-0600Date Closed:2011-01-25 13:15:42.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_queue
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) soundfilelen.pacth-2
Description:Crash in app_queue.
Changed the length of the announce field from 80 to AST_CONFIG_MAX_PATH .
Comments:By: Nico Kooijman (syspert) 2009-12-21 08:18:13.000-0600

please hold, the fix is incorrect
By: Leif Madsen (lmadsen) 2009-12-21 08:43:23.000-0600

Setting to feedback while the reporter corrects his patch :)
By: Nico Kooijman (syspert) 2009-12-21 08:46:02.000-0600

Thanks, correct file now uploaded.
By: Nico Kooijman (syspert) 2010-01-18 05:10:07.000-0600

Just a small question, the status has been changed to "ready for review", shouldn't it be "ready for testing"? Or do I misunderstand the flow?
And an other, can the incorrect first file be deleted from the issue, I tried but didn't know how to do so?
By: Leif Madsen (lmadsen) 2010-01-18 09:06:30.000-0600

When patches are trivial like this, then I typically move them past the Ready for Testing phase to the Ready for Review phase as it mostly just needs to be reviewed and committed at that point. Anyone is welcome to test while things are Ready for Review -- it just doesn't make sense for a trivial issue to sit for testing when it likely isn't required. (Personal judgement call.)
By: Nico Kooijman (syspert) 2010-01-26 10:10:59.000-0600

review created at https://reviewboard.asterisk.org/r/475/
By: Digium Subversion (svnbot) 2010-01-27 12:47:35.000-0600

Repository: asterisk
Revision: 243570

U   branches/1.4/apps/app_queue.c

------------------------------------------------------------------------
r243570 | jpeeler | 2010-01-27 12:47:35 -0600 (Wed, 27 Jan 2010) | 9 lines

Extend announcement URL used with Queue from 80 chars to PATH_MAX.

(closes issue ASTERISK-15346)
Reported by: syspert
Patches:
     soundfilelen.pacth-2 uploaded by syspert (license 938)

Review: https://reviewboard.asterisk.org/r/475/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=243570
By: Digium Subversion (svnbot) 2010-01-27 12:49:53.000-0600

Repository: asterisk
Revision: 243571

_U  trunk/
U   trunk/apps/app_queue.c

------------------------------------------------------------------------
r243571 | jpeeler | 2010-01-27 12:49:53 -0600 (Wed, 27 Jan 2010) | 16 lines

Merged revisions 243570 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r243570 | jpeeler | 2010-01-27 12:47:34 -0600 (Wed, 27 Jan 2010) | 9 lines
 
 Extend announcement URL used with Queue from 80 chars to PATH_MAX.
 
 (closes issue ASTERISK-15346)
 Reported by: syspert
 Patches:
       soundfilelen.pacth-2 uploaded by syspert (license 938)
 
 Review: https://reviewboard.asterisk.org/r/475/
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=243571
By: Digium Subversion (svnbot) 2010-01-27 12:50:51.000-0600

Repository: asterisk
Revision: 243572

_U  branches/1.6.0/
U   branches/1.6.0/apps/app_queue.c

------------------------------------------------------------------------
r243572 | jpeeler | 2010-01-27 12:50:51 -0600 (Wed, 27 Jan 2010) | 23 lines

Merged revisions 243571 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r243571 | jpeeler | 2010-01-27 12:49:52 -0600 (Wed, 27 Jan 2010) | 16 lines
 
 Merged revisions 243570 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r243570 | jpeeler | 2010-01-27 12:47:34 -0600 (Wed, 27 Jan 2010) | 9 lines
   
   Extend announcement URL used with Queue from 80 chars to PATH_MAX.
   
   (closes issue ASTERISK-15346)
   Reported by: syspert
   Patches:
         soundfilelen.pacth-2 uploaded by syspert (license 938)
   
   Review: https://reviewboard.asterisk.org/r/475/
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=243572
By: Digium Subversion (svnbot) 2010-01-27 12:52:35.000-0600

Repository: asterisk
Revision: 243573

_U  branches/1.6.2/
U   branches/1.6.2/apps/app_queue.c

------------------------------------------------------------------------
r243573 | jpeeler | 2010-01-27 12:52:35 -0600 (Wed, 27 Jan 2010) | 23 lines

Merged revisions 243571 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r243571 | jpeeler | 2010-01-27 12:49:52 -0600 (Wed, 27 Jan 2010) | 16 lines
 
 Merged revisions 243570 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r243570 | jpeeler | 2010-01-27 12:47:34 -0600 (Wed, 27 Jan 2010) | 9 lines
   
   Extend announcement URL used with Queue from 80 chars to PATH_MAX.
   
   (closes issue ASTERISK-15346)
   Reported by: syspert
   Patches:
         soundfilelen.pacth-2 uploaded by syspert (license 938)
   
   Review: https://reviewboard.asterisk.org/r/475/
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=243573
By: Digium Subversion (svnbot) 2010-01-27 12:56:23.000-0600

Repository: asterisk
Revision: 243574

_U  branches/1.6.1/
U   branches/1.6.1/apps/app_queue.c

------------------------------------------------------------------------
r243574 | jpeeler | 2010-01-27 12:56:22 -0600 (Wed, 27 Jan 2010) | 23 lines

Merged revisions 243571 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r243571 | jpeeler | 2010-01-27 12:49:52 -0600 (Wed, 27 Jan 2010) | 16 lines
 
 Merged revisions 243570 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r243570 | jpeeler | 2010-01-27 12:47:34 -0600 (Wed, 27 Jan 2010) | 9 lines
   
   Extend announcement URL used with Queue from 80 chars to PATH_MAX.
   
   (closes issue ASTERISK-15346)
   Reported by: syspert
   Patches:
         soundfilelen.pacth-2 uploaded by syspert (license 938)
   
   Review: https://reviewboard.asterisk.org/r/475/
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=243574
By: Digium Subversion (svnbot) 2010-01-27 14:35:57.000-0600

Repository: asterisk
Revision: 243691

U   branches/1.4/apps/app_queue.c

------------------------------------------------------------------------
r243691 | jpeeler | 2010-01-27 14:35:56 -0600 (Wed, 27 Jan 2010) | 5 lines

Revert 243570, I should have looked at this closer. Will reopen the issue, but
am leaving the review closed as the change was pointless.

(issue ASTERISK-15346)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=243691
By: Digium Subversion (svnbot) 2010-01-27 14:37:34.000-0600

Repository: asterisk
Revision: 243693

_U  trunk/
U   trunk/apps/app_queue.c

------------------------------------------------------------------------
r243693 | jpeeler | 2010-01-27 14:37:33 -0600 (Wed, 27 Jan 2010) | 12 lines

Merged revisions 243691 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r243691 | jpeeler | 2010-01-27 14:35:56 -0600 (Wed, 27 Jan 2010) | 5 lines
 
 Revert 243570, I should have looked at this closer. Will reopen the issue, but
 am leaving the review closed as the change was pointless.
 
 (issue ASTERISK-15346)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=243693
By: Digium Subversion (svnbot) 2010-01-27 14:38:20.000-0600

Repository: asterisk
Revision: 243694

_U  branches/1.6.0/
U   branches/1.6.0/apps/app_queue.c

------------------------------------------------------------------------
r243694 | jpeeler | 2010-01-27 14:38:20 -0600 (Wed, 27 Jan 2010) | 19 lines

Merged revisions 243693 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r243693 | jpeeler | 2010-01-27 14:37:33 -0600 (Wed, 27 Jan 2010) | 12 lines
 
 Merged revisions 243691 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r243691 | jpeeler | 2010-01-27 14:35:56 -0600 (Wed, 27 Jan 2010) | 5 lines
   
   Revert 243570, I should have looked at this closer. Will reopen the issue, but
   am leaving the review closed as the change was pointless.
   
   (issue ASTERISK-15346)
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=243694
By: Digium Subversion (svnbot) 2010-01-27 14:38:46.000-0600

Repository: asterisk
Revision: 243695

_U  branches/1.6.1/
U   branches/1.6.1/apps/app_queue.c

------------------------------------------------------------------------
r243695 | jpeeler | 2010-01-27 14:38:46 -0600 (Wed, 27 Jan 2010) | 19 lines

Merged revisions 243693 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r243693 | jpeeler | 2010-01-27 14:37:33 -0600 (Wed, 27 Jan 2010) | 12 lines
 
 Merged revisions 243691 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r243691 | jpeeler | 2010-01-27 14:35:56 -0600 (Wed, 27 Jan 2010) | 5 lines
   
   Revert 243570, I should have looked at this closer. Will reopen the issue, but
   am leaving the review closed as the change was pointless.
   
   (issue ASTERISK-15346)
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=243695
By: Digium Subversion (svnbot) 2010-01-27 14:39:12.000-0600

Repository: asterisk
Revision: 243696

_U  branches/1.6.2/
U   branches/1.6.2/apps/app_queue.c

------------------------------------------------------------------------
r243696 | jpeeler | 2010-01-27 14:39:11 -0600 (Wed, 27 Jan 2010) | 19 lines

Merged revisions 243693 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r243693 | jpeeler | 2010-01-27 14:37:33 -0600 (Wed, 27 Jan 2010) | 12 lines
 
 Merged revisions 243691 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r243691 | jpeeler | 2010-01-27 14:35:56 -0600 (Wed, 27 Jan 2010) | 5 lines
   
   Revert 243570, I should have looked at this closer. Will reopen the issue, but
   am leaving the review closed as the change was pointless.
   
   (issue ASTERISK-15346)
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=243696
By: Jeff Peeler (jpeeler) 2010-01-27 14:40:53.000-0600

We'll need some more information about the crash to proceed with this any further. Can you attach a backtrace? See doc/backtrace.txt.
By: raarts (raarts) 2010-01-28 03:01:51.000-0600

I think the real reason for this patch was not that asterisk crashed, but that syspert wants to use a filename longer than 80 chars.
By: Nico Kooijman (syspert) 2010-01-28 06:49:04.000-0600

[Jan 28 13:40:50] WARNING[20673]: file.c:949 ast_streamfile: Unable to open /etc/asterisk/company0003/sounds/this-is-a-very-long-name-to-proof-that-not-all (format 0x8 (alaw)): No such file or directory

With merging all our fixes from asterisk 1.2 I assumed there was a storage overlay. But the copy functions in asterisk 1.6 prevent the overlay in this case. So I have made a mistake and the description of the bug must be changed to:
Announce field in queue.conf cannot exceed 80 charachters.

this is the queue:
[2-nicorij] ; queue #2
music=neonova-default
announce=/etc/asterisk/company0003/sounds/this-is-a-very-long-name-to-proof-that-not-all-my-is-not-pointless-inspite-of-what-others-say.gsm
strategy=ringall
timeout=30
retry=3
wrapuptime=0
maxlen=0
announce-frequency=0
announce-holdtime=no
announce-round-seconds=30
joinempty=strict
leavewhenempty=strict
eventwhencalled=yes
member=SIP/ast162,0 ;   Nico Kooijman <222>