[Home]

Summary:ASTERISK-15335: [patch] cidname and cidnum in output of "sip show peers"
Reporter:Nico Kooijman (syspert)Labels:
Date Opened:2009-12-18 10:06:45.000-0600Date Closed:2010-10-15 11:46:08
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/NewFeature
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) sipshowpeer.patch
Description:The peers overview with this patch will show the callerid (name and num). This will make it a bit easier to lookup a specific sip peer because the name is showed.


****** ADDITIONAL INFORMATION ******

Also a little alignment error fixed in the renamed field Forcerport.
Comments:By: Nico Kooijman (syspert) 2010-01-18 05:05:20.000-0600

I checked out a fresh copy of the trunk and tested the patch myself. It works good.
By: Russell Bryant (russell) 2010-01-18 16:04:28.000-0600

Thank you for the patch.  Unfortunately, we can't apply this.  There is only so much information we can put on one line and have it still be useful.  I'm glad you were able to modify the code to suit your own needs, but I'd rather not add any additional information to this line in the main source tree.
By: Nico Kooijman (syspert) 2010-01-19 02:31:49.000-0600

In my opinion this call is closed for the wrong reason.
ie, the
iax2 show channels
Channel               Peer             Username    ID (Lo/Rem)  Seq (Tx/Rx)  Lag      Jitter  JitBuf  Format  FirstMsg    LastMsg
IAX2/arsk18-12887     192.168.170.6    arsk18      12887/00023  00005/00003  00000ms  0043ms  0083ms  gsm     Rx:NEW      Rx:ACK    

contains much more info.

second reason, the fix also contains an alignment error.

And I would like to know what the limit is of information put on one line and where it is defined?
By: raarts (raarts) 2010-01-19 03:21:43.000-0600

I suppose you mean the 80-char limit on consoles. I agree with syspert that some commands result in output > 80 chars, I also understand the 80 char limit, but working on a 80x25 console is increasingly less common.

On the other hand this information is very useful while troubleshooting.
Let me say that again. It is EXTREMELY helpful in the communication with customers. I was planning the upload a patch that adds callerid info to all messages that now say: 'SIP/aaa2 is ringing' or 'DAHDI/2-3 is busy' or 'SIP/aaas' hung up'. When you are looking at logs this saves a great deal of time in explaining things to the customer.
By: John Todd (jtodd) 2010-03-18 15:08:13

Let's have a discussion about this on -dev.  I'd like to see a number of people discuss this and respond in one way or the other with well-reasoned examples and possible solutions.  Putting more stuff in the CLI responses is a big problem; things are already a mess as they are.
By: raarts (raarts) 2010-06-20 14:23:06

The discussion on asterisk-dev starts here: http://lists.digium.com/pipermail/asterisk-dev/2010-March/043074.html.

The outcome was that in general all responders but one (who agreed with my view) thought it would be better to either use AMI output, or extending the current logging infrastructure.
By: Russell Bryant (russell) 2010-10-15 11:46:07

closed per discussion