Summary:ASTERISK-15303: [patch] Send manager event on Call Pickup
Reporter:Nico Kooijman (syspert)Labels:
Date Opened:2009-12-11 09:16:49.000-0600Date Closed:2010-01-15 15:04:37.000-0600
Versions:Frequency of
Environment:Attachments:( 0) 20100112__issue16431.diff.txt
( 1) manager-pickup.diff
( 2) manager-pickup-16431-trunk-20091211.patch
Description:We need a manager event to be sent when a call is being picked up.
Patch attached.
NOTE: I filed this under Applications/app_directed_pickup, but the patch also applies to main/features.c


The event looks like follows:

Event: Pickup
Privilege: call,all
Channel: SIP/ast163-00000002
UniqueID: astium-21-1260544087.2
TargetChannel: SIP/ast164-00000001
TargetUniqueID: astium-21-1260544084.1
Comments:By: dant (dant) 2009-12-11 09:28:14.000-0600

Patch fails to apply to trunk, patch against trunk attached.

By: Leif Madsen (lmadsen) 2009-12-11 14:31:21.000-0600

Thanks dant! Since this is a feature, it should have been filed against trunk, but now the reporter knows better :)

Thanks for the feature syspert!

By: Leif Madsen (lmadsen) 2009-12-11 14:31:56.000-0600

Ideally, if you can get someone from the asterisk-dev and/or asterisk-users mailing lists to test this out and report back here, that would be fantastic!

By: Nico Kooijman (syspert) 2009-12-16 18:08:03.000-0600

I know better now, and after a hard stuggle to get the trunk working, I got it working with the new event's. I'll post a request on the users mailinglist.

By: Nico Kooijman (syspert) 2009-12-21 06:40:06.000-0600

I did put a request on the users mailinglist but there were no reactions at all. The only refence is my own test after applying the patch on the trunk.

I hope this is enough for you?

By: Leif Madsen (lmadsen) 2009-12-21 12:11:03.000-0600

That is fine for now. Thank you for trying.

By: Tilghman Lesher (tilghman) 2010-01-12 14:37:32.000-0600

I'd go with a patch matched with the new API, which allows you to generate variables to be retrieved for each channel passed.  Thus, no uniqueid is necessary (anymore).

By: Nico Kooijman (syspert) 2010-01-13 04:19:19.000-0600

Just a question, the Uniqueid is sent with allmost every event. By adding the generated variable the uniqueid will be sent twice on those events. Is it planned to remove all Uniqueid's from them?

By: Tilghman Lesher (tilghman) 2010-01-13 09:39:51.000-0600

Eventually, yes.  However, there's a fairly long transition period ahead, while external programs make the switch.

By: Digium Subversion (svnbot) 2010-01-15 15:04:35.000-0600

Repository: asterisk
Revision: 240421

U   trunk/apps/app_directed_pickup.c
U   trunk/include/asterisk/manager.h
U   trunk/main/features.c

r240421 | tilghman | 2010-01-15 15:04:35 -0600 (Fri, 15 Jan 2010) | 6 lines

Add pickup event to AMI.  Also, fix AMI documentation.
(closes issue ASTERISK-15303)
Reported by: syspert
      20100112__issue16431.diff.txt uploaded by tilghman (license 14)