| Summary: | ASTERISK-15290: Ignoring unknown format wav & wav49... | ||||
| Reporter: | jiddings (jiddings) | Labels: | |||
| Date Opened: | 2009-12-08 08:54:51.000-0600 | Date Closed: | 2010-01-05 09:16:22.000-0600 | ||
| Priority: | Major | Regression? | Yes | ||
| Status: | Closed/Complete | Components: | Formats/General | ||
| Versions: | Frequency of Occurrence | ||||
| Related Issues: |
| ||||
| Environment: | Attachments: | ||||
| Description: | file.c: ignoring unknown format 'wav49' file.c: ignoring unknown format 'wav' Though format_wav.so and format_wav_gsm.so is loading properly. This seems to have started after the file.c commit to the 1.6.2 branch on December 1st. | ||||
| Comments: | By: Russell Bryant (russell) 2009-12-08 10:53:35.000-0600 What do you have set for the format option in the [general] section of voicemail.conf? I can't seem to reproduce the warning. By: jiddings (jiddings) 2009-12-08 10:57:30.000-0600 format=wav49|gsm|wav By: jiddings (jiddings) 2009-12-08 11:04:17.000-0600 Just to make sure, I did a 'make clean' and rebuilt using the latest checkout (1.6.2-r233689).. same issue. By: Leif Madsen (lmadsen) 2009-12-08 11:12:24.000-0600 <xheliox> Not by my direction. <xheliox> Should I put format_wav.so and wav_gsm before app_voicemail in modules.conf? <kpfleming> you are using autoload=yes? <xheliox> Yes. <xheliox> I just preload them.. <xheliox> and that error went away <xheliox> let me try leaving a vm <kpfleming> ok, then that is the issue <kpfleming> it's a load order problem By: Leif Madsen (lmadsen) 2009-12-08 11:14:59.000-0600 I'm moving this away from being a blocker as the trick is just to preload the formats you need prior to the module that needs to use them. By: Digium Subversion (svnbot) 2009-12-08 12:00:18.000-0600 Repository: asterisk Revision: 233692 U trunk/formats/format_g723.c U trunk/formats/format_g726.c U trunk/formats/format_g729.c U trunk/formats/format_gsm.c U trunk/formats/format_h263.c U trunk/formats/format_h264.c U trunk/formats/format_ilbc.c U trunk/formats/format_jpeg.c U trunk/formats/format_ogg_vorbis.c U trunk/formats/format_pcm.c U trunk/formats/format_siren14.c U trunk/formats/format_siren7.c U trunk/formats/format_sln.c U trunk/formats/format_sln16.c U trunk/formats/format_vox.c U trunk/formats/format_wav.c U trunk/formats/format_wav_gsm.c ------------------------------------------------------------------------ r233692 | russell | 2009-12-08 12:00:17 -0600 (Tue, 08 Dec 2009) | 16 lines Set a module load priority for format modules. A recent change to app_voicemail made it such that the module now assumes that all format modules are available while processing voicemail configuration. However, when autoloading modules, it was possible that app_voicemail was loaded before the format modules. Since format modules don't depend on anything, set a module load priority on them to ensure that they get loaded first when autoloading. This fix applies to trunk, 1.6.1, and 1.6.2. The fix for 1.4 and 1.6.0 will require a different approach since the module load priority functionality is not present in the module API. (issue ASTERISK-15290) Reported by: jiddings ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=233692 By: Digium Subversion (svnbot) 2009-12-08 12:02:39.000-0600 Repository: asterisk Revision: 233693 _U branches/1.6.1/ U branches/1.6.1/formats/format_g723.c U branches/1.6.1/formats/format_g726.c U branches/1.6.1/formats/format_g729.c U branches/1.6.1/formats/format_gsm.c U branches/1.6.1/formats/format_h263.c U branches/1.6.1/formats/format_h264.c U branches/1.6.1/formats/format_ilbc.c U branches/1.6.1/formats/format_jpeg.c U branches/1.6.1/formats/format_ogg_vorbis.c U branches/1.6.1/formats/format_pcm.c U branches/1.6.1/formats/format_sln.c U branches/1.6.1/formats/format_sln16.c U branches/1.6.1/formats/format_vox.c U branches/1.6.1/formats/format_wav.c U branches/1.6.1/formats/format_wav_gsm.c ------------------------------------------------------------------------ r233693 | russell | 2009-12-08 12:02:38 -0600 (Tue, 08 Dec 2009) | 23 lines Merged revisions 233692 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r233692 | russell | 2009-12-08 12:00:16 -0600 (Tue, 08 Dec 2009) | 16 lines Set a module load priority for format modules. A recent change to app_voicemail made it such that the module now assumes that all format modules are available while processing voicemail configuration. However, when autoloading modules, it was possible that app_voicemail was loaded before the format modules. Since format modules don't depend on anything, set a module load priority on them to ensure that they get loaded first when autoloading. This fix applies to trunk, 1.6.1, and 1.6.2. The fix for 1.4 and 1.6.0 will require a different approach since the module load priority functionality is not present in the module API. (issue ASTERISK-15290) Reported by: jiddings ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=233693 By: Digium Subversion (svnbot) 2009-12-08 12:04:01.000-0600 Repository: asterisk Revision: 233694 _U branches/1.6.2/ U branches/1.6.2/formats/format_g723.c U branches/1.6.2/formats/format_g726.c U branches/1.6.2/formats/format_g729.c U branches/1.6.2/formats/format_gsm.c U branches/1.6.2/formats/format_h263.c U branches/1.6.2/formats/format_h264.c U branches/1.6.2/formats/format_ilbc.c U branches/1.6.2/formats/format_jpeg.c U branches/1.6.2/formats/format_ogg_vorbis.c U branches/1.6.2/formats/format_pcm.c U branches/1.6.2/formats/format_siren14.c U branches/1.6.2/formats/format_siren7.c U branches/1.6.2/formats/format_sln.c U branches/1.6.2/formats/format_sln16.c U branches/1.6.2/formats/format_vox.c U branches/1.6.2/formats/format_wav.c U branches/1.6.2/formats/format_wav_gsm.c ------------------------------------------------------------------------ r233694 | russell | 2009-12-08 12:04:01 -0600 (Tue, 08 Dec 2009) | 23 lines Merged revisions 233692 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r233692 | russell | 2009-12-08 12:00:16 -0600 (Tue, 08 Dec 2009) | 16 lines Set a module load priority for format modules. A recent change to app_voicemail made it such that the module now assumes that all format modules are available while processing voicemail configuration. However, when autoloading modules, it was possible that app_voicemail was loaded before the format modules. Since format modules don't depend on anything, set a module load priority on them to ensure that they get loaded first when autoloading. This fix applies to trunk, 1.6.1, and 1.6.2. The fix for 1.4 and 1.6.0 will require a different approach since the module load priority functionality is not present in the module API. (issue ASTERISK-15290) Reported by: jiddings ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=233694 By: jiddings (jiddings) 2009-12-08 12:07:06.000-0600 Tested -- issue seems to be resolved. Thanks! By: Russell Bryant (russell) 2009-12-08 18:59:16.000-0600 No problem. Now I'm working on a solution for Asterisk 1.4 and 1.6.0. https://reviewboard.asterisk.org/r/445 By: Digium Subversion (svnbot) 2009-12-09 09:14:23.000-0600 Repository: asterisk Revision: 233782 U branches/1.4/formats/format_g723.c U branches/1.4/formats/format_g726.c U branches/1.4/formats/format_g729.c U branches/1.4/formats/format_gsm.c U branches/1.4/formats/format_h263.c U branches/1.4/formats/format_h264.c U branches/1.4/formats/format_ilbc.c U branches/1.4/formats/format_jpeg.c U branches/1.4/formats/format_ogg_vorbis.c U branches/1.4/formats/format_pcm.c U branches/1.4/formats/format_sln.c U branches/1.4/formats/format_vox.c U branches/1.4/formats/format_wav.c U branches/1.4/formats/format_wav_gsm.c U branches/1.4/include/asterisk/module.h U branches/1.4/main/loader.c ------------------------------------------------------------------------ r233782 | russell | 2009-12-09 09:14:22 -0600 (Wed, 09 Dec 2009) | 22 lines Set a module load priority for format modules. A recent change to app_voicemail made it such that the module now assumes that all format modules are available while processing voicemail configuration. However, when autoloading modules, it was possible that app_voicemail was loaded before the format modules. Since format modules don't depend on anything, set a module load priority on them to ensure that they get loaded first when autoloading. This version of the patch is specific to Asterisk 1.4 and 1.6.0. These versions did not already support module load priority in the module API. This adds a trivial version of this which is just a module flag to include it in a pass before loading "everything". Thanks to mmichelson for the review! (closes issue ASTERISK-15290) Reported by: jiddings Tested by: russell Review: https://reviewboard.asterisk.org/r/445/ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=233782 By: Digium Subversion (svnbot) 2009-12-09 09:15:03.000-0600 Repository: asterisk Revision: 233783 _U trunk/ ------------------------------------------------------------------------ r233783 | russell | 2009-12-09 09:15:03 -0600 (Wed, 09 Dec 2009) | 28 lines Blocked revisions 233782 via svnmerge ........ r233782 | russell | 2009-12-09 09:14:21 -0600 (Wed, 09 Dec 2009) | 22 lines Set a module load priority for format modules. A recent change to app_voicemail made it such that the module now assumes that all format modules are available while processing voicemail configuration. However, when autoloading modules, it was possible that app_voicemail was loaded before the format modules. Since format modules don't depend on anything, set a module load priority on them to ensure that they get loaded first when autoloading. This version of the patch is specific to Asterisk 1.4 and 1.6.0. These versions did not already support module load priority in the module API. This adds a trivial version of this which is just a module flag to include it in a pass before loading "everything". Thanks to mmichelson for the review! (closes issue ASTERISK-15290) Reported by: jiddings Tested by: russell Review: https://reviewboard.asterisk.org/r/445/ ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=233783 By: Digium Subversion (svnbot) 2009-12-09 09:29:00.000-0600 Repository: asterisk Revision: 233841 _U branches/1.6.0/UPGRADE-1.6.txt _U branches/1.6.0/UPGRADE.txt U branches/1.6.0/formats/format_g723.c U branches/1.6.0/formats/format_g726.c U branches/1.6.0/formats/format_g729.c U branches/1.6.0/formats/format_gsm.c U branches/1.6.0/formats/format_h263.c U branches/1.6.0/formats/format_h264.c U branches/1.6.0/formats/format_ilbc.c U branches/1.6.0/formats/format_jpeg.c U branches/1.6.0/formats/format_ogg_vorbis.c U branches/1.6.0/formats/format_pcm.c U branches/1.6.0/formats/format_sln.c U branches/1.6.0/formats/format_sln16.c U branches/1.6.0/formats/format_vox.c U branches/1.6.0/formats/format_wav.c U branches/1.6.0/formats/format_wav_gsm.c U branches/1.6.0/include/asterisk/module.h _U branches/1.6.0/main/editline/makelist.in U branches/1.6.0/main/loader.c ------------------------------------------------------------------------ r233841 | russell | 2009-12-09 09:29:00 -0600 (Wed, 09 Dec 2009) | 22 lines Set a module load priority for format modules. A recent change to app_voicemail made it such that the module now assumes that all format modules are available while processing voicemail configuration. However, when autoloading modules, it was possible that app_voicemail was loaded before the format modules. Since format modules don't depend on anything, set a module load priority on them to ensure that they get loaded first when autoloading. This version of the patch is specific to Asterisk 1.4 and 1.6.0. These versions did not already support module load priority in the module API. This adds a trivial version of this which is just a module flag to include it in a pass before loading "everything". Thanks to mmichelson for the review! (closes issue ASTERISK-15290) Reported by: jiddings Tested by: russell Review: https://reviewboard.asterisk.org/r/445/ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=233841 | ||||