Summary:ASTERISK-15275: vsendonly is write only
Reporter:David Woolley (davidw)Labels:
Date Opened:2009-12-04 13:22:06.000-0600Date Closed:2014-05-03 18:31:47
Versions:Frequency of
Description:The value of vsendonly, in process_sdp, is never used.  The only time it is ever read is to check that whether it has previously been set.


See also notes about the need to track this at dialogue level or use it to get a lowest common denominator hold state, in ASTERISK-13496.

The "has been previously set" test is also wrong as the SDP RFC (RFC 2327) says:

 In general, session-level values are the default for all media unless
 overridden by an equivalent media-level value.

so the later value should take precedence.

(I wonder if I should be raising all these points as separate issues, or overloading existing ones more.)
Comments:By: David Woolley (davidw) 2009-12-07 07:17:39.000-0600

Looks like this relates to ASTERISK-14035, in that this is what introduced proper handling of a= on multiple streams (but not for both that and a global a=).  I'm not sure where the first occurrence only logic comes from.  Maybe that was an earlier attempt to work around ASTERISK-14035 type problems.

By: Leif Madsen (lmadsen) 2009-12-07 14:20:52.000-0600

I'd rather see these as separate issues rather than trying to overload a single issue (as that tends to get rather messy). Thanks for opening them separately!

By: Matt Jordan (mjordan) 2014-05-03 18:31:33.296-0500

Looks like {{vsendonly}} got refactored out of process_sdp sometime in 1.8. I'm going to close this out as "Fixed", since I can't find the variable any more :-)