Summary:	ASTERISK-15274: [patch] App MeeMe Set the channels' account code to the conference room number
Reporter:	pta200 (pta200)	Labels:
Date Opened:	2009-12-04 10:37:13.000-0600	Date Closed:	2011-05-06 17:02:59
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_meetme
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) app_meetme.diff ( 1) app_meetme-r268810.diff ( 2) app_meetme-trunk-r238635M.diff
Description:	This is a patch to the latest version of 1.4.27 such that the user can specify option 'y' to have the meetme application set the channel's account code to the conference room number. This is some functionality that our client's conference server needed. I wrote this because we wanted to use the meetme application's error handling to prompt for both conference room and pin number. Not having the conference room number prior to calling meetme and our customer needing the cdr to have an account code for billing purposes I added the option. Also part of the motivation for adding this was that as I was searching the web for ways of doing this in the dialplan I found many people over the last few years wanting the same type of functionality. ****** ADDITIONAL INFORMATION ****** If there is interest in this I'll update the 1.6 versions as well.
Comments:	By: Leif Madsen (lmadsen) 2009-12-07 14:30:49.000-0600 Thanks for the contribution! However, for this to be considered for future versions, you will need to update your patch for the latest Asterisk trunk (not a released version) as new features only go into future, and not current, versions. This could potentially make it for Asterisk 1.8 which will eventually be branched from trunk. Thanks! By: pta200 (pta200) 2009-12-07 14:47:07.000-0600 Is there not going to be a 1.7 or was 1.8 a typo? What about 1.6.2.0 since it still only a release candidate and the code for this feature is so small? thanks, Paolo By: Leif Madsen (lmadsen) 2009-12-07 15:04:02.000-0600 I think this link would be useful to answer your question about 1.7:  http://blogs.asterisk.org/2009/11/10/asterisk-project-update-astricon-2009/  -- 1.8 was not a typo. However, we have never used odd numbers in our releases (1.0, 1.2, 1.4, 1.6.x, 1.8, etc...) (please ignore the use of odd numbers prior to the release of 1.0 :)) Odd numbers (1.3, 1.5, 1.7, 1.9) would typically mean development snapshots for future releases, but we don't do that. New features are not permitted in branches outside of trunk -- as soon as a branch is created, that is a feature frozen set of code, and only bug fixes are then permitted at that point -- no matter how small the feature. 1.6.2 was feature frozen the moment it was branched from trunk. By: Leif Madsen (lmadsen) 2010-01-07 11:11:52.000-0600 Pinging reporter for some feedback on the feature they've submitted? By: pta200 (pta200) 2010-01-07 11:18:13.000-0600 Sorry, I've been swamped with work and out for the holidays. I'll update the patch to the latest Asterisk trunk shortly and post it. By: pta200 (pta200) 2010-01-08 17:02:59.000-0600 Uploaded a patch for SVN trunk-r238635M revision 238795 By: Russell Bryant (russell) 2010-05-18 14:07:47 What if we take a bit more of a generic approach and add a new channel variable that MeetMe() sets that includes the conference bridge number?  Then, you could put it in the CDR, or do whatever else you wanted to do with it from the dialplan. By: John Todd (jtodd) 2010-05-18 14:09:06 This is a really nice feature; but I agree with what Russell says. Changing the accountcode is probably a dangerous thing to do, and may cause unexpected results for people who are not expecting that.  A more generic variable could be used to change the accountcode if that was the intended result. By: pta200 (pta200) 2010-06-07 12:20:00 Just so I have this straight in my head before updating the code, going the channel variable route would mean the users dial plan would need an 'h' extension in the context containing the call to MeetMe application to perform Set with the CDR function using the value in the channel variable right? By: pta200 (pta200) 2010-06-07 16:36:41 Uploaded a diff file using the latest trunk code that populates a channel variable called CONFROOMNUM with the conference room number. By: Russell Bryant (russell) 2011-05-06 17:02:58 I took a look and it looks like there is a variable that can be used for this already - MEETMEUNIQUEID.