[Home]

Summary:ASTERISK-15270: [patch] Missing session level connection data (c=) breaks process_sdp()
Reporter:zalex (zalex)Labels:
Date Opened:2009-12-03 13:20:21.000-0600Date Closed:2010-01-05 09:22:16.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/T.38
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) media-level-c-fix1.diff
Description:OK coming in response to our re-INVITE contains connection data (c=) in a media description (image), not at the session level (which is fine according to rfc 4566). process_sdp() sets ihp but hp stays NULL. It exits with "Insufficient information in SDP (c=)..." log message.

****** ADDITIONAL INFORMATION ******

My fix is below but it's not generic.

} else if (image) {
     if (process_sdp_c(value, &imagehp)) {
           processed = TRUE;
           ihp = &imagehp.hp;
      // Added two lines
           if ( !hp )
              hp = ihp;
     }
}
Comments:By: Matthew Nicholson (mnicholson) 2009-12-04 14:40:17.000-0600

Try the patch I just uploaded and let me know if it fixes your issue.
By: zalex (zalex) 2009-12-04 16:35:38.000-0600

The patch works.
By: Digium Subversion (svnbot) 2009-12-07 10:11:17.000-0600

Repository: asterisk
Revision: 233392

U   branches/1.4/channels/chan_sip.c

------------------------------------------------------------------------
r233392 | mnicholson | 2009-12-07 10:11:17 -0600 (Mon, 07 Dec 2009) | 7 lines

Allow SDP packets with only video session information.

(closes issue ASTERISK-15270)
Reported by: zalex1953
Tested by: mnicholson, zalex1953


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=233392
By: Digium Subversion (svnbot) 2009-12-07 10:13:30.000-0600

Repository: asterisk
Revision: 233393

_U  trunk/

------------------------------------------------------------------------
r233393 | mnicholson | 2009-12-07 10:13:30 -0600 (Mon, 07 Dec 2009) | 12 lines

Blocked revisions 233392 via svnmerge

........
 r233392 | mnicholson | 2009-12-07 10:11:16 -0600 (Mon, 07 Dec 2009) | 7 lines
 
 Allow SDP packets with only video session information.
 
 (closes issue ASTERISK-15270)
 Reported by: zalex1953
 Tested by: mnicholson, zalex1953
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=233393
By: Digium Subversion (svnbot) 2009-12-07 10:14:44.000-0600

Repository: asterisk
Revision: 233394

U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r233394 | mnicholson | 2009-12-07 10:14:43 -0600 (Mon, 07 Dec 2009) | 8 lines

Do not reject SDP packets describing only non audio streams.

(closes issue ASTERISK-15270)
Reported by: zalex1953
Patches:
     media-level-c-fix1.diff uploaded by mnicholson (license 96)
Tested by: mnicholson, zalex1953

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=233394
By: Digium Subversion (svnbot) 2009-12-07 10:16:16.000-0600

Repository: asterisk
Revision: 233395

_U  branches/1.6.1/
U   branches/1.6.1/channels/chan_sip.c

------------------------------------------------------------------------
r233395 | mnicholson | 2009-12-07 10:16:15 -0600 (Mon, 07 Dec 2009) | 15 lines

Merged revisions 233394 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r233394 | mnicholson | 2009-12-07 10:14:42 -0600 (Mon, 07 Dec 2009) | 8 lines
 
 Do not reject SDP packets describing only non audio streams.
 
 (closes issue ASTERISK-15270)
 Reported by: zalex1953
 Patches:
       media-level-c-fix1.diff uploaded by mnicholson (license 96)
 Tested by: mnicholson, zalex1953
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=233395
By: Digium Subversion (svnbot) 2009-12-07 10:16:19.000-0600

Repository: asterisk
Revision: 233396

_U  branches/1.6.2/
U   branches/1.6.2/channels/chan_sip.c

------------------------------------------------------------------------
r233396 | mnicholson | 2009-12-07 10:16:19 -0600 (Mon, 07 Dec 2009) | 15 lines

Merged revisions 233394 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r233394 | mnicholson | 2009-12-07 10:14:42 -0600 (Mon, 07 Dec 2009) | 8 lines
 
 Do not reject SDP packets describing only non audio streams.
 
 (closes issue ASTERISK-15270)
 Reported by: zalex1953
 Patches:
       media-level-c-fix1.diff uploaded by mnicholson (license 96)
 Tested by: mnicholson, zalex1953
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=233396
By: Digium Subversion (svnbot) 2009-12-07 10:16:33.000-0600

Repository: asterisk
Revision: 233397

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_sip.c

------------------------------------------------------------------------
r233397 | mnicholson | 2009-12-07 10:16:33 -0600 (Mon, 07 Dec 2009) | 15 lines

Merged revisions 233394 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r233394 | mnicholson | 2009-12-07 10:14:42 -0600 (Mon, 07 Dec 2009) | 8 lines
 
 Do not reject SDP packets describing only non audio streams.
 
 (closes issue ASTERISK-15270)
 Reported by: zalex1953
 Patches:
       media-level-c-fix1.diff uploaded by mnicholson (license 96)
 Tested by: mnicholson, zalex1953
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=233397