[Home]

Summary:ASTERISK-15266: [patch] Implicit declaration of 'ast_complete_source_filename' and 'ast_rtp_destroy' with LOW_MEMORY enabled in trunk
Reporter:Michael Iedema (michael_iedema)Labels:
Date Opened:2009-12-03 08:34:34.000-0600Date Closed:2010-12-20 09:05:55.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/BuildSystem
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) ast_complete_source_filename.patch
Description:Building trunk with LOW_MEMORY enabled fails with linker errors caused by implicit declaration of ast_complete_source_filename and ast_rtp_destroy.

using trunk r232365 these two issues are:

1. ast_complete_source_filename is not included in asterisk.{c,h} when LOW_MEMORY is set, however it is used unconditionally in handle_verbose cli.c:410

2. ast_rtp_destroy is also implicitly declared in chan_sip.c:9347...although I can't quite work out why that is. The snip is here:

#ifdef LOW_MEMORY
static void ts_ast_rtp_destroy(void *data)
{
   struct ast_rtp *tmp = data;
   ast_rtp_destroy(tmp);
}
#endif


Disabling LOW_MEMORY in my configuration resolves both of these issues. In Asterisk 1.6.2-rc7 I also saw issue #1 crop up but did not notice #2.
Comments:By: Michael Iedema (michael_iedema) 2009-12-04 04:21:03.000-0600

This patch resolves issue #1. Still looking at part 2.
By: Digium Subversion (svnbot) 2009-12-30 14:34:42.000-0600

Repository: asterisk
Revision: 236893

U   trunk/channels/chan_sip.c
U   trunk/main/cli.c

------------------------------------------------------------------------
r236893 | jpeeler | 2009-12-30 14:34:42 -0600 (Wed, 30 Dec 2009) | 11 lines

Fix compiling with LOW_MEMORY.

Modified handle_verbose to be LOW_MEMORY aware, removed old RTP related code
in chan_sip.

(closes issue ASTERISK-15266)
Reported by: michael_iedema
Patches:
     ast_complete_source_filename.patch uploaded by michael iedema (license 942)
     modified by me

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=236893
By: Digium Subversion (svnbot) 2009-12-30 15:06:18.000-0600

Repository: asterisk
Revision: 236899

_U  branches/1.6.2/
U   branches/1.6.2/main/cli.c

------------------------------------------------------------------------
r236899 | jpeeler | 2009-12-30 15:06:18 -0600 (Wed, 30 Dec 2009) | 17 lines

Merged revisions 236893 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r236893 | jpeeler | 2009-12-30 14:34:41 -0600 (Wed, 30 Dec 2009) | 11 lines
 
 Fix compiling with LOW_MEMORY.
 
 Modified handle_verbose to be LOW_MEMORY aware.
 
 (closes issue ASTERISK-15266)
 Reported by: michael_iedema
 Patches:
       ast_complete_source_filename.patch uploaded by michael iedema (license 942)
       modified by me
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=236899
By: Digium Subversion (svnbot) 2009-12-30 15:07:25.000-0600

Repository: asterisk
Revision: 236900

_U  branches/1.6.1/

------------------------------------------------------------------------
r236900 | jpeeler | 2009-12-30 15:07:25 -0600 (Wed, 30 Dec 2009) | 17 lines

Blocked revisions 236893 via svnmerge

........
 r236893 | jpeeler | 2009-12-30 14:34:41 -0600 (Wed, 30 Dec 2009) | 11 lines
 
 Fix compiling with LOW_MEMORY.
 
 Modified handle_verbose to be LOW_MEMORY aware, removed old RTP related code
 in chan_sip.
 
 (closes issue ASTERISK-15266)
 Reported by: michael_iedema
 Patches:
       ast_complete_source_filename.patch uploaded by michael iedema (license 942)
       modified by me
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=236900
By: Digium Subversion (svnbot) 2009-12-30 15:07:55.000-0600

Repository: asterisk
Revision: 236901

_U  branches/1.6.0/

------------------------------------------------------------------------
r236901 | jpeeler | 2009-12-30 15:07:55 -0600 (Wed, 30 Dec 2009) | 17 lines

Blocked revisions 236893 via svnmerge

........
 r236893 | jpeeler | 2009-12-30 14:34:41 -0600 (Wed, 30 Dec 2009) | 11 lines
 
 Fix compiling with LOW_MEMORY.
 
 Modified handle_verbose to be LOW_MEMORY aware, removed old RTP related code
 in chan_sip.
 
 (closes issue ASTERISK-15266)
 Reported by: michael_iedema
 Patches:
       ast_complete_source_filename.patch uploaded by michael iedema (license 942)
       modified by me
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=236901